From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D312366DA6 for ; Mon, 2 Feb 2026 13:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770038993; cv=none; b=ZzWkY7gUOoRHHZ+toTQzJTJXd2A4ls6u/zrNVshxjrwJYBxxoz9xlWRA5RUee+mV56xxGpGqnNXgK1++CrY48XNNR0X6wCZjTveyF/mfHk9fLzw0z+CQvjbEWqQx59I/L4OMM9E7OeH4QhLqWc8E5YGRcxzpapnC3c9M686218I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770038993; c=relaxed/simple; bh=WaHKZ/McEXzUzbe8XhWNI/3c2hNKFJZt7wOD2NDguBw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jYJ967TFb/Uri4m3+4v6kFmDRjcy9JE1AN6ZH90zs0NfiU5ltDfRqT4rQF1K7v2e3UA/0Vh3PcSF4xENLsdldHw3rDKnHRNBSTbWfXnak/YU/4j1itkzqaFcadpftZUXU+3ckoxuug2iiAWaZ0j8G7It4mKQDDqNu3FuC7JCzOY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i+TwLkTA; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i+TwLkTA" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-4806a7ec499so2861965e9.3 for ; Mon, 02 Feb 2026 05:29:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770038991; x=1770643791; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SgTWxHTq6zBlc2AIUdyfY21mpRfZc8LW47kfkCH8qhg=; b=i+TwLkTAuSWAx2cq1nDH+R4qjEPkMakDvejMuiQ92jOwG0KD5EUOsxF6OziGlgWLRk 0GLxTJ38orhozZATg7HzJiGl9Ttf2WN5Bt6D2F3CGDew2widkmPjncATaLDFMOTu/YpZ t5aYCCkFsJ+BnpdIeBorhgCjzewmWyvxgnW1xaEKWL/XfTuhsbrF+Pyo9E0lPGWT5MIV qVjkhc0VoooXu8ecHzJRVTDV1uo2cstISjWSH4dQs3pGBqrAkNo8iXExdtTqMz/1Rclu ITR/AbdIE9qy1fo34C78P5kPcptRv25rvytr0P1zSKfj9hcTILCE/oEmtzUG2Yu+b61M HLjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770038991; x=1770643791; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SgTWxHTq6zBlc2AIUdyfY21mpRfZc8LW47kfkCH8qhg=; b=f4Ksy90PT12dvDbnP62qYndv19su+O/uBbu9q8bBpSQeeh7/zpLii6p+U1HbbL+LK/ JKceRTBkuvvV7pi0gQQVjzM14y7EbnMjuaYARFzREBPm7gmTSxVNNKTVzIfCP5FgfPW2 jKSrlzlf0212dpDQpGKAF8Rytqs9G0yn0N1HBZyHuFHxK+e0l84aghTp/x7JS+T3sbcg Sa1KhNxG6vexNiMuQOrMoB6FwPYgrBQVJB/8e3UTIeTyN4W0PiZ3Fwy/P+biomtp4Y80 IlWjv7fbfvKrIALXqRGXe8TSOFRbwa9HJoPVmLBiekHWg1uSbRBU6KzAhO92Fb8tdBVn KVUw== X-Forwarded-Encrypted: i=1; AJvYcCXmglyHTNLu1LaRTFhCAYnX75pKArvGa/AauZF4zyDsLEPUt6QqoTI9tnZcWdBtDR5cU0Ilw7c9i4Yw3OE=@vger.kernel.org X-Gm-Message-State: AOJu0YzrKeS/v8OrAdGcuUvdupU0UASp+Fh+f02x7BjtcjTkolm0nAvB jJMrhBamYWhusnQTEbAhfLvyzgCZ9oLos0+6G1jNhz6j4IZG0ykO6LJGHzdb+6MV X-Gm-Gg: AZuq6aKr406RfDYBNkNxNW6hDStzQxIuIhOl8Y6K5ymlxwJI+nruG8LTt+gPeCet3ZQ Fo5aAfhOuwF32W289SEnI5800IAsnpmXJX6Jjpw+DEUAkzY4gXlYJGiNxK/sBlGkK2XNyeTmCAQ U89ybSDZuRl5pFzfh2Jd4ybvJyBpZgaJseXAIFb/eOTNQOIBB00LSf1Es7Y9DfiswI4Wwz/6iM4 qpPmDmSI6wO06Pu0aZO434nXHP7Am/9ItCAuunjacscZThVmj2Won9MEvE4GpdIQMOuMeCIhiR6 YtZY4bP7lQRo+LEZ65V2qasEioSIBEBf2rvku9Z8F8pnu1RNtEjcC6wk8mcmzMHN/65kG4HWQ3k s3Bp9e2CSDJLlAcqEQV9HOf3ZsOSNrzBUGRoAX8s+MXOtWCL1720iuVxme9SH4hSERhUSDh47B7 EFoVc= X-Received: by 2002:a05:600c:8b61:b0:47b:d992:601e with SMTP id 5b1f17b1804b1-482db4568b0mr95233925e9.2.1770038990732; Mon, 02 Feb 2026 05:29:50 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:74c4:3a65:f9a9:6c29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482da903a30sm117174295e9.1.2026.02.02.05.29.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 05:29:50 -0800 (PST) Date: Mon, 2 Feb 2026 15:29:47 +0200 From: Vladimir Oltean To: "Bastien Curutchet (Schneider Electric)" Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Simon Horman , Pascal Eberhard , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 5/8] net: dsa: microchip: Add KSZ8463 tail tag handling Message-ID: <20260202132947.gepuhzdh4bepk4ot@skbuf> References: <20260127-ksz8463-ptp-v4-0-652e021aae86@bootlin.com> <20260127-ksz8463-ptp-v4-5-652e021aae86@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127-ksz8463-ptp-v4-5-652e021aae86@bootlin.com> On Tue, Jan 27, 2026 at 10:06:47AM +0100, Bastien Curutchet (Schneider Electric) wrote: > @@ -383,6 +384,74 @@ static const struct dsa_device_ops ksz9893_netdev_ops = { > DSA_TAG_DRIVER(ksz9893_netdev_ops); > MODULE_ALIAS_DSA_TAG_DRIVER(DSA_TAG_PROTO_KSZ9893, KSZ9893_NAME); > > +#define KSZ8463_TAIL_TAG_PRIO GENMASK(4, 3) > +#define KSZ8463_TAIL_TAG_EG_PORT_M GENMASK(2, 0) > + > +static struct sk_buff *ksz8463_xmit(struct sk_buff *skb, > + struct net_device *dev) > +{ > + u16 queue_mapping = skb_get_queue_mapping(skb); > + u8 prio = netdev_txq_to_tc(dev, queue_mapping); > + struct dsa_port *dp = dsa_user_to_port(dev); > + u8 *tag; > + > + if (skb->ip_summed == CHECKSUM_PARTIAL && skb_checksum_help(skb)) > + return NULL; > + > + tag = skb_put(skb, KSZ_INGRESS_TAG_LEN); > + > + *tag = BIT(dp->index); You're out of sync with mainline which has transitioned all BIT(dp->index) users to dsa_xmit_port_mask(skb, dev). To avoid this in the future please do not duplicate the ksz9893 xmit implementation, but call a common function and use a "bool do_tstamp" variable which is true when called from ksz9893 and false from ksz8463. > + *tag |= FIELD_PREP(KSZ8463_TAIL_TAG_PRIO, prio); > + > + return ksz_defer_xmit(dp, skb); > +}