From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C996E27510E for ; Mon, 2 Feb 2026 16:05:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770048326; cv=none; b=iYiRu0zM+XfQp2Y++r4e7yyZdbZQ3xr0qdJfUqdRIAij4oyOYACq3nTOXV1KA2N951kO8Befl3Ri5ZT2FiYqydN8haGH0bUi6nx9+tPqzONLKxw0fHaZbm3PWSTAz+p6Efa65FSIJFtgPl3diMKri8Rlww0u/8CI7qTCFE83Iio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770048326; c=relaxed/simple; bh=SRmq3Vfx7IcmSSZrIB2TSX++ZYsD8PDQLx12pxpzILo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZBh6jYWKDIpdcw8aPqIeR9PgtD44ZiozZydpQtduFRqkXbSmAMn9fR/hLNYG5IIs7lz4tKpYBj6q9iI+bEwn/H2gBbRGBmUkt8oxBIXaCicaY2x96qDQ4PGBxRJCqxXzO3dPcWTxX+ghgisDhXLKIorU3DSRnfCScZw6zeceANg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=bIVeIB7y; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="bIVeIB7y" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-8c6a50c17fdso488646285a.2 for ; Mon, 02 Feb 2026 08:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1770048324; x=1770653124; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FyiZAQSI+ZSAS8saUY3SpaGjhrrnFQnknRI9pS+CzKk=; b=bIVeIB7yRJe11+Q/0JvV0yzhsuZQ0nAkos/SoUQjbmHs7YFOJeYYqxA1V+1/L/r4q8 edcu42Wgx01Qrn43hWp5/YD5vuONSPiXfu/g6qIJR9NUjS3Pl6FhNg/Zbh665ocUJyFc PNUqH8HTlgFVedafgkNfQjfl90FIK9iUb2Kj/76TEIaKDcTH/wvlVuHqvRPWCU50t5Bp lC4IlPmZReWo8HzqrdNTTJZdNPXG7sViA+drtEjYNQFEVaCyMTd+IYfxKCIOyXpBhupP qP12WqN6NklLMO3hBPdhSgoF2lp8gjj5ILr4HnyY/OCHTkYIu09y4RxK+19T9xiiDxP/ EZSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770048324; x=1770653124; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FyiZAQSI+ZSAS8saUY3SpaGjhrrnFQnknRI9pS+CzKk=; b=E1L9OxE/mpjg0LGEAwqrjWzG8FwznmFfMFBtFOm8SnkW/2sLkN5YgiUpq0AQqXBtmx EHn75LdDUpzk861sRZOXXSxiraTBWYJmCkYC6Xd2tvjemF1g7fYkvA12/D+GbgA+5XCp BPwist0YtRrUu7yN3rmsLX938gQ7ZjC8ZFn8HGJE8dtwn7TQel1y98GXnUmtf8qbpOER KWM6fBFC9/nEcksQV589XDXswtTabjZwFZu+SL88WXwp7qibHJUjNTIrKufkJVpDgSvD umOTG0tCihLHB3IHyY0Y1+HODDIhZ+V1LwaD/cYnNYTv3wsGhoEZqaaePogCTSY+7zHK o2WQ== X-Forwarded-Encrypted: i=1; AJvYcCV9DZYpaFsS3t2ELPVWcVoEygjY3aUtLnl/JRhP8jyTmjx9r5r9IfHT71wXmmK8USwjDb9i5kr7HYy+aQo=@vger.kernel.org X-Gm-Message-State: AOJu0YwyQaCU9gfxdOmlpButIt60c0A390ALOMBDe+P2hpnr8TT1OKpf 5pnMMCHdJF93vbbSl5yDukggzndJQKTvxr67LDmC2TjuWQfzp8yOsU5avrMPaLmLQ+s= X-Gm-Gg: AZuq6aJoMZ5fY1dV02nGTtysAx4booYleV2B2GDaCdevyezsy0NLyp6JXyPyRco6b/P ow1nNIuofsmwpso1flj4+JeiB+R956i8Hx3OR4W8BrG1JF71UpNVOcrQ+/usOLmRwWj3rOcbTwQ KrU3svtjT9+C/9hSAqZtdK12lQQIFbGbqQNH6dmheWkp49vUd97ZCHIpty84f8HOKCIJW+0XUYk U4rNSwxvFKotRJ8gH43nvBORsNTFRLoDYMjbumXVz1m/HSpwOy092/sU88d/NaWW7gJ2B3AhHtB +aga/Tsi+ep8VuhkIPB+6GQlKrv02gh74GaoxtOI1UPyxr+SRxBTNuSSHvvXxXIKFtNfF0HHpRA rnEylVGBCzsHWfnoMaR07RAIAOfShR6AJwfJLmmFBQyx/JXUZ/er/5uTYwsyYaGwKu81/ME77gO UxbsYB5vNsx5Z/B+NtGqtWT3z5zp6KKiqcWh+LCOYNfHQGpFpp4rhuWN8Fd79LEFzBhEw= X-Received: by 2002:a05:620a:1987:b0:8c7:f62:228a with SMTP id af79cd13be357-8c9eb35ab2fmr1439654985a.74.1770048323668; Mon, 02 Feb 2026 08:05:23 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-894d375eb4dsm115773786d6.46.2026.02.02.08.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 08:05:23 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vmwQU-0000000FZuh-2VHe; Mon, 02 Feb 2026 12:05:22 -0400 Date: Mon, 2 Feb 2026 12:05:22 -0400 From: Jason Gunthorpe To: Yu Zhang Cc: iommu@lists.linux.dev, Joerg Roedel , Will Deacon , Robin Murphy , Kevin Tian , Samiullah Khawaja , Lu Baolu , Pasha Tatashin , linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommupt: Always add IOVA range to iotlb_gather in gather_range_pages() Message-ID: <20260202160522.GJ2328995@ziepe.ca> References: <20260202095458.882560-1-zhangyu1@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202095458.882560-1-zhangyu1@linux.microsoft.com> On Mon, Feb 02, 2026 at 05:54:58PM +0800, Yu Zhang wrote: > diff --git a/drivers/iommu/generic_pt/iommu_pt.h b/drivers/iommu/generic_pt/iommu_pt.h > index d575f3ba9d34..3e33fe64feab 100644 > --- a/drivers/iommu/generic_pt/iommu_pt.h > +++ b/drivers/iommu/generic_pt/iommu_pt.h > @@ -58,10 +58,9 @@ static void gather_range_pages(struct iommu_iotlb_gather *iotlb_gather, > * Note that the sync frees the gather's free list, so we must > * not have any pages on that list that are covered by iova/len > */ > - } else if (pt_feature(common, PT_FEAT_FLUSH_RANGE)) { > - iommu_iotlb_gather_add_range(iotlb_gather, iova, len); > } > > + iommu_iotlb_gather_add_range(iotlb_gather, iova, len); > iommu_pages_list_splice(free_list, &iotlb_gather->freelist); > } Reviewed-by: Jason Gunthorpe This should have a Cc: stable@vger.kernel.org It is a serious error. Thanks, Jason