From: Adarsh Das <adarshdas950@gmail.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Adarsh Das <adarshdas950@gmail.com>
Subject: [PATCH] media: firewire: firedtv-avc.c: Remove unused code block guarded by #if 0
Date: Mon, 2 Feb 2026 21:47:07 +0530 [thread overview]
Message-ID: <20260202161707.164006-1-adarshdas950@gmail.com> (raw)
This resolves the FIXME comments and checkpatch.pl script warning
regarding use of #if 0 for code blocks.
---
drivers/media/firewire/firedtv-avc.c | 41 ----------------------------
1 file changed, 41 deletions(-)
diff --git a/drivers/media/firewire/firedtv-avc.c b/drivers/media/firewire/firedtv-avc.c
index a36c28412170..552b77a5cd57 100644
--- a/drivers/media/firewire/firedtv-avc.c
+++ b/drivers/media/firewire/firedtv-avc.c
@@ -910,37 +910,6 @@ void avc_remote_ctrl_work(struct work_struct *work)
avc_register_remote_control(fdtv);
}
-#if 0 /* FIXME: unused */
-int avc_tuner_host2ca(struct firedtv *fdtv)
-{
- struct avc_command_frame *c = (void *)fdtv->avc_data;
- int ret;
-
- mutex_lock(&fdtv->avc_mutex);
-
- c->ctype = AVC_CTYPE_CONTROL;
- c->subunit = AVC_SUBUNIT_TYPE_TUNER | fdtv->subunit;
- c->opcode = AVC_OPCODE_VENDOR;
-
- c->operand[0] = SFE_VENDOR_DE_COMPANYID_0;
- c->operand[1] = SFE_VENDOR_DE_COMPANYID_1;
- c->operand[2] = SFE_VENDOR_DE_COMPANYID_2;
- c->operand[3] = SFE_VENDOR_OPCODE_HOST2CA;
- c->operand[4] = 0; /* slot */
- c->operand[5] = SFE_VENDOR_TAG_CA_APPLICATION_INFO; /* ca tag */
- clear_operands(c, 6, 8);
-
- fdtv->avc_data_length = 12;
- ret = avc_write(fdtv);
-
- /* FIXME: check response code? */
-
- mutex_unlock(&fdtv->avc_mutex);
-
- return ret;
-}
-#endif
-
static int get_ca_object_pos(struct avc_response_frame *r)
{
int length = 1;
@@ -953,16 +922,6 @@ static int get_ca_object_pos(struct avc_response_frame *r)
static int get_ca_object_length(struct avc_response_frame *r)
{
-#if 0 /* FIXME: unused */
- int size = 0;
- int i;
-
- if (r->operand[7] & 0x80)
- for (i = 0; i < (r->operand[7] & 0x7f); i++) {
- size <<= 8;
- size += r->operand[8 + i];
- }
-#endif
return r->operand[7];
}
--
2.52.0
reply other threads:[~2026-02-02 16:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202161707.164006-1-adarshdas950@gmail.com \
--to=adarshdas950@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mchehab@kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®