From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9786037FF5E for ; Mon, 2 Feb 2026 20:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770062671; cv=none; b=cPzDY7jdmEIBpBiChxkI4KPyhTqvhCIvB8DV2dkYTYpbMCmgp4jF7MKQwuyqV9aT7jL9XW5QXu4/J0USnANCgqDGc27gsl4549LL6kNnB34M9No6uXDw65sZQjQOzWQIx7Cn6NGcjAK0AncONOzyrkHqHKV+NOxg2T+oGNXoMlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770062671; c=relaxed/simple; bh=YwpGtXsVOooGRLfc1Rtzs1Qm+0ZUA3CssyiOSg+grvw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GZGfjlP3RXgcCE7zXc1ajl6+4vaW4kFukFD5Q8MVSa7nzUFh6nK6fzoO/1XI7+ZN49khw9JoR3AglgkKb4c/zMaCITh8OdW6I4FP4rt0TKqgAeUVK2JYrl3YlagR/5G97iKMaRcyCFHstc+b4N+0vUt/EfXMC47tb1JnZ3xznd4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lo5nHW2n; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lo5nHW2n" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4806b43beb6so35894425e9.3 for ; Mon, 02 Feb 2026 12:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770062668; x=1770667468; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Aa/bJX/vq1r2SyF6orBcmNNhb6Yq/BQBvk6y6TJ7kn0=; b=Lo5nHW2nsWjAEv0DhNZwPUYyyNNqpzdiVlpIZutDMxMQZ/XH5QkHUcbM3/WGYsH6gi utGTXrs5Lx3Quoj2tyXwEZ5K3dYzhVJv+a9EVgwIaY2wGhVJ+ZDM2Gp69/tuivIy6tQu Kq8K6Fxr5YPZFr8GQ6JGWAXkxQxE25XGhh+A4/yDIS39rjv1oHtGH4p1+Ev85qsyGREt tti6J/1BVMfBsVZ0kflMGQ6Qs5yMaqViKBpac1x4p15coVgHOgx3I+O1BX01MPAMT0zK +Nuy5LvhH67m+jYe7oWCZOV0T+69WvlUDJEv55u4Y0O/QtIuyUip8sQQN+OVP5xUiW6+ 28uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770062668; x=1770667468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Aa/bJX/vq1r2SyF6orBcmNNhb6Yq/BQBvk6y6TJ7kn0=; b=IyEStYLjZF9woqiOuI5tJfMo04KrDl52xS0XiekSJPnpzdZa46S1UibnN+dcr5wGwh dnp6cE2iDepWBwQin69vCaK9kOkpexR1x/I28JGPSwOjRmfwbRafTSWiIw3RgxVDxNW/ L0qhO8rCli+gLVhqMnt+aACylgHD2ZHZSZGD1FXpinlpvSwob2VuxKFjVT7Jd9QxP85T 7CZEr+8AilHZUeAPxeG7DUmrVqz5PjLgFoZ4orYg4ZPzF4IMEE8ITMUth1j2yPXL5XW8 WlaJVbLSk5eUIRILTqlali68cCn5CEJWI7iGHUSCvBJriCxJcRGmd9j8tzZNJ/8vayXB oNyg== X-Forwarded-Encrypted: i=1; AJvYcCVY/YJiEC3yXhh8Y6FxrPaGhwCVjwvdv/GL7WbjOghayVAn9KAE4c+gCIug8CRNjASavOBEiIW8xRRCR38=@vger.kernel.org X-Gm-Message-State: AOJu0YxwwMJVkpgbht7PiMmgmIL9yKbqygQANPJct6VL67MkSgAalF4+ McfDqxxEDZiRk96IWgeIp7w3BvMMp+JvgJuEp4aAK5Ct5vNOY8rXSajP X-Gm-Gg: AZuq6aJzEI9t+VQggsXiVFA70VfwCSZE0LBDNFkO2ZqBeTjich+jImbN0Hsd0VAs8Rm 934YUzuI39Op8CfdIsDBPPYt7iJxmIZaPBxD+gaOC4pUvwe/+ysrPXd607iLMP/vrHACdSDXFih dLQVS5RBxpsTTvR3lk/ZwfixJ56m9qfeVYWaHj3m1iyje0X2khKchExro3+Btowlzt4ff2iqoj9 R6CdXrJsJlOeJplr4YVstveYew/Z/H6iRDHitd/WEEPJavAHemhcs18uQZFf9xy9XreA92h3mtp FQjBE+J9hzIp9u/RxQ9QUSVIAusZKaA00LwMVc1yYImkRBhKkloOe0rVEyI7mzdyKf+p2FlFeLq JYooeFCsETbuzDJ4OsGcda991ug2yecfowVZdwuunjKSg608o1iGdN8gvt5UGyQ3wj9yZqSdt/Y YS7qkrfnLwxqk= X-Received: by 2002:a05:600c:a08c:b0:47a:975b:e3e6 with SMTP id 5b1f17b1804b1-482db493a7cmr155592385e9.18.1770062667742; Mon, 02 Feb 2026 12:04:27 -0800 (PST) Received: from nas.local ([2001:912:1ac0:1e00:c662:37ff:fe09:93df]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482dbd3953esm120842955e9.4.2026.02.02.12.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 12:04:27 -0800 (PST) From: Damien Dejean To: andrew@lunn.ch, krzk+dt@kernel.org, robh@kernel.org, kuba@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, davem@davemloft.net, pabeni@redhat.com, hkallweit1@gmail.com, Damien Dejean Subject: [PATCH v5 4/4] net: phy: realtek: add RTL8224 polarity support Date: Mon, 2 Feb 2026 21:04:11 +0100 Message-ID: <20260202200411.373161-4-dam.dejean@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260202200411.373161-1-dam.dejean@gmail.com> References: <20260202200411.373161-1-dam.dejean@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RTL8224 has a register to configure the polarity of every pair of each port. It provides device designers more flexbility when wiring the chip. Unfortunately, the register is left in an unknown state after a reset. Thus on devices where the bootloader don't initialize it, the driver has to do it to detect and use a link. The MDI polarity swap can be set in the device tree using the property enet-phy-lane-polarity. The u32 value is a bitfield where bit[0..3] control the polarity of pairs A..D. Signed-off-by: Damien Dejean --- drivers/net/phy/realtek/realtek_main.c | 45 +++++++++++++++++++++++++- 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/realtek/realtek_main.c b/drivers/net/phy/realtek/realtek_main.c index 85e928a0d3dc..d23672e33432 100644 --- a/drivers/net/phy/realtek/realtek_main.c +++ b/drivers/net/phy/realtek/realtek_main.c @@ -172,6 +172,7 @@ #define RTL8224_SRAM_RTCT_LEN(pair) (0x8028 + (pair) * 4) #define RTL8224_VND1_MDI_PAIR_SWAP 0xa90 +#define RTL8224_VND1_MDI_POLARITY_SWAP 0xa94 #define RTL8366RB_POWER_SAVE 0x15 #define RTL8366RB_POWER_SAVE_ON BIT(12) @@ -1861,9 +1862,51 @@ static int rtl8224_mdi_config_order(struct phy_device *phydev) return ret; } +static int rtl8224_mdi_config_polarity(struct phy_device *phydev) +{ + struct device_node *np = phydev->mdio.dev.of_node; + u8 offset = (phydev->mdio.addr & 3) * 4; + u32 polarity = 0; + int ret, val; + + ret = of_property_read_u32(np, "enet-phy-lane-polarity", &polarity); + + /* Do nothing if the property is not present */ + if (ret == -EINVAL) + return 0; + + if (ret) + return ret; + + if (polarity & ~0xf) + return -EINVAL; + + phy_lock_mdio_bus(phydev); + val = __phy_package_read_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP); + if (val < 0) { + ret = val; + goto exit; + } + + val &= ~(0xf << offset); + val |= polarity << offset; + ret = __phy_package_write_mmd(phydev, 0, MDIO_MMD_VEND1, + RTL8224_VND1_MDI_POLARITY_SWAP, val); +exit: + phy_unlock_mdio_bus(phydev); + return ret; +} + static int rtl8224_config_init(struct phy_device *phydev) { - return rtl8224_mdi_config_order(phydev); + int ret; + + ret = rtl8224_mdi_config_order(phydev); + if (ret) + return ret; + + return rtl8224_mdi_config_polarity(phydev); } static int rtl8224_probe(struct phy_device *phydev) -- 2.47.3