From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318F62E22AA for ; Mon, 2 Feb 2026 20:27:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770064028; cv=none; b=LetZyOXSZNkzWCbQslfjUU6BjItR51CojwUyecfkH1szkERXgzHHzIzF2p+A07wywzxduGDQ0P5ztDihZDsrF/f3/aJPE731kEoI3uPWKwpgJYI90T+pMFUumln3lS03A/GE9hLGQl389/eRiOVSNhbWXSNPsJwnqnf2wBkkf+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770064028; c=relaxed/simple; bh=eAi4cjqa28IGQ19pie5WPZ5SfdDCVeYj3jWAmyiQHW8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BqE1oOTO70mzwm1J1dknD+kX/SeO1TG6N55ql4YPytFRdRiDFOwQILepJdcYp6dSzZ1EyDwR1enZwOWsS4iI4Vpz24fjFhRGfOnmWzkhe7/8hMCidKnZFvNJfRE54D3M4oHbApWAMD82y7xUU7Ja1rgiMvUsxsr74p2eqI48Fo4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l5eGjxbZ; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5eGjxbZ" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81ed3e6b8e3so2570101b3a.2 for ; Mon, 02 Feb 2026 12:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770064026; x=1770668826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Mz0TDZdUzcJlhZ8RZ1PExQUtggUtglLmHcBQE1HSFT4=; b=l5eGjxbZRTkju/9TkEerxqIZ2yJoQXFfnye6okgeSx2FZYVygiTITznidI5Y9BDYtV o71eljc+X9Ez7BXZ5LQKXMCkBcffGEfk7RXMuWxUBB+hHmgGjSIW4rVb3bNYHSx4SPZa d6+/K8k1nBzk0DmctfLEzbEK5zd0xqlYcjbAp4c9sbH9aBpchJEMApCBNzcIkqblUlKZ 5SGme1vI1ih8kYikZ+GxvZCr+Jqd4Ck9E5VAN+z3Hmt+VgwhOA+qUa5+19CCdJc6vMBn Lb2ZhaLDTXX/bdFm33pj5uDdNBTV2zg0hae5bxQBNNNAG/z+PE/+DoQ6C1NCy+/+ivJ9 Oc7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770064026; x=1770668826; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mz0TDZdUzcJlhZ8RZ1PExQUtggUtglLmHcBQE1HSFT4=; b=cPCMimtaNT8TtGiHb5dGvM9HePytoGWU4mOb0I6CjmfF2ew+gq2HWPh+C0LP6cMawU gzfN0jBAsfdlSooxbH5+EFQtNLsuFawkpSP022bCmjsHq3ka1E2bTlwoU5/D2AeqgC3M /dNDBfdErEb0aQTaEdIH63AMaHjgUB5ftIexvz3RGTZQtmn933KbzhBiD916u+raXrJ6 9SWuZxorIiJq4xi+8YX6nKxNhvtHvRFzWkUZ3vGrskPILrOieLv6Kw8TL1OqF2TApyp6 4koFpjkUMj2P/zh8Bl5tfEt/xUHc0BDk1bmB/irbKbIzyE/CnJql6oWxvFJAJfAObGMv k3hQ== X-Forwarded-Encrypted: i=1; AJvYcCWHdgBxllKCV3qaLWmnl8m+tBguk2Xw3W/LkV70Mxtv7BaB0FaaxgJuuhpAl2TrV+AOK2pOxat4wdJ672s=@vger.kernel.org X-Gm-Message-State: AOJu0YyiBJxgoM9f9ms1WoZronUxs0kq2EmrLzIhKkkAEMbJHRmPjrAc hpU1BlUSOYN24mrva5naSely2SaKBNrSmr1xf0Ho4wmhQBw+dQgd5r6X X-Gm-Gg: AZuq6aKfY0vkQC/qRZi1u30mOd6rcYRmHpq5f7rFOfUa0gmc7983XG3qQvH/ukwx6UC NOX73R8RfpC2le9kJpUYuOgXdogrfYxidU9hqGGQI4JFQu45OLW+0YObNAatGa1+wlXi67nnMkE DScQFcvjCO1m+RzomYQGCLoOJZC+H7ywRu4ys/IfjQ4lGoUH3XfRPQskJocH/RoA1sG70p9Ssi/ vQZJbtE+z4ewGCieMy9G3Ch4HzuRmVkR12kSCwNcqSMvYnr6kjbHynDfeUSPq7ONL7clIMVPBIp mmkA5lAV2o5FnkRi3Ze9LxUKRODTgdVlGhnnYyJmlDOmci2+pU/kFmp3VLBO/Th3zrZE+glIz3C stuoroeXMuNEW2xsHrem3CIYL7Ag8RMhMGjdP0ub0dEtmdWRStSpTfpii66+I7CccUGvpbulMf3 PQWfBX7gRjsl3LqeJIGCLrjpbSZ8WxDvz0m+9KiM0= X-Received: by 2002:a05:6a00:94db:b0:81f:99a4:190 with SMTP id d2e1a72fcca58-823ab643c11mr11764574b3a.7.1770064026328; Mon, 02 Feb 2026 12:27:06 -0800 (PST) Received: from DESKTOP-7ISABPS.localdomain ([223.233.86.133]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379bfcab8sm15147604b3a.36.2026.02.02.12.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 12:27:05 -0800 (PST) From: Rachit Dhar To: Viresh Kumar Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Rachit Dhar Subject: [PATCH 1/3] staging: greybus: resolved checkpatch checks for fw-management.c Date: Mon, 2 Feb 2026 20:26:43 +0000 Message-ID: <20260202202643.160199-1-rchtdhr@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Resolved two checks highlighted by checkpatch.pl: - added comment to mutex declaration - fixed styling issue Signed-off-by: Rachit Dhar --- drivers/staging/greybus/fw-management.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c index 152949c23d65..cf917ddb79c4 100644 --- a/drivers/staging/greybus/fw-management.c +++ b/drivers/staging/greybus/fw-management.c @@ -28,7 +28,7 @@ struct fw_mgmt { /* Common id-map for interface and backend firmware requests */ struct ida id_map; - struct mutex mutex; + struct mutex mutex; /* protects fw_mgmt->disabled, and serializes ioctl */ struct completion completion; struct cdev cdev; struct device *class_device; @@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd, return -EFAULT; ret = fw_mgmt_load_and_validate_operation(fw_mgmt, - intf_load.load_method, intf_load.firmware_tag); + intf_load.load_method, + intf_load.firmware_tag); if (ret) return ret; -- 2.43.0