From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF6F1C84BD for ; Mon, 2 Feb 2026 21:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770068813; cv=none; b=hsVnE59zG4aE/aq1BJM2vtjn27YaEdHpxsS7KfeiZGqhY6P6CC3XQW9N3PXkFQqsV3iV6+29InW6HOq+VJPpD3tfy2oJMzn2O1010snFfxstuQ7OshE6sUBrp49hnhNGX5shnrv4XxYks36kawrlGYJDUdeSI22ieGz04NAZCTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770068813; c=relaxed/simple; bh=PvR9mbxmebsyutzDsgx45mPp0Bq/IZWz1fRx5B7Uctc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TKWxA1G/ENjnIqGEq09EASrEQlVZ1dtH5K1bMJ/BAUlMlIPUx2GIUYKw69iib6vZSpdZ3yJfT6Hl9JxUc+xms0rYYrF5WKOmLyOy74LAeT+Q+n8DGGBl04NORreL2WwVRnDvEyxUo5Mj/Ct/bD7v9pdKxsFsXrd7WS1QyrTC0cU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ok4fXGkm; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ok4fXGkm" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c634c20be90so1957762a12.1 for ; Mon, 02 Feb 2026 13:46:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770068812; x=1770673612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3DPWS7e1LxZgNO8RMl5aIfS7AvZ3NEcgmapRLKdI8d0=; b=Ok4fXGkmAY9rQ9Iip1cXvzcrqmHwxCIYDUH0K23Oi1UaF+Xy9bOBDFtoCS6D6qIcZf B8ps1tv9Mq6hq0IYR+hjAMnubtVcmJEGGaZdbh+/X/j0UQEvLcC2HMN3Xb1Kx/+PIxa/ JoATphuMbr/b1x8bMUbTzuFTfr9FyQAj2XyrbBaLxHsmuOOd0FFBli4sQe0cmx9gSF8d rQ4e9q+sRYuxoJuHR/Ch8EMviuDCtFQQSUz9o+cSwqhl12oh8ow+TruZjoQ9chIYOdXi nKtjKAmDw5xkvJ/kaP4jYlpmM5ftbvXT0F/6IhPRwrXYbmEiqXDx5IX3FK/RA75eu3BP DRxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770068812; x=1770673612; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3DPWS7e1LxZgNO8RMl5aIfS7AvZ3NEcgmapRLKdI8d0=; b=lxuTBmKk8LZgqiQmQkXb+7xbzZn4PfbkCO/pL0of+aNL8uJ9/sBRktKLQ8ZVPdSnOG zi5TJIkfWTqnsXB+ymJ5M9C6u290Rznfnge+pyIXmA0iuuAVeb0TL28ocCllJqGx70mY 62I12ega3pSvjBg+Gzy8vkYOdotd0ao2FynU4GuNnLQPqA5i36ph/VQ+XbkupCXkj2eM K0POR2LAue9XS/Q78i6nXg0mpy8L+OmiQnilmfD6k1VJIXdPD0+v3u9bl5YKae/JCS0s VCzrJ24Jyj/W5pOzwKZ0c/wGQEYhwEPx7wzxk9uzQAzi3uytI2PpxI4qbwEKgE5HN+B1 Ar9g== X-Forwarded-Encrypted: i=1; AJvYcCUzpLJ5A7+A6Em1U+hOHnbjpJH8hj9/qieNSLifiwi9m1k4RbN1hVm+5lrzI7GcVXTHL07/U43VM8Djg5s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywyc9BVanXnytNLHcjpW00jGxV5fsV4MAwt6WXcPRn5bVeTnJnd 3iY0AL9+RentbNiQDHS0Ob+K0Gqib9BqGBStWph+W384VG3WBzqpgYDm X-Gm-Gg: AZuq6aJ87cDMYX9xqDX09wHQmtTbbpDl9nV8J5ifZkPXlToCIyCeTBjJk9b/OPUmcYg LE6JIoMbMjimE60CknafqGm2qwJJQToHClrf4AWlY9xWvTE/uwRGm4WxYXvA4I9Oahl+unSkGud NSTcGrAW1UJ6fiLX4OtOvclzzdB2IxoXip1gYJd2r4giAlPGZGF98o3JIQ1pXhIEOHvgNK84eiM JBtnsiTpFL6uT+EdMMLYoqjPhhxidMfLdQ8GJcnwcM0nQqY0y1I/V7bj+8dal+wouwtZU4tEgKl JdUuAkXzIj/G/UoNWs0oVwfM6tiyNca37NCnipWXzsRi+X7KE7UifKH8V8Kh+8HX4uIvaJYTpRq 8YYIK5mFTspCdpek2oBjHr+pKzO5b3izRjEE634g7gpOFq4dk/vmL6JioSw== X-Received: by 2002:a17:90b:2244:b0:32e:749d:fcb7 with SMTP id 98e67ed59e1d1-3543b33884cmr11754715a91.13.1770068811512; Mon, 02 Feb 2026 13:46:51 -0800 (PST) Received: from ryzen ([2601:644:8000:8e26::ea0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3547767cf29sm391215a91.10.2026.02.02.13.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 13:46:51 -0800 (PST) From: Rosen Penev To: netdev@vger.kernel.org Cc: Chris Snook , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King (maintainer:SFF/SFP/SFP+ MODULE SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev" Date: Mon, 2 Feb 2026 13:46:32 -0800 Message-ID: <20260202214634.72738-1-rosenp@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This reverts commit cc20a4791641a1cbd1525695fac0d4725dd72509. register_netdev gets called after phylink_create which has no devm equivalent. phylink_destroy must be called after unregister_netdev and not before. Signed-off-by: Rosen Penev --- drivers/net/ethernet/atheros/ag71xx.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index cbc730c7cff2..f2f12642529e 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -1926,7 +1926,7 @@ static int ag71xx_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, err, "failed to setup phylink"); - err = devm_register_netdev(&pdev->dev, ndev); + err = register_netdev(ndev); if (err) { netif_err(ag, probe, ndev, "unable to register net device\n"); return err; @@ -1939,6 +1939,17 @@ static int ag71xx_probe(struct platform_device *pdev) return 0; } +static void ag71xx_remove(struct platform_device *pdev) +{ + struct net_device *ndev = platform_get_drvdata(pdev); + + if (!ndev) + return; + + unregister_netdev(ndev); + platform_set_drvdata(pdev, NULL); +} + static const u32 ar71xx_fifo_ar7100[] = { 0x0fff0000, 0x00001fff, 0x00780fff, }; @@ -2024,6 +2035,7 @@ MODULE_DEVICE_TABLE(of, ag71xx_match); static struct platform_driver ag71xx_driver = { .probe = ag71xx_probe, + .remove_new = ag71xx_remove, .driver = { .name = "ag71xx", .of_match_table = ag71xx_match, -- 2.52.0