From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 211FA314D16 for ; Tue, 3 Feb 2026 11:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770118993; cv=none; b=gU2N8QQcr1rVnBtUhrfvGFvPjv5cHfIz/TnmyR6eybgTi09SPpUGsbVHG4/qdoWHgVk+OYK1+dLA3h6MesQnVhN7UtW5q6brzcW8fTc0+zkY3YvI2LzSZER91QxwY/Gn5cbxrvZBHCqoWVzqk2fkeKqMWj74MQMXp+/VDhrFUB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770118993; c=relaxed/simple; bh=5+Eg/GSUM5PlilOUyyBYJl0Z9wyueL6j7TVADyqgoWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cVwWH+ef6qp02zk1lgzGQEbRbsMwxrfb3cEeBLHzC04vbp6tIgINDPinM9WRsrz3cw89TlwvUBAUriu9BvHgLBHJ0HssQUStz15nptKWZnnAfWp04To9xN+GtqIDpKWyDvBnVe3lVmCO1+WMBOymbWuWxnTP2cNNdR7FGfHdPSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WMcPhQ/J; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WMcPhQ/J" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-649278a69c5so5988355d50.3 for ; Tue, 03 Feb 2026 03:43:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770118991; x=1770723791; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/hGI5B0B/7uJqpu0kk2emLXKb3dGWeAAqf071Km/wBI=; b=WMcPhQ/JjVImCpOyHOLFzb/mEbiuf1BeHIKIuIqQ+VyADQI2Z6wWT/xiAL36OPB5mZ s6pDl5JuM5mQ3AjDfZnmvFI4GsjZIfk+5YS6MhFLSMLjyy3z/FRzkGsaV2GsQVfycjNo pZ7FK4zhR127nwCyfrQJvUJNU1sI0GxCoFXiPdwxXe1dUsbrYqIHT+wAJIAtoDpifOB0 jLsbSNYYO/6zRZ2MVzPe7fvENltET9i7nGyw65ZPQUs0fCU2erwTCud9RdQBZvLCZ9v2 QSzrKLoULozPkROsuIccCDfapjkQvYO4J96dHK6OT5ZaZygSAgvZNtSVGN2zlWIUt96W 7WZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770118991; x=1770723791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/hGI5B0B/7uJqpu0kk2emLXKb3dGWeAAqf071Km/wBI=; b=e9QsU7a1inLthUTWUvt8nub15snfmpvNawsXmWiYUPzp/IEsuvDtw6dFaUio9qv86a pMYnJ41gyKJqeX5PBgDAWcikQZcwmOOOjlcw0v/TypRGBIrTbLFtS2s32Jt2YsB+GgLc 7b4mF7vinRQ1GCa2jfBY0DXhcUcj+LEHtdIl5GO/ka4mcrmVMyKHtUAgUKh38WUVVhoN MQ/b+8HblwTYF4kSi4stAVICDTsEmtX86DX+Xt9nVNYd7YztD46Y5TOzgGEVTdeOdby1 CKtFgOok0P5ljbHQNq0gF5cnkOyhsh8tBAaUZM2Lcega8q9nHBuPjc6EKIjgD8wS9HLp 7hsw== X-Forwarded-Encrypted: i=1; AJvYcCU4OMRjLx9a+3Modi9k2RaibaDjYldRmbI6BHfZRtTpH+Z1tAtj/6DD6B/kXLbNhFW/nQ0WVV+qRb2BSNw=@vger.kernel.org X-Gm-Message-State: AOJu0YwJmxyJCPBCvrzra6vTCofm2GOGz2jskoppZsGLHS4nEB+cXHLw b7r/2RL+7c6XpYnhro8gystGXNUwZ/GSk0ZFkO2K+vJAcN0kyAbD1ueD X-Gm-Gg: AZuq6aLuNlXazgqhyyQQQ7HlJtOWQS75lCPIFVV9VLIrT8EA+3uvbL5+PGHU6pTDost ezv0Jfylx6Uq6FVReC2mvG88gtiXrnOFYZtKIUa/GqlWEDHjVJ1r2Dg8hmbw/QETxpHQwhmdPdd 4o87kU0QwJniR74gky5MyDlIXA8mHWchofVP1HUXVs8QOvbiQfukSG1/4FheyjXY937/k/t/e0B bAJQ9dHtORGx5Gu3yqIzGunfqel5EkfRs16BB28SwCHdKxLYfzT4HaztiBQpEPfys0UE0vfaHw+ U9Iw6ssYV1HmjxAS3v5HhE2Zxg80tc2kIw8ZYG8Jrsb92DVUA7M97faJTLySLNJKwzck0JeSMet Z+HonPj1YYnMNE4h5xUDELj8d0qab7Lw8ynBxaQVU+ubXE8ZSEpMpnM9zfb4jWQgIAdkiOU/uFR eKkkiCM65TSA== X-Received: by 2002:a05:690e:168f:b0:646:6f6f:65e with SMTP id 956f58d0204a3-649a83cc03dmr11957134d50.24.1770118990906; Tue, 03 Feb 2026 03:43:10 -0800 (PST) Received: from fedora ([187.120.156.78]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-649960efc6esm11690333d50.17.2026.02.03.03.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 03:43:10 -0800 (PST) From: Guilherme Giacomo Simoes To: agruenba@redhat.com Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, trintaeoitogc@gmail.com Subject: Re: [RESEND PATCH] gfs2: do not evict glocks with populated address spaces Date: Tue, 3 Feb 2026 08:42:57 -0300 Message-ID: <20260203114257.25469-1-trintaeoitogc@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Andreas Gruenbacher wrote: > > Metadata glocks may have associated address spaces used as caches. Avoid > > reclaiming such glocks under memory pressure while their mappings are > > still populated or their state is not unlocked, as this can lead to > > invalid page cache state and GLOCK_BUG_ON(). > > What invalid page cache state and GLOCK_BUG_ON() errors is this about, exactly? On __gfs2_glock_put() (fs/gfs2/glock.c) the GLOCK_BUG_ON() is triggered under memory pressure while the glock is still locked or the glock is populated with metadata caches. This happens because the __gfs2_glock_put() can't truncate pages with a private datas (truncate_inode_pages_final(mapping) is failed), how the metadata is a private folio, the GLOCK_BUG_ON(gl, !mapping_empty(mapping)) is trigged. > This leaks a glock reference, so it's definitely wrong. But this glock is a private folio with metadata or is still locked. I think this can't be evictable