From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF01633D4FA for ; Tue, 3 Feb 2026 13:26:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770125185; cv=none; b=C6npLIalIW+n/7GyQXihlAlNLglynK8f9SwcRMBN909BEHxNnyJcejbQyuAwLclItGGJ2Gs3B+hEZRkdeykenO5VlEThtzmEYevD8HZ9CLyiJPZo1V/R/7utIBwIXBdnuG/AmAkgn8Cy7WMGXckB+Bm32VSneos1eB4TBprCBs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770125185; c=relaxed/simple; bh=Vn2Uk5F1/E+CiOQ8d9dF1tPzy9UJ2lNUW+JLtH2aIYc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LUyDv5iOsZ/V/naChMkSW/cC0ukGDPjaKuIXk9IPrsGO2RpDIWX77UM0tY5tsHr9MeDk1aRBV8s4VOmKNK43HyUJIrZ3r9tVOj6z7kDmRFXl906liFTOl3/w/cAowowCfM22OwImLakuoyO9yluNT01PeaWO1Bn06Xv37m12crw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GZ3BCnQA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GZ3BCnQA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770125182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/TNXB9FNbKBPPn3x837yvbtZigT2XClFPd54HukoE3I=; b=GZ3BCnQAlctOKS+jL3LnYOauYRfckPvH7bArRaYTekYQQILwpRJt+k6izQOPSnSTeApGiP k+daf3f9/P9gaExvU3+vig8EwiLz0wVG0+8Dvkg6YvoQb8WcVsyhF2IJCs5CQuyoq1eGbk GTRQnnBeZG4VsuQpsGPIehsYe+0jXIo= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-281-d6fojSeJN7-5qMuXvy33Uw-1; Tue, 03 Feb 2026 08:26:19 -0500 X-MC-Unique: d6fojSeJN7-5qMuXvy33Uw-1 X-Mimecast-MFC-AGG-ID: d6fojSeJN7-5qMuXvy33Uw_1770125179 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77FD11800365; Tue, 3 Feb 2026 13:26:18 +0000 (UTC) Received: from pauld.westford.csb (unknown [10.22.64.147]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0DD421800665; Tue, 3 Feb 2026 13:26:16 +0000 (UTC) Date: Tue, 3 Feb 2026 08:26:13 -0500 From: Phil Auld To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, gmonaco@redhat.com, Juri Lelli , Ingo Molnar Subject: Re: [PATCH] sched: Fix tracepoint called from set_tsk_need_resched() more Message-ID: <20260203132613.GA438882@pauld.westford.csb> References: <20260129160527.238267-1-pauld@redhat.com> <13b845f01515419a321864cea2038fec23526414.camel@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <13b845f01515419a321864cea2038fec23526414.camel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Hi Peter, On Thu, Jan 29, 2026 at 05:09:25PM +0100 gmonaco@redhat.com wrote: > On Thu, 2026-01-29 at 11:05 -0500, Phil Auld wrote: > > This raw tracepoint is added to set_tsk_need_resched() which > > introduces > > two symbols which were then exported GPL-only. While generally better > > to add new symbols GPL-only, set_tsk_need_resched() is called from > > places > > that are exported without that restriction. This includes things like > > wake_up_process(). Export these new symbols without the added > > restriction. > > > > Fixes: 8d737320166b ("sched: Fix build for modules using > > set_tsk_need_resched()") > > Fixes: 6c125b85f3c8 ("sched: Export hidden tracepoints to modules") > > Fixes: adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task > > model") > > Looks good to me, thanks! > > Reviewed-by: Gabriele Monaco Thoughts on this one? Thanks, Phil > > > > > Signed-off-by: Phil Auld > > --- > > > > This is against tip:sched/core (377521af0341). > > > > > > > >  kernel/sched/core.c | 6 ++++-- > >  1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index c5431afe23b0..2871369c05fa 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -121,7 +121,8 @@ > > EXPORT_TRACEPOINT_SYMBOL_GPL(sched_update_nr_running_tp); > >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_compute_energy_tp); > >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_entry_tp); > >  EXPORT_TRACEPOINT_SYMBOL_GPL(sched_exit_tp); > > -EXPORT_TRACEPOINT_SYMBOL_GPL(sched_set_need_resched_tp); > > +/* This needs non-GPL-only. It's called from other non-GPL-only > > exports (e.g. wake_up_process()) */ > > +EXPORT_TRACEPOINT_SYMBOL(sched_set_need_resched_tp); > >   > >  DEFINE_PER_CPU_SHARED_ALIGNED(struct rq, runqueues); > >  DEFINE_PER_CPU(struct rnd_state, sched_rnd_state); > > @@ -1139,7 +1140,8 @@ void __trace_set_need_resched(struct > > task_struct *curr, int tif) > >  { > >   trace_sched_set_need_resched_tp(curr, smp_processor_id(), > > tif); > >  } > > -EXPORT_SYMBOL_GPL(__trace_set_need_resched); > > +/* This needs non-GPL-only. It's called from other non-GPL-only > > exports (e.g. wake_up_process()) */ > > +EXPORT_SYMBOL(__trace_set_need_resched); > >   > >  void resched_curr(struct rq *rq) > >  { > --