mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tomasz Pakuła" <tomasz.pakula.oficjalny@gmail.com>
To: alexander.deucher@amd.com, harry.wentland@amd.com, sunpeng.li@amd.com
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	siqueira@igalia.com, dri-devel@lists.freedesktop.org,
	amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	tomasz.pakula.oficjalny@gmail.com, bernhard.berger@gmail.com,
	michel.daenzer@mailbox.org, daniel@fooishbar.org,
	admin@ptr1337.dev
Subject: [PATCH v3 01/19] drm/amd/display: Return if DisplayID not found in parse_amd_vsdb()
Date: Tue,  3 Feb 2026 19:56:08 +0100	[thread overview]
Message-ID: <20260203185626.55428-2-tomasz.pakula.oficjalny@gmail.com> (raw)
In-Reply-To: <20260203185626.55428-1-tomasz.pakula.oficjalny@gmail.com>

[Why]
The function would continue to try to parse EDID even if DisplayID
extension block wasn't found. Sometimes it got lucky and found AMD vsdb
in CEA extension block which made debugging harder.

[How]
Add a return if DisplayID extension block wasn't found

Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index d8fac7e69181..29e4a047b455 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -13136,6 +13136,9 @@ static int parse_amd_vsdb(struct amdgpu_dm_connector *aconnector,
 			break;
 	}
 
+	if (i == edid->extensions)
+		return false;
+
 	while (j < EDID_LENGTH - sizeof(struct amd_vsdb_block)) {
 		struct amd_vsdb_block *amd_vsdb = (struct amd_vsdb_block *)&edid_ext[j];
 		unsigned int ieeeId = (amd_vsdb->ieee_id[2] << 16) | (amd_vsdb->ieee_id[1] << 8) | (amd_vsdb->ieee_id[0]);
-- 
2.52.0


  reply	other threads:[~2026-02-03 18:56 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 18:56 [PATCH v3 00/19] drm/amd: VRR fixes, HDMI Gaming Features Tomasz Pakuła
2026-02-03 18:56 ` Tomasz Pakuła [this message]
2026-02-03 18:56 ` [PATCH v3 02/19] drm/amd/display: Refactor amdgpu_dm_update_freesync_caps() Tomasz Pakuła
2026-02-06 18:22   ` Harry Wentland
2026-02-06 20:46     ` Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 03/19] drm/amd/display: Check for VRR range in CEA AMD vsdb Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 04/19] drm/amd/display: Use bigger VRR range if found in " Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 05/19] drm/amd/display: Refactor PCON VRR compatibility check Tomasz Pakuła
2026-02-06 18:39   ` Harry Wentland
2026-02-03 18:56 ` [PATCH v3 06/19] drm/amd/display: Add PCON VRR ID check override Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 07/19] drm/amd/display: Add CH7218 PCON ID Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 08/19] drm/edid: Parse more info from HDMI Forum vsdb Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 09/19] drm/amd/display: Rename PCON adaptive sync types Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 10/19] drm/amd/display: Enable HDMI VRR over PCON Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 11/19] drm/amd/display: Support HDMI VRRmax=0 Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 12/19] drm/amd/display: Build HDMI vsif in correct slot Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 13/19] drm/amd/display: Save HDMI gaming info to edid caps Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 14/19] drm/amd/display: Restore ALLM support in HDMI vsif Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 15/19] drm/amd/display: Trigger ALLM if it's available Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 16/19] drm/amd/display: Add parameter to control ALLM behavior Tomasz Pakuła
2026-02-06 18:52   ` Harry Wentland
2026-02-06 20:52     ` Tomasz Pakuła
2026-02-06 22:04       ` Alex Deucher
2026-02-10 18:44         ` Tomasz Pakuła
2026-02-10 19:17           ` Alex Deucher
2026-02-10 20:54             ` Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 17/19] drm/amd/display: Reintroduce VTEM info frame Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 18/19] drm/amd/display: Enable HDMI VRR Tomasz Pakuła
2026-02-03 18:56 ` [PATCH v3 19/19] drm/amd/display: Add HDMI VRR desktop mode Tomasz Pakuła
2026-02-06 18:58   ` Harry Wentland
2026-02-06 21:08     ` Tomasz Pakuła
2026-02-06 22:06   ` Alex Deucher
2026-02-06 19:00 ` [PATCH v3 00/19] drm/amd: VRR fixes, HDMI Gaming Features Harry Wentland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203185626.55428-2-tomasz.pakula.oficjalny@gmail.com \
    --to=tomasz.pakula.oficjalny@gmail.com \
    --cc=admin@ptr1337.dev \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bernhard.berger@gmail.com \
    --cc=daniel@fooishbar.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michel.daenzer@mailbox.org \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=siqueira@igalia.com \
    --cc=sunpeng.li@amd.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®