From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E0A19460 for ; Wed, 4 Feb 2026 10:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770201163; cv=none; b=s+xhThLVsxL/659IzgEX3LATseYiyiHDkfFQ4rOqnN+snTgExlAmE+KUmC+06gCN7wjsOAdDJbhGm8BeSHXgsW1i35h/LIjWabuK7//rF3unCwpwcpen4P+qTp5dAXCm9Y8bG78sEUbibVGWuFopXWrmt9BrT3nAmPkd0Hp+ap8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770201163; c=relaxed/simple; bh=b2cRwyuXxJOInW7Wf1Nmi/IKrpY1TVgZuFPHiHNaWoI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c95r3e3m0e+QpDDShIrnLha7hYyZ08Jq8UMPw4Dx9f0eVXaCbcYBGEakiUN/OaDfka79QAvjbpRwpubebjAf7ObQRn/zbXDp3pQ8E39Qj2SgN9rQLV9uZRa0pTFweRHHH+oh6FLcPFEWn/lX8cGe6UWVT6Dpbi+gb7cImMB1H54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GmO3xC2K; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GmO3xC2K" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4806b43beb6so48019325e9.3 for ; Wed, 04 Feb 2026 02:32:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770201161; x=1770805961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MRBjj22CT+sIy28hxhJS7D7A0Tb1EUHDE7RRcCvtOJ0=; b=GmO3xC2K2G5ofoKpjfWrKZfjbg65nqk813K5kj4QYQsFc9/hfDdA6Hh6f8FPX42N6b E341wSMb+8qW4TRlQkLASMa6+FLFyEIuEXITlRk7WE+kUrXrKlEmpNeCbCsRDnkfbmDP 57ctyAuEAnZQELC6gV36SnbG56hAPv8azC7FcLx73jrp0x0uWlojmz7Duus1WAHVOLUB tzzrk8aJeoAj3z+1kSWa26NOy/3vFos/nFw91c27lKLk8jQrlAcmtc5nwgDAnmCotILF zYMSjbnXHHqynQvCV8Mc50AADAcUX2RYyz+IVXXcUmuVqHwhGhWzcaCrnNGX3i+fq89P P6qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770201161; x=1770805961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MRBjj22CT+sIy28hxhJS7D7A0Tb1EUHDE7RRcCvtOJ0=; b=raU/FvhL+D8Kjn8O+1KWasL7JGfTw2FVyEqyRFYwXp3JT/zYhKkd5JVtsc2qYye+zx FDkNvqfoeYTL/UkjqYblAE5W/MlDu28IS/Oddi+maOdoWnn026dnmTLcn0dmnL5QVTfv 6qHSI1BP1RCuw/e/YMRt0xQz+DfWjYm0GCDwwMDJYSGTTqV6Pn6J6F/M1/7rg6TrZoOf ZH1bxXO2Un5dKX/vpcHKZqBPnQRJHNrmj5TnerxOkRQQl56mrq4Z9BaT5OR1J8oTk1ao 8bOJeJovF59lwD3myI9b4i5okPmOYYvmge1cDFj81LkthzoJwdwxdxL9yQHcrSfhl72j Fu2Q== X-Forwarded-Encrypted: i=1; AJvYcCW663dK1kFnyvz4VswwNhWc1PYL2e81S1MuToXXPAQDDAfJrczXKWEqmQS1oFWbooLJ2dQmecLXKlKDZt0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/08DXhTL8bD9NSFJHrPFuiYP5NI8fgktD9n0pdlmAMZUF1RbM x3Z8SB/VTAsHgZsqjGbBmlziBgPQS5FJnF8I1t3Y0ouwHdX7kktHiJss X-Gm-Gg: AZuq6aK6AtahbMwJYGtH6AY5afct13iF5rF6yUClaBtmryvJz9Tp/7OEWV12PPyZcWX GE7bBSeUiesGiiERF13wviF8n5f9mMSbbFB4a01p75cTjvxixNwpf6ckmYIDE1Uk7pp+/t6Suki y4+U0FStWEseB5KIaIbt5Jr7Q2WRAtTGY6VTZrBycAUc9megGZvb9rX8baJTPuXKuQ+HDh+gwEb hQ1h6fnSTP/X3PJOpWpc5QRapE8yZyvXpcVccMajkOm3Cp5vM/rTZyx6n53cvGtKjPy9qu8lHgW JojVQK381/tprldvwzj1Xg4QkqL33FpaXftx4NUQU7Cs47nZuz0BO++OB2TjTKztzvKHsUCgTmG uv5BRPwWlU6FOb0tLLIrr+W+KGQatPrQxZwKRV45IjiLVPKkNXKlVTo7wADNCa1gWwOyKTkDfpZ DhuhLagyox+lDOKTbS5geOx3YXlrX8Mo8cEJViJ4zGlxgyuBF/OmTR X-Received: by 2002:a05:600c:4e05:b0:477:af07:dd21 with SMTP id 5b1f17b1804b1-4830e977f95mr35524735e9.25.1770201161433; Wed, 04 Feb 2026 02:32:41 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4831091a0e9sm61722105e9.10.2026.02.04.02.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 02:32:41 -0800 (PST) Date: Wed, 4 Feb 2026 10:32:39 +0000 From: David Laight To: Jonathan Cameron Cc: Michael Harris , Lars-Peter Clausen , Michael Hennerich , Greg Kroah-Hartman , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: iio: adt7316: convert magic numbers to BIT() and GENMASK() Message-ID: <20260204103239.332b66af@pumpkin> In-Reply-To: <20260131162140.5abb833b@jic23-huawei> References: <20260130-adt7316-correct-macros-v1-0-8a71df1e42f1@gmail.com> <20260130-adt7316-correct-macros-v1-2-8a71df1e42f1@gmail.com> <20260131162140.5abb833b@jic23-huawei> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 31 Jan 2026 16:21:40 +0000 Jonathan Cameron wrote: > On Fri, 30 Jan 2026 23:38:28 -0800 > Michael Harris wrote: .. > > - return sysfs_emit(buf, "0x%x\n", > > + return sysfs_emit(buf, "0x%lx\n", > > chip->dac_config & ADT7316_DA_2VREF_CH_MASK); > Is the compiler complaining about these? It really should be able to tell that the masks > are small enough that the original can always print the right thing. That will be because BIT() and GENMASK() generate 'unsigned long' values. Sort of silly when they are used for hardware registers that are fixed width. You can use BIT_U32() and GENMASK_U32() instead - they will be 'unsigned int'. David