From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2BBB395DB1 for ; Wed, 4 Feb 2026 22:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770245083; cv=none; b=RNT3Z8DTs+mGK8z1pSxNDWF0jIJ6oI2H9iz4CormAkXPJJ5sQLVanv298Myhh3RIizTZHcNnEoYAw6vs7V7U935d293JI9HWFv9Y+WyG4sSePzvn0WnjO171r7gZvVTf16dY1YMZ1maRXf1hZLWTFwR8iHi2OfBT09cDyz/5jEQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770245083; c=relaxed/simple; bh=wyDXzEiDI09qoOjixuC3rPHKoCE6XE1QSc7CX3XUerQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=BOxw2Bhz6hspNc4cpJECtTPhzjOtNo3kPLqiCrbJK9B2euICC2vEvHlbGPuDKTKZrm+bhpTrtJpqWY/c51Q/nFiKQNWlYvr4qaKoPU7E+b7kT0JUXZm1X3bGfXrBMIVn+Zie4oTxXzyTVSmYartMBNiV5zCbbY7aiHnD088Bz0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Rh93rqzA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Rh93rqzA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9FA8C4CEF7; Wed, 4 Feb 2026 22:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1770245083; bh=wyDXzEiDI09qoOjixuC3rPHKoCE6XE1QSc7CX3XUerQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rh93rqzAkFeBAsQzplmY9WaqsNcmP6W1cbXQ/xnBK1+PJFtrUoc7rwdpWYmLXq6fW WB140oJV6TKBVyn3Py9cljiJjWBbWFt7A5b6CjjZOVs/+XIH+OCBnvZ445ok2Edu7D 5R9zmSuLbcq4iX9J+Nb9RCpNuvUT6ozhoo+tayP4= Date: Wed, 4 Feb 2026 14:44:42 -0800 From: Andrew Morton To: "David Hildenbrand (arm)" Cc: Jiaqi Yan , jane.chu@oracle.com, muchun.song@linux.dev, osalvador@suse.de, william.roche@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages() return type Message-Id: <20260204144442.4eb44f4bb933daed44d5db96@linux-foundation.org> In-Reply-To: <17af6fe6-9318-4e9c-ba54-0b6b16ea9c0c@kernel.org> References: <20260204214741.3161520-1-jiaqiyan@google.com> <17af6fe6-9318-4e9c-ba54-0b6b16ea9c0c@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 4 Feb 2026 22:54:48 +0100 "David Hildenbrand (arm)" wrote: > > Changelog > > ========= > > > > v2 -> v1 [2] > > > > - Use two-tab alignment for parameters wrapped to new lines. > > > > - Remove return type in remove_inode_hugepages()'s comment. > > > > [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com > > [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@google.com > > > > Suggested-by: Jane Chu > > Reviewed-by: Jane Chu > > Reviewed-by: Muchun Song > > Acked-by: David Hildenbrand (arm) > > Signed-off-by: Jiaqi Yan > > --- > > For the future, the changelog always belongs down here, under the ---, like > > Signed-off-by: Jiaqi Yan > --- > > Changelog > ... > > fs/hugetlbfs/inode.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > I think I always add another "---" above the file list, not sure if that > is required. Interpretations might vary but the "^---$" inventor sayeth that everything below the "^---$" is not part of the changelog and is to be removed. Also, my preference is that the permanent upstreamable changelog not contain short-term development-time information, as that's uninteresting to someone who is looking at the commit three years from now. Material such as "how this patch differes from the previous version" and "how I tested it" is interesting and useful, but below the "^---$", please. Beware that git interprets the separator more loosely: "^-----------" will match. So using a row of "-" characters to underline a heading is a pitfall.