From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1355984A35 for ; Thu, 5 Feb 2026 06:31:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770273112; cv=none; b=ag6U48D1r8zkUDJWOskobfgOQL2vxRNmx4fXFx9DLSaXgLyEaTNKfUMcyNkGMMSOLp7Y6bxER0HGeC68Zn05SqegpuyCXm3m4Q+nYVi9RkjeISLjUlzXMxCcgnmn3wjCRnRP/KblJHm7Y5AA521w9RONFGiU/5GVZCRmvDiZFJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770273112; c=relaxed/simple; bh=D2FZGnks1mhd70ETt05smEqAwMkcsbqYZmg9z0sMIEs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hbTbmKMfFPRDEoii+NeanBaPXTcLqliq/grMTYeXWRIODaiY5rp+SmZCt4FVXbYvgdWwp1OFWRviOshrQF5FPkh8GrhJC9LWpyDfVnEQBm2YUFurtRrJVrkXOUhLGn4HTkgK4xyrgaY1nH7V8sNmiz9MZLOXTN9qRkw6Utksnpg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Be2wYuYe; arc=none smtp.client-ip=209.85.216.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Be2wYuYe" Received: by mail-pj1-f67.google.com with SMTP id 98e67ed59e1d1-34c718c5481so311210a91.3 for ; Wed, 04 Feb 2026 22:31:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770273111; x=1770877911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6IzNoHDjJv8QcXTrk47DlqDi/FcMS1AAEpRJRBBFpgU=; b=Be2wYuYeqqY8OEORTf6wS3eLtd1o/ss27lTkBjIHkY0AZAs9xmd3fpV+0vA3E76VwX 5oBdMK8H3YwKUJj3tfnVOx95+3IlTOq3pZ8gATY0N2pKF9am0L8+0PclrRfrSZ9JIZn4 PIrBA8ohKqPGp1qIufonTXjcoImjUZKxix8txKSiDbZw3q2zL1SmS1ETTkFiYndPMvlJ SG249gOBlW7D/ff/vlgqeWU1GcWcyLyc8pXE/gHpnQ7Pp2T4kpFtkBEWvFVxo31Mgzvw bhJ4zuKizDKZMwgZCOJ5WkiSqrgTUkcxFyjCvFlKfiOFwYYXwcaOFeeopfTQx/hS91wy FbVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770273111; x=1770877911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6IzNoHDjJv8QcXTrk47DlqDi/FcMS1AAEpRJRBBFpgU=; b=gU6AF80z2dLJSDg5/Owi3H307KUgGb4yZiEbWh/rO1Zp8ve8FWxVYeNLuvmqP5kwgL /ZK7LTzicTN5kTSjv4mhgU3pZJQqS/xjVF1K4iFWmwWgCIVaWgpTp5HZd3A65PDf7HBb 4nfGT6xiX5GSo1ll7m7tsgcnVH+wbx13Pr0zevOubB+zdXcvTCh/YAvp9oPynauHZMXI 3vG99lXBDfjIbO7QRJ2vd9ymcHlaEO1E0ps6Ega+wFDLzf6hrUeLQpqZP44jVJxhe2ne BlrcCqh4WcZBGE8keCL3zyZYs9SwTs58D5tpRXp/bHJRsiXFbgZKt4yawE0HHziGNv6U BAXQ== X-Forwarded-Encrypted: i=1; AJvYcCUrbwE7P5GgckykefZUbjFja85ibqRg/kio4eWm6wX7ziMFcEz8xG3Iu4vXUM3sYgDtdjkt7N1j126ztlY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5IaplK1tKwZSOPcUBR6gZz+0Mr9cGOpgd6X7aa0rJw5fpI7Hj GVXg0yjYMzI0wLXkYXJLhU3VsWAPRUdd8jr1iDWXxeuo3u3GsmD+u8VQ X-Gm-Gg: AZuq6aItzfiqADYPE4BOuj2IFFCQMFif8jmgcGF2Sr447NSEY+IrJqcHfqhsjc0wbtJ bY57OGeMwIh8KYK6Hcd87c6yJEN2Cb5vEQulWjYfbNxtbrbBplTyUOYRyhJn/coh9tXfcqdwUMo qOtmCuuvtStZwnC1OPRWhls9rcqHJiC5GxuIsSs8Gij24WKQG2RzEZnar+vwPrqtMIlCjXV+WwL VrLDazFPeOYMoDuYBJIpo1H3K9qY06bw+CiEy1A09ZSFWX/TvwmWqVw0T65I/6fZGvHPyWXufv3 O+LXYqoOHGiEOW8eitK2eWU8TSCugXzGDjFm7IJqFuLBbWfBCDkgp5Xg+JrNvEv8NtInXFjA9Ni JWnFPBv5qYdjRW53AfjNb/YAK3Nww4wS9dKSGW3SqHBp+jZSfREcCGmJYwboQHVghRSxlo64Nut 5w3VBJr7meRIfNyihQev9xbgG9yg7OWiSXbJR4PQ== X-Received: by 2002:a17:90b:5870:b0:33b:a906:e40 with SMTP id 98e67ed59e1d1-354870a5b6fmr4816464a91.2.1770273111310; Wed, 04 Feb 2026 22:31:51 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.212]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6c83127962sm3796413a12.10.2026.02.04.22.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 22:31:50 -0800 (PST) From: Qing Wang To: syzbot+e57495fb65020ac7bca4@syzkaller.appspotmail.com Cc: agruenba@redhat.com, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [gfs2?] memory leak in gfs2_quota_init (2) Date: Thu, 5 Feb 2026 14:31:45 +0800 Message-Id: <20260205063145.1039526-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <69837ac0.a00a0220.34fa92.0011.GAE@google.com> References: <69837ac0.a00a0220.34fa92.0011.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index f6cd907b3ec6..1144720a17ff 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -149,9 +149,12 @@ int gfs2_make_fs_rw(struct gfs2_sbd *sdp) error = gfs2_quota_init(sdp); if (!error && gfs2_withdrawn(sdp)) error = -EIO; - if (!error) - set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags); - return error; + if (error) { + gfs2_quota_cleanup(sdp); + return error; + } + set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags); + return 0; } void gfs2_statfs_change_in(struct gfs2_statfs_change_host *sc, const void *buf)