From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A993921FC for ; Thu, 5 Feb 2026 09:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770282394; cv=none; b=RrnZXjYJstK+AjCl14NpRV/VOXU0hAgOa5lm2ZwQPuhHDLqvupjY9lFOsXC1bh72bnZLL31e5ztBYganDNWBY8gF/CbwYKI0qSSydonAsFLlrV5ctJSugGeB6d7QAEY1TULmSDr/FqGCEAnCvNUyWEQc7rJD6TX2aqtzx57x7Tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770282394; c=relaxed/simple; bh=lyo6nqDDqj6b4jw4yDLe1kuUBI4lfxRinrjxZ6Tk6R4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WhuTDxfJzbJMaOKhn4+fAD3aVqj2nkiY4aX+QFPIpsFkJwshaN3CDP3+XhnjWwPsjD0UTJ6X8wXxac2cChXYGGfQyboGH1CKm9bkqn6dB08fCDdF318Upcc3OlNnX/sRDk2T+f9koOo92wYcSlA5awlgBARjSCV4pFoMf6TqiKs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TUzlWIRt; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TUzlWIRt" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-c551edc745eso309063a12.2 for ; Thu, 05 Feb 2026 01:06:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770282394; x=1770887194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+hNpFgt4G3myXpb9M3EBnCESjMOaUpwOG54Qogd9Uao=; b=TUzlWIRtrejVkmGYXyKAfertaI3JCfK2Ey+gU7mKyCxe7QhiGr14KxOCrRn4cGfhvl aCs4D5r5M09hv0U/B+yW1U9YBbvKLwgGt1u+gZX7hWiixNA34hGtTofropCceS70/Q8N eFtXYX7sA6UYBMY7+sG7eQYb8y9SBvIWllFyodslYvr9wUoXaezC39/myN0YDmINEgcE qigqmkeU+zeJHu3lDatvHQQ9T19Dby7ZgDKvdjrASrf6vb/VrS26IRq7kGe4RZXq7bND wq59sRCLYP2cc1LjtIXhRhabK0ZjS72LMoAWyYbr9YzQFhWAX8EJVGhfA9HQCn9SNUXF nu2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770282394; x=1770887194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+hNpFgt4G3myXpb9M3EBnCESjMOaUpwOG54Qogd9Uao=; b=XO8dQxxLW+DYWoJ7c1nEte7lWxtpaeHluzSfdKmKFJX4i1AM0ElvWHDstWzTsoW8Mb fciBifXZiDL4jJBwcZYFCDeI4Amz3KJ/G8AlgOuxu2jvfKILuIN5+W9rTrjlKYdY5DWa fEityfWO/XW4t0q7cQ5AW7XnEC0iOb5AJ48XJKAymCx9WDqrULOhji+djqAsAa46GGTT BpQ8X9a1sT1TE+rfE+t8+hNRbCbR0LFqeii8k+NGZY9KuzOozV/AJ1PO/x6DputlYKC9 kaBpyxgoOsESQ7f/vaCAxMOp+JWFqwAZ24r4PFBMdLwSV9FJehe1q0ya9wgNiE9Tdxgp L9EA== X-Forwarded-Encrypted: i=1; AJvYcCUaFwVjVQZ/SpcaWBDkI8O7Z61GYg6mMF2alWs5KN8u0FEFeLvt3eWJiu2vX62f87X11T6zfw04KbbSSp0=@vger.kernel.org X-Gm-Message-State: AOJu0YzDqx5jAUooGfDIPkY+1WpBgSde9xfWKoQVDuLFUl/JNqbxS73C hqdNZJWIdYUSfkk6mLvzAJWSdTLrKZmZNO8tvjFqFx1hJvT+q7Qr7UMO X-Gm-Gg: AZuq6aI6kndCuJlUKNxrFEK5j2Bg1pT/5WfD9/HYKuhklKWKO2VWJs/yeKimpMNZNAM uJ6ED0Z7vn9+keC+0kXpOPGspE8AlY3KvVdDiLDEgO83J8J2Hj8f6jZ3YpaPxX5t9sr/VMXEvU6 KKYyvDDRJ4W+IRXtyQZVaEznW4szWeZMBLt+0yVnl9yhghajX8b/C07ZLHteUeR6tlF8zqK+dZh hcC8eYOGYAuMvyzKfrUHOdtg9TacDrJCHgV0fd7D3hdOEMM4TL/3CQf/8MlBMZSIC1RYKEhdhMw T4gCANC6PRHFUSttxMD1gEVS3SHGOrM5bZnp8YApaxgkdO2hJMvdIxum8+dqa7zTCa06t7fjKlF TLqVHbG31WxNzXIrhrZ5G/SAzSJxhu/E79DAGWMsW59Jo1ktLjWbgijxXPejPiwDqChta/HMa10 3ngQF5sXsUenYqNs79ZRmcMlFcZCLd1AjJectbREbUC8OooPWu X-Received: by 2002:a05:6a21:3513:b0:38d:fe2a:4b0a with SMTP id adf61e73a8af0-3937211de01mr5900451637.33.1770282393777; Thu, 05 Feb 2026 01:06:33 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.212]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a93397c2fdsm44397615ad.87.2026.02.05.01.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 01:06:33 -0800 (PST) From: Qing Wang To: syzbot+e57495fb65020ac7bca4@syzkaller.appspotmail.com Cc: agruenba@redhat.com, gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [gfs2?] memory leak in gfs2_quota_init (2) Date: Thu, 5 Feb 2026 17:06:28 +0800 Message-Id: <20260205090628.1105496-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <69837ac0.a00a0220.34fa92.0011.GAE@google.com> References: <69837ac0.a00a0220.34fa92.0011.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit #syz test diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c index f6cd907b3ec6..efa0e2452bc7 100644 --- a/fs/gfs2/super.c +++ b/fs/gfs2/super.c @@ -147,8 +147,10 @@ int gfs2_make_fs_rw(struct gfs2_sbd *sdp) } error = gfs2_quota_init(sdp); - if (!error && gfs2_withdrawn(sdp)) - error = -EIO; + if (!error && gfs2_withdrawn(sdp)) { + gfs2_quota_cleanup(sdp); + return -EIO; + } if (!error) set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags); return error;