From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C53428002B for ; Thu, 5 Feb 2026 06:03:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770271400; cv=none; b=eUzwarp/kTy75dvXA8OqaWrfH6MaXB3atQv53zD6MfyeqjPuhJh01Uu+o0/TTcS+4vuGuqXU8jFydefzjnGUfUSUUFjrAHzIbUAsELT8qaEVKCQOKJHSQv88h+h0swRzrv4OioRfQAOwcjjw3jyX3Yzdff9z6o3YOiwN0KfDaXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770271400; c=relaxed/simple; bh=BDCUlCTUtKL1ll0q3c1AyzBpWMPkXxJEpeNBhGeoLA4=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=AEUW+bS60INOkq35FV2MokvqJjLzTS8rjteLDQ9aaXfhJgxNq5XYWFm4f5WJLTX/aOf8+gNdN0r7ivOn1HtmZAtya1LQ6WnRI99T77BRrp5bOfukUpysRhmljZ21NmuutmuCRe8X4jSQSwoQBL1O5KGAdkH/pCC+Cbsm0wfg/u0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=qORhYAuF; arc=none smtp.client-ip=209.85.221.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qORhYAuF" Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-43590777e22so301796f8f.3 for ; Wed, 04 Feb 2026 22:03:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770271398; x=1770876198; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NHWx0PbMlZm2EZQ9woaRQQzqIT91zZKTnoROkZ981zY=; b=qORhYAuFQQ3P/PZrZiEbXnRrR1NgyVCs4s3m7RpDqWDdcaFm57Jg8j7IlNqNpNfSsc YproYbkpVKWZK3Fgc9KaNt02ktfopdJJnBwNZMtFHd/ZMz6LniplhfNRDDr3TLxEeaT/ kp9aJLiFQRAw0RflkPw85lm3QPrQ6Kv1RE+S1gN5Cqp0MFi90VsExLh0UVEBFFW3lTQ2 +sGZm30+BC4bGS27670buhsJiAKREXgMvwXlrM78WVVatJSWiztEOaVE1uY+kGYXTGeA wX/8OyDiFCY7hNfm/aV0ggrMwM+BU7Sw4mkjiKSZeNciMhHZ3GKycImj43CE18h2e01R tY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770271398; x=1770876198; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NHWx0PbMlZm2EZQ9woaRQQzqIT91zZKTnoROkZ981zY=; b=nKRWx+Y2n1HPmzuBsT9w607brx0Z7warADIKBI7AXWxIVo1IC5vAWJwHq3S2QeNPd7 4Pqhq2o5ICTXWazhnF5Pr4YQarDsLM4bbD8f6ZTG0zcYVp8zruCvURDKGx2JcCb9oi7h OAo/VzQol4dhFbPqIzWVGAIhw69ouvkEJimei1Kj4pT87jXZKMONyvC1yGjqony02Yk6 Dy2wIZHJcpQguSEAOzMW+efwKCGpIR3QpMTYjJhphIaMIgTCBIGXe3zF3va1Ml8Vjyax 9RL6JdkA6s4buzmx0Wh9RLvA7r4ZJNHmLSHCTDuxZ5kr6qZBSoRAVijMk8tU6ADKVjl8 Ur3A== X-Forwarded-Encrypted: i=1; AJvYcCWbcjNedpD+EuyBOpwnReqbiWZb0Js2/ClRb05LnLrDn2MDF/1PUx/9o551Wc3nuRbscLbAJkiga76JI30=@vger.kernel.org X-Gm-Message-State: AOJu0YwOiRLmzeAKeJYu3kUgNIPK3pXTYaOgBueyYBzeZ/3CauZJP8sp 3DVAqpNXYSHhle/SgnPhVstoM8gWdHX7qJeS8MKnvkS02yWGxVy/OkDAePMuKJAhXWg= X-Gm-Gg: AZuq6aIBFJ5FDXiKoIMEmIJXJ44rLqXDVXOPUK1tmi0JpQe/Ov/Pi0gvYM40uU/OWyD 42u8dMAn20Q3nkPtTRaApP/XrRQO6ssXufEkm/4ZEeEMGd07CIghn4OIIS37jhq38Ll3aoinCiz zu38H9I3iPIUFyleJrpYWtkpwMNgdfZfSnlUrw1RfjBizfunIpq1KXRruzwKgJ1LZ+U8iUHxHhk NVr8AcyIS9RG8gALkqIOLOvDcuFqMBdeVbPmXMUc7T2VDzR5gKZmzw0NCYaVKvtCaUi0yY9NShA JOFjTnBqCJreK7X+GkbGw/JnRsfLRrdivNbx41CLgsuqLuLqbUpnTQJlS+oSJQQf4hjSLHPAHKb IXKahTKcTqFlvOwHbymHbsSufSP188It9gzKJ1vRmLUhHVdSAdfsl604xNQvrq5gpdmjLQrgj0g WaCEz0YEaxpo9GnXsUdikH5olf1/g= X-Received: by 2002:a05:6000:25c8:b0:432:851d:23e2 with SMTP id ffacd0b85a97d-4361805bf71mr7400771f8f.49.1770271398404; Wed, 04 Feb 2026 22:03:18 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e25683sm11031108f8f.6.2026.02.04.22.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 22:03:17 -0800 (PST) Date: Thu, 5 Feb 2026 09:03:14 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Jonathan Santos , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Jonathan Santos , Michael.Hennerich@analog.com, lars@metafoo.de, jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Subject: Re: [PATCH 3/3] iio: adc: ad7768-1: add support for SPI offload Message-ID: <202602051234.5gArzLyZ-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f9aedbe374461e48f1f1e64d5487b5b6c1fc992.1769889074.git.Jonathan.Santos@analog.com> Hi Jonathan, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Santos/iio-adc-ad7768-1-fix-one-shot-mode-data-acquisition/20260204-203950 base: d820183f371d9aa8517a1cd21fe6edacf0f94b7f patch link: https://lore.kernel.org/r/9f9aedbe374461e48f1f1e64d5487b5b6c1fc992.1769889074.git.Jonathan.Santos%40analog.com patch subject: [PATCH 3/3] iio: adc: ad7768-1: add support for SPI offload config: x86_64-randconfig-161-20260205 (https://download.01.org/0day-ci/archive/20260205/202602051234.5gArzLyZ-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 smatch version: v0.5.0-8994-gd50c5a4c If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202602051234.5gArzLyZ-lkp@intel.com/ New smatch warnings: drivers/iio/adc/ad7768-1.c:1789 ad7768_spi_offload_probe() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +1789 drivers/iio/adc/ad7768-1.c 0cac6d2893a658 Jonathan Santos 2026-01-31 1758 static int ad7768_spi_offload_probe(struct iio_dev *indio_dev, 0cac6d2893a658 Jonathan Santos 2026-01-31 1759 struct ad7768_state *st) 0cac6d2893a658 Jonathan Santos 2026-01-31 1760 { 0cac6d2893a658 Jonathan Santos 2026-01-31 1761 struct device *dev = &st->spi->dev; 0cac6d2893a658 Jonathan Santos 2026-01-31 1762 struct spi_offload_trigger_info trigger_info = { 0cac6d2893a658 Jonathan Santos 2026-01-31 1763 .fwnode = dev_fwnode(dev), 0cac6d2893a658 Jonathan Santos 2026-01-31 1764 .ops = &ad7768_offload_trigger_ops, 0cac6d2893a658 Jonathan Santos 2026-01-31 1765 .priv = st, 0cac6d2893a658 Jonathan Santos 2026-01-31 1766 }; 0cac6d2893a658 Jonathan Santos 2026-01-31 1767 struct dma_chan *rx_dma; 0cac6d2893a658 Jonathan Santos 2026-01-31 1768 int ret; 0cac6d2893a658 Jonathan Santos 2026-01-31 1769 0cac6d2893a658 Jonathan Santos 2026-01-31 1770 ret = devm_spi_offload_trigger_register(dev, &trigger_info); 0cac6d2893a658 Jonathan Santos 2026-01-31 1771 if (ret) 0cac6d2893a658 Jonathan Santos 2026-01-31 1772 return dev_err_probe(dev, ret, 0cac6d2893a658 Jonathan Santos 2026-01-31 1773 "failed to register offload trigger\n"); 0cac6d2893a658 Jonathan Santos 2026-01-31 1774 0cac6d2893a658 Jonathan Santos 2026-01-31 1775 st->offload_trigger = devm_spi_offload_trigger_get(dev, st->offload, 0cac6d2893a658 Jonathan Santos 2026-01-31 1776 SPI_OFFLOAD_TRIGGER_DATA_READY); 0cac6d2893a658 Jonathan Santos 2026-01-31 1777 if (IS_ERR(st->offload_trigger)) 0cac6d2893a658 Jonathan Santos 2026-01-31 1778 return dev_err_probe(dev, PTR_ERR(st->offload_trigger), 0cac6d2893a658 Jonathan Santos 2026-01-31 1779 "failed to get offload trigger\n"); 0cac6d2893a658 Jonathan Santos 2026-01-31 1780 0cac6d2893a658 Jonathan Santos 2026-01-31 1781 rx_dma = devm_spi_offload_rx_stream_request_dma_chan(dev, st->offload); 0cac6d2893a658 Jonathan Santos 2026-01-31 1782 if (IS_ERR(rx_dma)) 0cac6d2893a658 Jonathan Santos 2026-01-31 1783 return dev_err_probe(dev, PTR_ERR(rx_dma), 0cac6d2893a658 Jonathan Santos 2026-01-31 1784 "failed to get offload RX DMA\n"); 0cac6d2893a658 Jonathan Santos 2026-01-31 1785 0cac6d2893a658 Jonathan Santos 2026-01-31 1786 ret = devm_iio_dmaengine_buffer_setup_with_handle(dev, indio_dev, 0cac6d2893a658 Jonathan Santos 2026-01-31 1787 rx_dma, IIO_BUFFER_DIRECTION_IN); 0cac6d2893a658 Jonathan Santos 2026-01-31 1788 if (ret) 0cac6d2893a658 Jonathan Santos 2026-01-31 @1789 return dev_err_probe(dev, PTR_ERR(rx_dma), s/PTR_ERR(rx_dma)/ret/ 0cac6d2893a658 Jonathan Santos 2026-01-31 1790 "failed to setup offload RX DMA\n"); 0cac6d2893a658 Jonathan Santos 2026-01-31 1791 0cac6d2893a658 Jonathan Santos 2026-01-31 1792 indio_dev->setup_ops = &ad7768_offload_buffer_ops; 0cac6d2893a658 Jonathan Santos 2026-01-31 1793 st->offload_en = true; 0cac6d2893a658 Jonathan Santos 2026-01-31 1794 0cac6d2893a658 Jonathan Santos 2026-01-31 1795 return 0; 0cac6d2893a658 Jonathan Santos 2026-01-31 1796 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki