From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51BDB26ED59 for ; Fri, 6 Feb 2026 19:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770407539; cv=none; b=YTZMreoNPt9RH/GfMTuU0kVZgU16mgQrRH4VPjVa4HXCkmAzN5A2tTyOT9NwIFTvZuQNwEhcJ382kbi3OrhWMSJlBZXLfy82xIrAklQ2qnzlxdiMg0I8lOaSHs7VudD7F+T0LdhfAhZ0hLsTY7a53WplGa6i6OGrSyAjAmjlBIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770407539; c=relaxed/simple; bh=CJFSsWdO5Opr8LpgB3J13to1nCjR+HtWwfNjRTQ8Yw0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y//+wlo8E05W6Qs3w50FZKLSSaXSwbHn1+yejtsSED1SXbA8QzBkKdAzfO3waKPIsoqStYQmWB0csbufAETldXOAyPSNzu6xVGE7q6PqcqJS91DjlvqEZ1FBYvpTELdS38FRSOmQ3IxgJdjO7D9TfS/iIrO6+oxBycecr58NQDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DIFXG6KH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DIFXG6KH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFD25C116C6; Fri, 6 Feb 2026 19:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770407538; bh=CJFSsWdO5Opr8LpgB3J13to1nCjR+HtWwfNjRTQ8Yw0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DIFXG6KH++T6V7fSAY4mYvzOkKP9bxZiq1zidtMLZdDLmfBL58dGSbwPfLzI9FaYI Goceerc3EDi99VYSJ9FHJY0sPKyoZ085W2dvpusduE9QlUDe1EXT4QOU8nzryfEwdL 6jR7BsF4sZKNMjtNrOUBW+sxeLxlyAJcaloVZ1Voug7yA/wpY4iY/f8C7D/44JSFpC 8um+lwPJL+rlaTz0JoU6UmK0DKdNQ69qf+kwILlKOteQEJXNYZYLQAq8CCuJigafY5 Pcns0wQAmKgoEJk0YUEPl07dk5foc3cNtut5vWR5FqY/lMmNRRNSo0tCO6PU+v9Qfv VPvJyteI1PfXw== Date: Fri, 6 Feb 2026 19:52:15 +0000 From: Conor Dooley To: Felix Gu Cc: Conor Dooley , Daire McNamara , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: microchip: mpfs: Fix a memory leak in mpfs_sys_controller_probe() Message-ID: <20260206-neurosis-partner-009242f0ac16@spud> References: <20260203-mpfs-v1-1-666b8704f8f7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="17ifevd45IYDWzDL" Content-Disposition: inline In-Reply-To: <20260203-mpfs-v1-1-666b8704f8f7@gmail.com> --17ifevd45IYDWzDL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 03, 2026 at 09:03:52PM +0800, Felix Gu wrote: > In mpfs_sys_controller_probe(), when of_get_mtd_device_by_node() fails, > the previously allocated sys_controller was leaked. >=20 > Add kfree() to fix this. >=20 > Fixes: 742aa6c563d2 ("soc: microchip: mpfs: enable access to the system c= ontroller's flash") > Signed-off-by: Felix Gu > --- > drivers/soc/microchip/mpfs-sys-controller.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/mi= crochip/mpfs-sys-controller.c > index 30bc45d17d34..a7401cb79e97 100644 > --- a/drivers/soc/microchip/mpfs-sys-controller.c > +++ b/drivers/soc/microchip/mpfs-sys-controller.c > @@ -142,8 +142,11 @@ static int mpfs_sys_controller_probe(struct platform= _device *pdev) > =20 > sys_controller->flash =3D of_get_mtd_device_by_node(np); > of_node_put(np); > - if (IS_ERR(sys_controller->flash)) > - return dev_err_probe(dev, PTR_ERR(sys_controller->flash), "Failed to g= et flash\n"); > + if (IS_ERR(sys_controller->flash)) { > + ret =3D dev_err_probe(dev, PTR_ERR(sys_controller->flash), "Failed to = get flash\n"); > + kfree(sys_controller); > + return ret; > + } > =20 > no_flash: > sys_controller->client.dev =3D dev; This is a duplicate of a patch in my riscv-soc-fixes branch, that for whatever reason I forgot to push. I'll keep the original but thanks for your patch. --17ifevd45IYDWzDL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaYZGawAKCRB4tDGHoIJi 0jPjAPoDwTApwoTXqPLgAccyGeWmdXouPdw6RxYbgSJAGbmG4wD/frfXvCbNsNRD BFX0xlMD1pXQbUJI4Q0QCgdOQuEuNAw= =TeL1 -----END PGP SIGNATURE----- --17ifevd45IYDWzDL--