From: Leo Yan <leo.yan@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Leo Yan <leo.yan@arm.com>
Subject: [PATCH] perf record: Simplify open event error logs
Date: Fri, 06 Feb 2026 16:29:37 +0000 [thread overview]
Message-ID: <20260206-perf_improve_log_for_open_event_failures-v1-1-366903bebcd7@arm.com> (raw)
Instead of printing error messages for every event failure, this commit
prints a log only when the first error occurs.
Duplicate event names are a special case. Print an explicit log message
only when verbose logging is enabled.
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
tools/perf/builtin-record.c | 69 ++++++++++++++++++++++++++++-----------------
1 file changed, 43 insertions(+), 26 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index aa8dc3e18190dd7db1ed5e3c7673fde8d5785a26..9382ff57a822ad4ee5391116510941ce180a12d8 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1343,6 +1343,31 @@ static int record__mmap(struct record *rec)
return record__mmap_evlist(rec, rec->evlist);
}
+static bool record__is_event_name_duplicated(struct evlist *evlist,
+ struct evsel *pos)
+{
+#if defined(__aarch64__) || defined(__arm__)
+ if (strstr(evsel__name(pos), "cycles")) {
+ struct evsel *pos2;
+
+ /*
+ * Unfortunately ARM has many events named
+ * "cycles" on PMUs like the system-level (L3)
+ * cache which don't support sampling. Only
+ * display such failures to open when there is
+ * only 1 cycles event or verbose is enabled.
+ */
+ evlist__for_each_entry(evlist, pos2) {
+ if (pos2 == pos)
+ continue;
+ if (strstr(evsel__name(pos2), "cycles"))
+ return true;
+ }
+ }
+#endif
+ return false;
+}
+
static int record__open(struct record *rec)
{
char msg[BUFSIZ];
@@ -1353,6 +1378,7 @@ static int record__open(struct record *rec)
int rc = 0;
bool skipped = false;
bool removed_tracking = false;
+ bool report_once = true;
evlist__for_each_entry(evlist, pos) {
if (removed_tracking) {
@@ -1370,8 +1396,6 @@ static int record__open(struct record *rec)
}
try_again:
if (evsel__open(pos, pos->core.cpus, pos->core.threads) < 0) {
- bool report_error = true;
-
if (evsel__fallback(pos, &opts->target, errno, msg, sizeof(msg))) {
if (verbose > 0)
ui__warning("%s\n", msg);
@@ -1383,36 +1407,29 @@ static int record__open(struct record *rec)
pos = evlist__reset_weak_group(evlist, pos, true);
goto try_again;
}
-#if defined(__aarch64__) || defined(__arm__)
- if (strstr(evsel__name(pos), "cycles")) {
- struct evsel *pos2;
- /*
- * Unfortunately ARM has many events named
- * "cycles" on PMUs like the system-level (L3)
- * cache which don't support sampling. Only
- * display such failures to open when there is
- * only 1 cycles event or verbose is enabled.
- */
- evlist__for_each_entry(evlist, pos2) {
- if (pos2 == pos)
- continue;
- if (strstr(evsel__name(pos2), "cycles")) {
- report_error = false;
- break;
- }
- }
+
+ if (pos->tracking)
+ removed_tracking = true;
+ pos->skippable = true;
+ skipped = true;
+
+ if (record__is_event_name_duplicated(evlist, pos)) {
+ if (verbose > 0)
+ ui__error("Skip to open event '%s' on PMU '%s' due to "
+ "the duplicated naming.\n",
+ evsel__name(pos), evsel__pmu_name(pos));
+ continue;
}
-#endif
- if (report_error || verbose > 0) {
+
+ if (verbose > 0 || report_once) {
evsel__open_strerror(pos, &opts->target, errno, msg, sizeof(msg));
ui__error("Failure to open event '%s' on PMU '%s' which will be "
"removed.\n%s\n",
evsel__name(pos), evsel__pmu_name(pos), msg);
+
+ if (report_once)
+ report_once = false;
}
- if (pos->tracking)
- removed_tracking = true;
- pos->skippable = true;
- skipped = true;
}
}
---
base-commit: 3d8b2baefecdd5e84a1c738bcfdb079aa536d997
change-id: 20260204-perf_improve_log_for_open_event_failures-deda2c61b93d
Best regards,
--
Leo Yan <leo.yan@arm.com>
next reply other threads:[~2026-02-06 16:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 16:29 Leo Yan [this message]
2026-02-06 19:19 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206-perf_improve_log_for_open_event_failures-v1-1-366903bebcd7@arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®