From: Romain Sioen <romain.sioen@microchip.com>
To: <linux-kernel@vger.kernel.org>
Cc: <gupt21@gmail.com>, <jikos@kernel.org>,
<marius.cristea@microchip.com>,
Romain Sioen <romain.sioen@microchip.com>
Subject: [PATCH] HID: mcp2221: use mcp_i2c_smbus_read for block reads
Date: Fri, 6 Feb 2026 17:31:53 +0100 [thread overview]
Message-ID: <20260206163153.130026-1-romain.sioen@microchip.com> (raw)
Refactor mcp_smbus_xfer() to use the mcp_i2c_smbus_read() helper function
for I2C_SMBUS_BLOCK_DATA and I2C_SMBUS_I2C_BLOCK_DATA read operations.
This replaces the manual setup of the receive buffer and explicit calls
to mcp_send_data_req_status(), making the code cleaner and more consistent
with other read paths in the driver.
Signed-off-by: Romain Sioen <romain.sioen@microchip.com>
Signed-off-by: Marius Cristea <marius.cristea@microchip.com>
---
drivers/hid/hid-mcp2221.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
index 33603b019f975..64dcedbcc0fc9 100644
--- a/drivers/hid/hid-mcp2221.c
+++ b/drivers/hid/hid-mcp2221.c
@@ -534,10 +534,10 @@ static int mcp_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
if (ret)
goto exit;
- mcp->rxbuf_idx = 0;
- mcp->rxbuf = data->block;
- mcp->txbuf[0] = MCP2221_I2C_GET_DATA;
- ret = mcp_send_data_req_status(mcp, mcp->txbuf, 1);
+ ret = mcp_i2c_smbus_read(mcp, NULL,
+ MCP2221_I2C_RD_RPT_START,
+ addr, data->block[0] + 1,
+ data->block);
if (ret)
goto exit;
} else {
@@ -553,14 +553,14 @@ static int mcp_smbus_xfer(struct i2c_adapter *adapter, u16 addr,
case I2C_SMBUS_I2C_BLOCK_DATA:
if (read_write == I2C_SMBUS_READ) {
ret = mcp_smbus_write(mcp, addr, command, NULL,
- 0, MCP2221_I2C_WR_NO_STOP, 1);
+ 0, MCP2221_I2C_WR_NO_STOP, 0);
if (ret)
goto exit;
- mcp->rxbuf_idx = 0;
- mcp->rxbuf = data->block;
- mcp->txbuf[0] = MCP2221_I2C_GET_DATA;
- ret = mcp_send_data_req_status(mcp, mcp->txbuf, 1);
+ ret = mcp_i2c_smbus_read(mcp, NULL,
+ MCP2221_I2C_RD_RPT_START,
+ addr, data->block[0],
+ &data->block[1]);
if (ret)
goto exit;
} else {
--
2.53.0
next reply other threads:[~2026-02-06 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 16:31 Romain Sioen [this message]
2026-02-27 17:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206163153.130026-1-romain.sioen@microchip.com \
--to=romain.sioen@microchip.com \
--cc=gupt21@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®