From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A87FD423A8F for ; Fri, 6 Feb 2026 17:42:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399747; cv=none; b=mxmoaqy5blnDwCq54KIhUBkT4MMhFBrOB4X84etHC0ia/VU3zbx4sSninP/DkZla/S34e90gk816jTFO8n3bQ8tAxIpw6nsJWlxm2WRtLu3T/no1ii/2N/bBPJNG2jbhHfuzESkwVDWtWQThpykKQK7dr95wfCRWeVrxrky/buY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770399747; c=relaxed/simple; bh=SchQesNNes/b+zoyFfFtrbwOol1qEYkgQ99qErjdD50=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NIvrdlVCK2i54hI9QUhO2qibIczIQdjEsrdh1njW961pK8HSC7WTYTkTPYwRc93XXCOeMYCaCIgQZ5vuFq0i4GvUTWZ0LyCTmnYzdeVPmm20prnZUQ3vcAhVPFywTb6Y0ItjcrH5c/U7nQPCQnuGKLkfesKFFxWWiXI6ARQ6qfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io; spf=pass smtp.mailfrom=layalina.io; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b=cbmzJ50u; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=layalina.io Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=layalina.io Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=layalina-io.20230601.gappssmtp.com header.i=@layalina-io.20230601.gappssmtp.com header.b="cbmzJ50u" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47ee2715254so15574905e9.3 for ; Fri, 06 Feb 2026 09:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20230601.gappssmtp.com; s=20230601; t=1770399745; x=1771004545; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HRlRnE91f2IBhKwRMOrwo97z7ovUO54L8rkgzl9Uxug=; b=cbmzJ50uHu3xWoui6yxczdxXtCwqokbHMk/f1YtxmmqvCCsRF8+PiHYlHTEUHK0jmg 3ba6C9vu8ph3dYJT0c5rgwkZ4FzylQ8y2Jl/+i3mvf/R250mXBwJXx0uJGGQ14gqFOH/ xIq7zaN7vA+XU6tY3xXXTd/QffFjJwfHOeGCe3eBRIXAFFDW4G6XgLTr3UZbUkqXEgwq AjrSkYzbUDibCUNv2dgRgqXdF0GhZSkxcAgvmuRIebE4ymJS3u8n+w/KqZ2Rq6drVqHs Ow8xCsJDj1Wz7Y0evJ0nSEeWJ8gzeL7d58h0/gAhSa7vFK5Rct8vPrzGS3+0ny73vZbT 3/dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770399745; x=1771004545; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HRlRnE91f2IBhKwRMOrwo97z7ovUO54L8rkgzl9Uxug=; b=YcUKckiCS0UkK4KpRP4arPSW1uFc3Kf3Qyj2HfS98aWrmd+r9HLFXUtcEZPnzg+QrV P99G8NA9hJdmv+XKPpvdwVx5ZQHhL0GZaQflfaEC9PuHdX6b8o+hi0u4KCT5e+HyKxuc A0ZCT9ICTYjuuIZwyrDGlj/Qp74ycJnfAG92XDJNeq4lSwkKtrl8gC5xB1+L2x1/GYnq GOtea7MDxvoAVzDEwd74Lb2gG2lr+3gIQKAmnzJO66hi/cQ0V4kuHhL+29bi3G6JDRYj ycKhPjPPhFy6Ewlu5S1yJWa2rKpDUGtJKBAfnM8XwTSefcnEYSU2w3taSH0jWRXVuwD6 6G4A== X-Forwarded-Encrypted: i=1; AJvYcCVWL0epoaHFNp56hAcDSmwdMr8aKHGS1Jz82LlYJ4pixLKManxRDS7gKgRRYK2IDO2xnHh1l3fjTrLYuRk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6pqrL/8hF/SmVVJq87d4b02mGHYPfAQbaQOXax9nv0AIw1jGC qEdLKHmPw/gPI5DvGfk2wLCcQgjJKw2EkYApMxM2FQZl7vRuVRXhEXJPctnRgd35IgQ= X-Gm-Gg: AZuq6aLCTjRjxWd3rRX7cPiKaDkG9WKM/N6CbLx5wTJnmbEdMcGSP78aC9jajf6o+gu i9hAPArfuV4M65UXelubF+NT8vtz7OJN8yeBIaq/ffjCdEqvTy4vx1tVPfM4Z1hz5O6Tp/9gqU5 QYiGBNBCA3sDgr2GEVpdLUCrNR+MRDMlQv2MOKPy3S5Mrgc525a49Xjj37yBOLy4flUugZYrkWC zWiCpOn4y3TZEdSwOac0E92FQ6a+2lYf3IddJPQ2yHKsskXDy49aQRaoS+vuLnSoBpYbWbX+HBk vtSg/JiiRDCmFj5PsixZHbb02ZM7i+7RUypGJY15sJd4AM2bFE55VItR75icL8SmjUHx1pfJow7 ciLtxWscziHcWaR8Pa9nXnv2FbMEZ77z84uVDJ1WtAHucBpI7IitHb9S0BwOFunQoNvF3Rn8J4J kUcqDpM3UUNrZKoOOVp5sj0yFEerycXQ751H+FL+o2WP5FyF8Zbzcb1syRrZ50rbQ= X-Received: by 2002:a05:600c:1e2a:b0:480:6c75:ddce with SMTP id 5b1f17b1804b1-4832022bbe3mr53614305e9.33.1770399744938; Fri, 06 Feb 2026 09:42:24 -0800 (PST) Received: from airbuntu (host109-153-232-30.range109-153.btcentralplus.com. [109.153.232.30]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d7a963sm124214345e9.9.2026.02.06.09.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 09:42:24 -0800 (PST) Date: Fri, 6 Feb 2026 17:42:23 +0000 From: Qais Yousef To: Vincent Guittot Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, pierre.gondois@arm.com, kprateek.nayak@amd.com, hongyan.xia2@arm.com, christian.loehle@arm.com, luis.machado@arm.com Subject: Re: [PATCH 2/6 v8] sched/fair: Update overutilized detection Message-ID: <20260206174223.qpx2tyfwoq5jkxde@airbuntu> References: <20251202181242.1536213-1-vincent.guittot@linaro.org> <20251202181242.1536213-3-vincent.guittot@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20251202181242.1536213-3-vincent.guittot@linaro.org> On 12/02/25 19:12, Vincent Guittot wrote: > Checking uclamp_min is useless and counterproductive for overutilized state > as misfit can now happen without being in overutilized state > > Signed-off-by: Vincent Guittot Reviewed-by: Qais Yousef > --- > kernel/sched/fair.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index b10f04715251..f430ec890b72 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -6785,16 +6785,15 @@ static inline void hrtick_update(struct rq *rq) > > static inline bool cpu_overutilized(int cpu) > { > - unsigned long rq_util_min, rq_util_max; > + unsigned long rq_util_max; > > if (!sched_energy_enabled()) > return false; > > - rq_util_min = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MIN); > rq_util_max = uclamp_rq_get(cpu_rq(cpu), UCLAMP_MAX); > > /* Return true only if the utilization doesn't fit CPU's capacity */ > - return !util_fits_cpu(cpu_util_cfs(cpu), rq_util_min, rq_util_max, cpu); > + return !util_fits_cpu(cpu_util_cfs(cpu), 0, rq_util_max, cpu); > } > > /* > -- > 2.43.0 >