From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C2D41E9B3A; Sat, 7 Feb 2026 21:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770500222; cv=none; b=eMbFy34q3leVGeQtE/IxJPpf2FrZE36aqEUNvR1kOSegY3bRZguK0pSEiNvgBRZU/LcOQtnVTf7lvZESLqvTLPD4tB3wnyQtj4SyoilVjMqlYOj9+mIZhdIABw7eCFThpvQdzj7OhEbk49gkRXIbJsKtX8natV8LjdmrbtVIzeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770500222; c=relaxed/simple; bh=+TlIMoVyz/7h2s1Zpa+ueB2Mik6MAN0RFF7w2ls/WaI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UlIhRhzPS8x0jYhrCNQrqKK9RGCuuU0dgCCpvLaA9fYyj5T8l+3NCn4Yn1JuxvRzSmRlSQAY2twzka6k3dO3BY424wYFggK7fo/a2e1bpfsu5qrgHe+Ap1CpDjFqlzJnKyagyPr0pbySUgGOQTcWM7/dRF7rG01GcVruvmOpF+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=IPhFDFtV; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="IPhFDFtV" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3773F460; Sat, 7 Feb 2026 22:26:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770499600; bh=+TlIMoVyz/7h2s1Zpa+ueB2Mik6MAN0RFF7w2ls/WaI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IPhFDFtV6kjInHTZzWr9td58IqMkbinkgT+Y2KRpMH9tWMguIHxqo+duBNwASHjaV xn1PMQCiVY3D75tvlBzUMtibdGaKB11K/g5Uau5msuwJOqKeYIx+spk56zk0w9i4V+ RwM8EgKexAHN4t1RKNJLbV+K8qHBiDHuNZahxWys= Date: Sat, 7 Feb 2026 23:27:23 +0200 From: Laurent Pinchart To: Alper Ak Cc: Lad Prabhakar , Mauro Carvalho Chehab , Hans Verkuil , Tommaso Merciai , Daniel Scally , Jacopo Mondi , Biju Das , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: rzg2l-cru: Fix possible ERR_PTR deference Message-ID: <20260207212723.GN1376807@killaraus.ideasonboard.com> References: <20260207094841.603932-1-alperyasinak1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260207094841.603932-1-alperyasinak1@gmail.com> On Sat, Feb 07, 2026 at 12:48:39PM +0300, Alper Ak wrote: > The media_pad_remote_pad_unique() can return ERR_PTR() on failure > (-ENOTUNIQ or -ENOLINK), but the code was dereferencing the return > value without checking for errors. Add IS_ERR() check before > dereferencing the pointer. Have you seen this happening ? > Fixes: d7d72dae81d5 ("media: rzg2l-cru: Retrieve virtual channel information") > Signed-off-by: Alper Ak > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index 162e2ace6931..a34c2188df1a 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -411,6 +411,12 @@ static int rzg2l_cru_get_virtual_channel(struct rzg2l_cru_dev *cru) > int ret; > > remote_pad = media_pad_remote_pad_unique(&cru->ip.pads[RZG2L_CRU_IP_SINK]); > + if (IS_ERR(remote_pad)) { > + ret = PTR_ERR(remote_pad); > + dev_err(cru->dev, "Failed to get remote source pad: %d\n", ret); > + return ret; > + } > + > ret = v4l2_subdev_call(cru->ip.remote, pad, get_frame_desc, remote_pad->index, &fd); > if (ret < 0 && ret != -ENOIOCTLCMD) { > dev_err(cru->dev, "get_frame_desc failed on IP remote subdev\n"); -- Regards, Laurent Pinchart