From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A2430EF87 for ; Sat, 7 Feb 2026 21:47:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770500859; cv=none; b=XxNA9QWga3tMje8qK5OVetyiXgehwp5iI4hxtcFFkYMMSuQ6RRtQcvNsJRJrJpoE7BrHF0uaQSXRDdVSmN2SW0tAr4yOsUyzQz9tJlM5T+eQDEn/S7VYURbk0TYcYaO2rG0AVwiYipJ3RRzNsEupTumsBcgQ4mspGXkE2FuQZII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770500859; c=relaxed/simple; bh=Nap+MeiExbs2Ky+10HhauwyKHCc42uBEpa1rspvQNVY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SiAEgNFSGEYSLEO18U5eenvJU7vxm7+pfjlpA5rN7qk5HAEbchbuM4pIjKuoq4HAJHFLLNRpVr6OKDB5rymhZbBkR6MptkaYHPzkPdgGJ9dd/NPMmI/Gq8QbItVcC/l5JtwrdP7sjgp4Yw9N8o0CXA+SM51v77+O0O/C67SA66A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b4NNn+HE; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b4NNn+HE" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4832c8f9d87so507935e9.3 for ; Sat, 07 Feb 2026 13:47:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770500857; x=1771105657; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nap+MeiExbs2Ky+10HhauwyKHCc42uBEpa1rspvQNVY=; b=b4NNn+HEgkgbxPLz0surishB2NmaDRzRDnTVfPCkLiVp01o667t9eC7xfW39jRyqAg fWKKpXkstdWVb1u7zOx5gQT8gIPNHdQqWxzDL85/DN9e9VwJiLiQc0ZHEK55TpGKSftn rIs3ta0bbhpfUzIW8MCntwtZ8vsDjxyfT7Iez5ePLBl9sXoKpa7PGucBu6dYLhWDT3N1 xoATwzTqXWRMwUlXHtq0aruWflkPbqpkqyrjxOERtSSDc5kUk07MpUnl0+JOExjBu/6e xS3cgs39Lpee6DtDL1cPDqqDXMQaPj6Q1/s88ayO8Whsi8uHXgHcE1RvWNgNDsPt7Dsq X3ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770500857; x=1771105657; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nap+MeiExbs2Ky+10HhauwyKHCc42uBEpa1rspvQNVY=; b=TNRIsMOclpt1S4M3r914FVseBAc883HscBYksnLOmRZ/M19Xmu4ivpWhhnMVRtW903 FpuB0Cb1j7wN5QJl5peZZjRgynx0UKnvOdD7Q++cgAMrq7Bac9P6dnrljpaJPS9c/QEv tYXxBE1DlV+hlF9SI94gswEaEuTr6SFc866LvTS6BTnxOnakOoTRkmOxRjao5pfPoJm9 d3vjS+mnCiqn31Hb01VJP1pA58nB9K6PO5Xc+vT93hr33Zw1KaHLnm/Uoky8HT7ESBau i0rRR6xq+ej9WcwyXfhQa76+8bj250GUJjitMdRskPLkq4xwCkMiREThqqq5pjPPo1cE pd9g== X-Forwarded-Encrypted: i=1; AJvYcCV66QcuwrC5nxWt1Gds+t8ABObg/xlrTn8UqoGvfEOOJDQWzm1O0MlfMuRcIwANtPB5g0M52wRULLrpC6c=@vger.kernel.org X-Gm-Message-State: AOJu0YxIx03tZC/w/2vVOfHOddNS9Ap62tk3pRZ5AsAaZEFombUE2zvK zIfKwooU3mYuakpMeQBG8ZlXfWWzOd4KM8uSjkghlV3hbWgQWL22OCsR X-Gm-Gg: AZuq6aI+akR9ZTtbtyH9QJbQp3m747V91u+xXaxD/7h8cmCKx3LpOMB18jPi+Q7BsMP hpd1kH96fDuxMien1VKrd3a7ShNSC2imbN+d9tXtukPM+nX95o46PfCrhHq6bV900pO1Ksnndr1 c67POgBL61y2FVwi+TnNgpY7oJ+WZvhaS9BQD1ZUxtcu4cOhrK1l6WSWZXdCv8AjkBDFbcYN1+6 XpWeq4psSWxTfksLuBqM68UpGs8Ej6UGf1lGNoXtkcFrazpTc4WQoxT3BvhRhevCvuRwZ2mWYaw K/Hec7N+t6QjUXa3NNxRfbPQV2pwZKTco8me1+38r5e0oxPIr0ZHGqznIZNa0ruyqmDZb+e187G g043NObnwjlf+ywGpUhnixGEAZK0KKQ6pW1iv09wfkjSA4isOxE+Cp2ZuCCjaUfatzMD8Ds2NPA r/818= X-Received: by 2002:a05:600c:1c0a:b0:477:9dd9:ac57 with SMTP id 5b1f17b1804b1-48320177c15mr54493865e9.0.1770500857176; Sat, 07 Feb 2026 13:47:37 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:c705:d6fa:62de:90a5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d2ba61sm339174875e9.1.2026.02.07.13.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 13:47:36 -0800 (PST) Date: Sat, 7 Feb 2026 23:47:33 +0200 From: Vladimir Oltean To: Daniel Golle Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiner Kallweit , Russell King , Simon Horman , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Frank Wunderlich , Chad Monroe , Cezary Wilmanski , Liang Xu , John Crispin Subject: Re: [PATCH net-next v14 0/4] net: dsa: initial support for MaxLinear MxL862xx switches Message-ID: <20260207214733.m2zvh6ozo7vsc5hj@skbuf> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Feb 07, 2026 at 03:06:48AM +0000, Daniel Golle wrote: > This series adds very basic DSA support for the MaxLinear MxL86252 > (5x 2500Base-T PHYs) and MxL86282 (8x 2500Base-T PHYs) switches. > In addition to the 2.5G TP ports both switches also come with two > SerDes interfaces which can be used either to connect external PHYs > or SFP cages, or as CPU port when using the switch with this DSA driver. For the entire set: Reviewed-by: Vladimir Oltean with some minor comments I'll leave in individual patches, which I'd like you to address. I don't want to put anybody in a bad spot, but given what time it is, this set should get at least _some_ time in net-next before the upcoming net-next PR, to allow for some reaction time in case of some unexpected reports like from static analysis or similar. So it would be good, because of that, for the fixups as a result of my comments to be separate patches rather than a new version.