From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 193AD293C4E for ; Sun, 8 Feb 2026 04:04:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523443; cv=none; b=Jz7lw31wR0y/oSyDoBWUDfFY80KVda3ZgkAuWXySv6YqNFbtaf6+mY3QjX7BD9I/hZTg/ie669sLqUsGP7rWx3kjGVg+gh+up5LGhc6fy4+wKFyiQNoiqzMiQ1b0wqAVa0Tk3e+Z5wovn0t9qmB5Q6rxvyd7zWSBRsM8x4HFmYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770523443; c=relaxed/simple; bh=gVLYpM9coDM1ziPBdzZCYGdJwdE7dELsKzKbZ2xsotU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ibZKX1Eo/63syKK1FnxVjTcF5d5d+pSq8B1HnaryCjTDsdQEVmqDTWkqnOupf2VSDhGfDbKKM+/qxAmbbU1uvneEvQKLtbiU8Qd5L8qUYq6LlPht2ikODqvacqdbXSEy/U6P7RusHjz9rBRpKs90pbEcGWDURuyoAxcu6seI8sE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=P7qE1WmT; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="P7qE1WmT" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-1233c155a42so4195562c88.1 for ; Sat, 07 Feb 2026 20:04:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770523442; x=1771128242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oUKaI1Jl6BOBoZBMk5DmhJ8i+x4ONVWqzInJUK5fe+o=; b=P7qE1WmTEd5I37fInOyQx1w45mjLTo3qys+INfnu8t5IC9k+n6eN+ZAZ3b87UDXN2R v1vJuuW32wtajMDyRxLYu5uO5V3+NEqo2KKby93w25FfGf47VyoRpWyBNa5sxkx60LU+ stMtq3lODGpYytxQofsfgc5yc+ToC+xJyk3qI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770523442; x=1771128242; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oUKaI1Jl6BOBoZBMk5DmhJ8i+x4ONVWqzInJUK5fe+o=; b=ux5djHNYxHJFpGqFcGXA+8giuZjar3LwtKGlpOeaRLrSKWZ3/ZmEQ+8ENflpBp7519 Osa/EJ69hYjvCrjHh4hxHAqV73KEi8sZzRFeJANu7dH4QxTSDsvtEyog9y2Ggy1i+W/m sKUT8GwtiE9W0JySdGpgJoIRhQWBJjwEyCJIMoZyUIg5WAi3/jZ+lRCnEE+Kn0qdZNKA oe/GWmf5iaPfF5PQ88Re5DyoqEWZo0lT/IjskigkDz65lHrbAT2L2G3NRl0cFh1LAlCb QWvG1Rv+lG8/EHKq/6GXRJX6GyHE8ScoC32PwMJalq/tdaLltYxsfr9+EqbEBrmFMC1q 77JQ== X-Forwarded-Encrypted: i=1; AJvYcCVVGf4nvPLRKk8We4YrDORcInPFrr4XUmffNQuZzHK3m8jy/rbQvpelkMHF6dFNazq+xW1UoPoHrbHtpZs=@vger.kernel.org X-Gm-Message-State: AOJu0YyonJfLIzgfITKo5zHr/LodVvyYARmwHqSXQ1WKnsUjtXbjNnOy EttXhFgVUDrCw2K8BC62Ky+choLo7QYKKZ046Ys1D3BUpsGC82E/tmWfTXuTDoq/Kg== X-Gm-Gg: AZuq6aKEcLcnjpW9oqXoDx/5igoKUBqWMjOpwRwLCmePGFSddH6Zs8xvY4ocYRnRlAc 8wt6X+C0buTPeNxChc2hFfw3tXmH2pewgYWZWJJrxouQQbt8rjSt0Y2JDTz3C3MfKOh1sd4X7kF w1gMhjdogWJjzc7XLznlhzShUogIORK3Q9rgIpdFQROdqobwJzNYgIlCk56CGI4O/DJVPvaOPyI A3wjpd1Em+xfmcmzRCzp9yNW/oAXrIfEVYmjzerrwmpxb5LN5cqNebMjMZDBkJbUJ+mzGagfmXX HIGC9QrCL4LkfspvrVvD3Yd53I1RAFBFIWsMKwEocWGFfj53JyBWlEeKBIUknadtGyFuIWWl95F kb/flbGL5QrOl3CnuWRT2XlhnK/Ryrbg03k5ggU+CIzTLlKEA08OtILPPKDL+dFKLEhDMRkESIF Hhi4NFKINUg4+bwvjDNwY4nLXpJwplMkzJjyjZRO1i6qhSTqU2G2LteGN5+YcvtUgzhwEwHGA= X-Received: by 2002:a05:7022:6184:b0:123:2d38:928d with SMTP id a92af1059eb24-1270405aa72mr3860925c88.36.1770523442099; Sat, 07 Feb 2026 20:04:02 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:6d43:22d7:40eb:81e6]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-127041e61b9sm7085064c88.8.2026.02.07.20.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Feb 2026 20:03:59 -0800 (PST) From: Douglas Anderson To: jassisinghbrar@gmail.com Cc: Douglas Anderson , Frank.Li@nxp.com, Santosh Shilimkar , Sascha Hauer , andersson@kernel.org, arm-scmi@vger.kernel.org, cristian.marussi@arm.com, festevam@gmail.com, imx@lists.linux.dev, jay.buddhabhatti@amd.com, jonathanh@nvidia.com, kernel@pengutronix.de, konradybcio@kernel.org, krzk@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-tegra@vger.kernel.org, mathieu.poirier@linaro.org, michal.simek@amd.com, nm@ti.com, rafael@kernel.org, robh@kernel.org, shawn.guo@linaro.org, sudeep.holla@kernel.org, tglx@kernel.org, thierry.reding@gmail.com Subject: [PATCH v2 00/15] mailbox: Stop sending NULL mailbox messages Date: Sat, 7 Feb 2026 20:01:22 -0800 Message-ID: <20260208040240.1971442-1-dianders@chromium.org> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As talked about in the first patch in this series, passing NULL as the 'mssg' argument to mbox_send_message() ends up causing confusion and quirky behavior inside the mailbox core. Despite this, there are a number of drivers that pass NULL. It is plausible that some of the drivers passing NULL may have been taking advantage of the quirks of the mailbox core. Specifically, they may have been taking advantage that calling "tx_done" wasn't truly necessary for NULL messages (it was a noop) or that NULL messages were passed onto the mailbox controller right away without queuing. This series introduces a new API call: mbox_ring_doorbell(). The new API call tries to mimic the specific quirks that were helpful in the old behavior and it's expected to be a nearly drop-in replacement. There are some subtle differences between the new call and the old behavior, but it's expected that all of these differences are only for cases where the old behavior made little sense. The description of the first patch details these differences. The series attempts to convert all in-tree users to stop passing NULL for mssg. As per above, there are some slight differences in behavior. If any of the patches are causing problems, they can safely be reverted while debugging the problems. Eventually, all code should be converted over to stop passing NULL mssg. Changes in v2: - Instead of just documenting NULL, introduce a new function Douglas Anderson (15): mailbox: Deprecate NULL mbox messages; Introduce mbox_ring_doorbell() ACPI: PCC: Use mbox_ring_doorbell() instead of NULL message firmware: arm_scmi: Use mbox_ring_doorbell() instead of NULL message firmware: imx-dsp: Use mbox_ring_doorbell() instead of NULL message firmware: tegra: bpmp: Use mbox_ring_doorbell() instead of NULL message irqchip/qcom-mpm: Use mbox_ring_doorbell() instead of NULL message remoteproc: xlnx: Use mbox_ring_doorbell() instead of NULL message rpmsg: qcom_glink_rpm: Use mbox_ring_doorbell() instead of NULL message rpmsg: glink: smem: Use mbox_ring_doorbell() instead of NULL message rpmsg: qcom_smd: Use mbox_ring_doorbell() instead of NULL message soc: qcom: aoss: Use mbox_ring_doorbell() instead of NULL message soc: qcom: smp2p: Use mbox_ring_doorbell() instead of NULL message soc: qcom: smsm: Use mbox_ring_doorbell() instead of NULL message soc: ti: wkup_m3_ipc: Use mbox_ring_doorbell() instead of NULL message drivers: firmware: xilinx: Use mbox_ring_doorbell() instead of NULL message drivers/acpi/acpi_pcc.c | 4 +- .../firmware/arm_scmi/transports/mailbox.c | 8 +- drivers/firmware/imx/imx-dsp.c | 2 +- drivers/firmware/tegra/bpmp-tegra186.c | 4 +- drivers/irqchip/irq-qcom-mpm.c | 2 +- drivers/mailbox/mailbox.c | 82 ++++++++++++++++++- drivers/remoteproc/xlnx_r5_remoteproc.c | 2 +- drivers/rpmsg/qcom_glink_rpm.c | 3 +- drivers/rpmsg/qcom_glink_smem.c | 3 +- drivers/rpmsg/qcom_smd.c | 13 +-- drivers/soc/qcom/qcom_aoss.c | 3 +- drivers/soc/qcom/smp2p.c | 8 +- drivers/soc/qcom/smsm.c | 8 +- drivers/soc/ti/wkup_m3_ipc.c | 10 +-- drivers/soc/xilinx/zynqmp_power.c | 2 +- include/linux/mailbox_client.h | 1 + include/linux/mailbox_controller.h | 4 +- 17 files changed, 108 insertions(+), 51 deletions(-) -- 2.53.0.rc2.204.g2597b5adb4-goog