Re: [PATCH 1/5] dt-bindings: media: qcom,sm8550-iris: Add X1P42100 compatible

[Krzysztof Kozlowski <krzk@kernel.org>]

On Mon, Feb 09, 2026 at 03:39:03PM +0800, Wangao Wang wrote:
> Document the new compatible "qcom,x1p42100-iris", which uses a different
> set of clocks and OPP configuration compared to SM8550 and X1E80100.

And the device is or is not compatible?

> 
> Signed-off-by: Wangao Wang <wangao.wang@oss.qualcomm.com>
> ---
>  .../bindings/media/qcom,sm8550-iris.yaml           | 23 +++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> index 9c4b760508b50251ac467ad44a366689260bfc0d..0400ca1bff05dcef6b742c3fbf77e38adca9f280 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml
> @@ -26,6 +26,7 @@ properties:
>            - qcom,qcs8300-iris
>            - qcom,sm8550-iris
>            - qcom,sm8650-iris
> +          - qcom,x1p42100-iris

And what about resets? Why do you take only one reset?

So the device is not compatible? Then should not be in this binding but
separate file.

Commit msg should explain this. OPP configuration is not even relevant
in terms of choices of DTS/bindings/drivers...

>  
>    reg:
>      maxItems: 1
> @@ -41,13 +42,16 @@ properties:
>        - const: mmcx
>  
>    clocks:
> -    maxItems: 3
> +    minItems: 3
> +    maxItems: 4
>  
>    clock-names:
> +    minItems: 3
>      items:
>        - const: iface
>        - const: core
>        - const: vcodec0_core
> +      - const: vcodec0_bse

What is bse? Maybe it is bus? See SM8750.


>  
>    firmware-name:
>      maxItems: 1
> @@ -115,6 +119,23 @@ allOf:
>            maxItems: 1
>          reset-names:

Best regards,
Krzysztof