From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DD78238159 for ; Mon, 9 Feb 2026 10:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633469; cv=none; b=C2VbtSC+QZg8jscp77n0r3JWuhYEYCIgDDIYJSkh0Z88AIDMI2eisr3NJ9AHe5m4cbGzJh0QtWvcjsaqs5XuY9fzmo9BM/xhMWI/Wnnjq4Ib07QWrq3ZKgQMdVWJKywSjPF8t0qhkWA7tLsJlGiHb91gNzLWO8kw5WEOF4RDa6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633469; c=relaxed/simple; bh=Zjbt+MNN20b1ZhpPOOtZM8/Igifx4iU2KQHUcp+BhAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cEh8R/Fk8pQOTuordpd+urdF1rqVxFPSvXl6oIiewmAiZ1w98wMGmqYA9fuOfia3dF1Foqhu9+KIUImHUdXCNfSwg9sa7lvfLlRUtt5pWSadDV3QzOnlXBYAWmI9XIAKs7tYltCBT0ivGRUR72INttUYMZsm2GEbMR4yLc+Td0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h3GB6D6n; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h3GB6D6n" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-81e8b1bdf0cso3151328b3a.3 for ; Mon, 09 Feb 2026 02:37:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633469; x=1771238269; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lOJlBBmeTmihfWXAZmaRsMgXk3WY7j4I4ECMpqKaiiM=; b=h3GB6D6nSdXSVxLBDl6F4EpLZYsYEaOnUz5eKW6wOP96SLHCbrpMHwGbfkCAtukgwA 6t3MzxQeltvdy+tVIgefGwM+VD7FHBjnkY84XguvRIKQOhtbOvu4gP/tolXgbSiZ+f8W BIcpf/8kYO3YQpCxdoXzvdXNGV/ZWcEKXXvcbXJzJkonU0sT+Vb6qX5BllifTCPDcKmG v4MrthSMMwA2wIQOmFu46QHTYD6Bg5QMs5ebylkv4PGcEVE6+/VNuSwOfB6jUg2RWBAw Zy+qnSJoEoS7Dmqf500e+68wW86aY7JX7PykLx25CGN4XmWWM1J+d0Wq70/NXQy1P06b tC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633469; x=1771238269; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lOJlBBmeTmihfWXAZmaRsMgXk3WY7j4I4ECMpqKaiiM=; b=HVXIUxRJaZZT9TDHYTYxFbrJSBicuAooDA4YqvapXQT+mawQuwhJL3NwYTKDWcQ7cJ FyVguhX8OxHdE0qMeChYtBxEh4EffofQ+E1FYcMhmA/SMiac4qEZpwym0kHwDXdvt3yR +Jnhlf2mArBxkNSZ5um8CPIPrKGCeKYU9Lzql2x5ge2LIld5YdRXcKjNJw7StN3dPq9p qbzUyDI5tqoJc8nxDUzlPqxKeIZ45IS43HVrqaaxz7Wjdh/HXUEBURcwCQhtkj3WbYgb Xh/eQ8qFSlh1TLd+ZLlr5xAt5WCIa50OZD3Q7WVILg/Oq9Ozvxn/0lEfRyV5duo2Hnzw Jsdg== X-Forwarded-Encrypted: i=1; AJvYcCXlVlq92+uP5dn+HH5g4WI1BMR+EnMzR/wIeaIiFvN5+mqzyPc89UfrO4eaTaXR9KAWTgu/cYW8mJM97Nc=@vger.kernel.org X-Gm-Message-State: AOJu0YyGWEiwwOrRIe7R0tFTkChvSnrwooYvf9XuulafzGh9iV5kJu3o kS9YuRF+eplrYjg+oMovndR/4gKkOuIHhUMzNu+ggeZx6FZ4eZq9d2Y4 X-Gm-Gg: AZuq6aLgoCT1m2SYGeHdInMsGqIF/0SY7ZOmnQdE0cBOKYzzsETWnMMUu6LG77pP3lN 5VP+/kzp0uXmm6URWRUFgfFwiGdYHCId5f8I1zD1fW4yq81m2BuQKv2oYhsj6E8/Gkq8s+2YqpK n2bzFtPnUZPBi2PKlX2Ly5sDVODwLEpZjznsqvjnlxWhTCfyr3yWalmV5DEQB6jmYUSuTBNYQft 1yFkEbme7YnLzsyz64jWITlJqi9OOF0lgGs22bdCeBBa/GarJHPkA2m3NQHDDPxwmzd0kC0cxjp Qtu9lEJP8W/XcHYTIxQIgCJ3IwnDylFFQM/T1C9up+shrOPqR+emdJ0OJYwShpml89UBRlj4TJA eR0bG415rzoKBQElnTsqoxYLR6yOF8EjbAGGPGqy0Dzuu48ha3AkJSFjVVDeNUvBojWq8kNe6+2 EvoIaq0ciPCEwDBUOgC70FIqba9w4ZdtichgY= X-Received: by 2002:a05:6a00:2d9a:b0:81f:c6d1:ec6a with SMTP id d2e1a72fcca58-824416f8993mr9058480b3a.45.1770633468688; Mon, 09 Feb 2026 02:37:48 -0800 (PST) Received: from localhost.localdomain ([171.88.165.217]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8244166f6dfsm10428558b3a.2.2026.02.09.02.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:37:48 -0800 (PST) From: Shi-Shenghui X-Google-Original-From: Shi-Shenghui To: Frank.Li@nxp.com, vkoul@kernel.org Cc: manivannan.sadhasivam@linaro.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, brody.shi@m2semi.com, kevin.song@m2semi.com, qixiang.zhong@m2semi.com, tom.hu@m2semi.com, richard.yang@m2semi.com Subject: [PATCH v7] dmaengine: dw-edma: fix MSI data programming for multi-IRQ case Date: Mon, 9 Feb 2026 18:37:25 +0800 Message-ID: <20260209103726.414-1-brody.shi@m2semi.com> X-Mailer: git-send-email 2.49.0.windows.1 In-Reply-To: <20260209093642.273-1-brody.shi@m2semi.com> References: <20260209093642.273-1-brody.shi@m2semi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Shenghui Shi When using MSI (not MSI-X) with multiple IRQs, the MSI data value must be unique per vector to ensure correct interrupt delivery. Currently, the driver fails to increment the MSI data per vector, causing interrupts to be misrouted. Fix this by caching the base MSI data and adjusting each vector's data accordingly during IRQ setup. Fixes: e63d79d1ff04 ("dmaengine: dw-edma: Add Synopsys DesignWare eDMA IP core driver") Signed-off-by: Shenghui Shi --- drivers/dma/dw-edma/dw-edma-core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index 8e5f7defa6b6..22d906426d75 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -844,6 +844,7 @@ static int dw_edma_irq_request(struct dw_edma *dw, { struct dw_edma_chip *chip = dw->chip; struct device *dev = dw->chip->dev; + struct msi_desc *msi_desc; u32 wr_mask = 1; u32 rd_mask = 1; int i, err = 0; @@ -895,9 +896,12 @@ static int dw_edma_irq_request(struct dw_edma *dw, &dw->irq[i]); if (err) goto err_irq_free; - - if (irq_get_msi_desc(irq)) + msi_desc = irq_get_msi_desc(irq); + if (msi_desc) { get_cached_msi_msg(irq, &dw->irq[i].msi); + if (!msi_desc->pci.msi_attrib.is_msix) + dw->irq[i].msi.data = dw->irq[0].msi.data + i; + } } dw->nr_irqs = i; -- 2.49.0.windows.1