From: Siwanan Bungtong <horstaufmental@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Siwanan Bungtong <horstaufmental@gmail.com>
Subject: [PATCH 7/7] staging: rtl8723bs: ioctl_cfg80211: remove unnecessary void * casts
Date: Tue, 10 Feb 2026 06:51:33 +0700 [thread overview]
Message-ID: <20260209235133.1292161-8-horstaufmental@gmail.com> (raw)
In-Reply-To: <20260209235133.1292161-1-horstaufmental@gmail.com>
Remove redundant (void *) casts when calling memcpy/memset and
other helpers. These casts are unnecessary since C implicitly
converts to void * and they only add noise.
No functional change.
Signed-off-by: Siwanan Bungtong <horstaufmental@gmail.com>
---
.../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 60edeae1cffe..a0f9844e17d9 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -93,7 +93,7 @@ static struct ieee80211_channel rtw_2ghz_channels[] = {
static void rtw_2g_channels_init(struct ieee80211_channel *channels)
{
- memcpy((void *)channels, (void *)rtw_2ghz_channels,
+ memcpy(channels, rtw_2ghz_channels,
sizeof(struct ieee80211_channel) * RTW_2G_CHANNELS_NUM
);
}
@@ -894,7 +894,7 @@ static int cfg80211_rtw_add_key(struct wiphy *wiphy, struct net_device *ndev,
ret = rtw_cfg80211_set_encryption(ndev, param, param_len);
} else if (check_fwstate(pmlmepriv, WIFI_AP_STATE) == true) {
if (mac_addr)
- memcpy(param->sta_addr, (void *)mac_addr, ETH_ALEN);
+ memcpy(param->sta_addr, mac_addr, ETH_ALEN);
ret = rtw_cfg80211_ap_set_encryption(ndev, param, param_len);
} else if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true
@@ -1737,7 +1737,7 @@ static int cfg80211_rtw_connect(struct wiphy *wiphy, struct net_device *ndev,
pwep->key_index = wep_key_idx;
pwep->key_index |= 0x80000000;
- memcpy(pwep->key_material, (void *)sme->key, pwep->key_length);
+ memcpy(pwep->key_material, sme->key, pwep->key_length);
if (rtw_set_802_11_add_wep(padapter, pwep) == (u8)_FAIL)
ret = -EOPNOTSUPP;
@@ -2086,7 +2086,7 @@ static netdev_tx_t rtw_cfg80211_monitor_if_xmit_entry(struct sk_buff *skb, struc
pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET;
- memcpy(pframe, (void *)buf, len);
+ memcpy(pframe, buf, len);
pattrib->pktlen = len;
pwlanhdr = (struct ieee80211_hdr *)pframe;
@@ -2261,8 +2261,8 @@ static int rtw_add_beacon(struct adapter *adapter, const u8 *head, size_t head_l
if (!pbuf)
return -ENOMEM;
- memcpy(pbuf, (void *)head + 24, head_len - 24);/* 24 =beacon header len. */
- memcpy(pbuf + head_len - 24, (void *)tail, tail_len);
+ memcpy(pbuf, head + 24, head_len - 24);/* 24 =beacon header len. */
+ memcpy(pbuf + head_len - 24, tail, tail_len);
len = head_len + tail_len - 24;
@@ -2299,9 +2299,9 @@ static int cfg80211_rtw_start_ap(struct wiphy *wiphy, struct net_device *ndev,
struct wlan_bssid_ex *pbss_network = &adapter->mlmepriv.cur_network.network;
struct wlan_bssid_ex *pbss_network_ext = &adapter->mlmeextpriv.mlmext_info.network;
- memcpy(pbss_network->ssid.ssid, (void *)settings->ssid, settings->ssid_len);
+ memcpy(pbss_network->ssid.ssid, settings->ssid, settings->ssid_len);
pbss_network->ssid.ssid_length = settings->ssid_len;
- memcpy(pbss_network_ext->ssid.ssid, (void *)settings->ssid, settings->ssid_len);
+ memcpy(pbss_network_ext->ssid.ssid, settings->ssid, settings->ssid_len);
pbss_network_ext->ssid.ssid_length = settings->ssid_len;
}
@@ -2494,7 +2494,7 @@ static int _cfg80211_rtw_mgmt_tx(struct adapter *padapter, u8 tx_ch, const u8 *b
pframe = (u8 *)(pmgntframe->buf_addr) + TXDESC_OFFSET;
- memcpy(pframe, (void *)buf, len);
+ memcpy(pframe, buf, len);
pattrib->pktlen = len;
pwlanhdr = (struct ieee80211_hdr *)pframe;
--
2.52.0
prev parent reply other threads:[~2026-02-09 23:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 23:51 [PATCH 0/7] staging: rtl8723bs: remove unnecessary void pointer casts Siwanan Bungtong
2026-02-09 23:51 ` [PATCH 1/7] staging: rtl8723bs: rtw_ap: remove unnecessary void * casts Siwanan Bungtong
2026-02-10 2:37 ` Ethan Tidmore
2026-02-10 5:00 ` Greg KH
2026-02-10 5:21 ` Ethan Tidmore
2026-02-09 23:51 ` [PATCH 2/7] staging: rtl8723bs: rtw_efuse: " Siwanan Bungtong
2026-02-09 23:51 ` [PATCH 3/7] staging: rtl8723bs: rtw_ieee80211: " Siwanan Bungtong
2026-02-09 23:51 ` [PATCH 4/7] staging: rtl8723bs: rtw_mlme_ext: " Siwanan Bungtong
2026-02-09 23:51 ` [PATCH 5/7] staging: rtl8723bs: rtw_security: " Siwanan Bungtong
2026-02-09 23:51 ` [PATCH 6/7] staging: rtl8723bs: rtl8723b_hal_init: " Siwanan Bungtong
2026-02-09 23:51 ` Siwanan Bungtong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260209235133.1292161-8-horstaufmental@gmail.com \
--to=horstaufmental@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®