From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E68D813D638 for ; Tue, 10 Feb 2026 17:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770745474; cv=pass; b=bRUvS0ZV9ppzZ/P7OAcyUzYAiR82ZCoGBwEwjCT43brOVN5VDN8ElxqOILBJlzp38hXf6/oikHk8xhmj+xyx/n1VtrpGbpPsBgID8GtOVvdS36BjYl8gJ9cAFp6UBwPnZiV9ywizoSK52v6gRPSuqDaGPsqU9bY3Yu4NzWvNqz8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770745474; c=relaxed/simple; bh=8eXdw9IMnvviHBd51HjjaDqBFrLTMAvRj6Edq91IDyk=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=nGOjOPWRyZSxhkXXiRvQeI1ohIuaOYhnZwyAC7OfOySVxajubkFHgwH14t06SbiYuxxr2kU/4/xD+obL9a2grkrHhDGwFZtAY+izBwOh+5gEQ/ldKNim7jc6d/gjZ3FVAgrYKfWPkGQzd1gfD4rIahKaDZVmRV6zgpRGpTvouik= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b=OkLhmIXu; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=ariel.dalessandro@collabora.com header.b="OkLhmIXu" ARC-Seal: i=1; a=rsa-sha256; t=1770745453; cv=none; d=zohomail.com; s=zohoarc; b=h0Adducs1Zi5wPfbd5aSBQsdRLp5SylY2PacQlT5211qm04OF+gqXOvFgK1+U8Zn+yUY+Argw9fU9dyZjw1dQb09fYePdgEFiU4T/Vhy65uxnw5oDI777siru7nlquyntGfHGD1p7OjFV7RWUbO184p+GYbyRzuxx3VwPUN8RzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770745453; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=QWsNiC+QFoLc5WceTaLYGAIKhlik7N8ndqcYMmie4ug=; b=h3P7UU5LJa9Ji0ECjRffbjwSFNXhAZObSWyFFZm0Vcpu15Tj0HCo9abZwapzcsTzicexMWQiYTaKgfb+rcTXph06T5jEKoZAl1zz1BRhGKFNdol7e9rFz1S2vXmeGDBroPF3jFjmB4Ltn8IfhKF4kBX34jWdKxAIqmCYjYzZfYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=ariel.dalessandro@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1770745453; s=zohomail; d=collabora.com; i=ariel.dalessandro@collabora.com; h=From:From:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:To:To:Cc:Cc:Reply-To; bh=QWsNiC+QFoLc5WceTaLYGAIKhlik7N8ndqcYMmie4ug=; b=OkLhmIXuByc5Sy+lS8av2gEZGDPJCTNiVK7JiCtJZ1fcm4PpzMzBi6YKazsWwyPE MInMKMIZtpLTWp5Vdp5POuqH5OK4BM2cdNTpwMapQ2fiq8ufWLsrhc3nJLzKXLYAoTs 6wntq3blK20+/fQbPPptgWXu0S3GAynuowJMd3rc= Received: by mx.zohomail.com with SMTPS id 1770745452102862.1193155909192; Tue, 10 Feb 2026 09:44:12 -0800 (PST) From: Ariel D'Alessandro Subject: [PATCH v2 0/2] drm/vkms: Fix bad matrix offset component multiplication Date: Tue, 10 Feb 2026 14:43:59 -0300 Message-Id: <20260210-vkms-composer-fix-matrix-v2-0-d1ed09cb23e8@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAF9ui2kC/4WO0Q6CMAxFf4X02ZltOM188j8MDwOLLDKG21wwh H+3wAeYPjS37bm3M0QMFiNcixkCZhutH0jIQwFNZ4YnMvsgDZJLJaQsWX65yBrvRk8ka+3EnEm BmjGyUbpsT0ooIHwMSNvN+l7tOuD7QwlpH0JtIq5WzqZrMeCU2J4iNKxAZ2Py4bu9lsVG/P8iC 0bFjb5o5GfJ9a3xfW9qH8yR7qFaluUH2aSrx/UAAAA= X-Change-ID: 20251223-vkms-composer-fix-matrix-aa2c593f4515 To: Louis Chauvet , Haneen Mohammed , Simona Vetter , Melissa Wen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nfraprado@collabora.com, pekka.paalanen@collabora.com, daniels@collabora.com, kernel@collabora.com, Ariel D'Alessandro X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770745445; l=1456; i=ariel.dalessandro@collabora.com; s=20251223; h=from:subject:message-id; bh=8eXdw9IMnvviHBd51HjjaDqBFrLTMAvRj6Edq91IDyk=; b=H6ZaVo6Rndwd5UaHqIl7GIczmjrEEi60FA8yHyI/7leiVhUfQ5Acb1vhqcAhaconX2aQP607a U8knZbyUAcgBokv7ye1J+B3sN+Drznr7hm6/XDOWy+dYqhT/8pmDwx4 X-Developer-Key: i=ariel.dalessandro@collabora.com; a=ed25519; pk=QZRL9EsSBV3/FhDHi9L/7ZTz2dwa7iyqgl+y1UYaQXQ= X-ZohoMailClient: External This patch series fixes a bug in the 3x4 matrix multiplication for BT709 enconding/decoding, where the offset component if not handled properly. Currently, BT.709 encoding matrix kunit tests don't cover the offset component multiplication, so a new set of tests is added. The bug was found while working on the IGT tools CRTC (post-blend) color pipelines, see submitted patchset [0] (patch [1] in particular) for the full context. [0] https://lore.kernel.org/igt-dev/20251223-post-blend-colorops-v2-0-f40aca9795bd@collabora.com/ [1] https://lore.kernel.org/igt-dev/20251223-post-blend-colorops-v2-7-f40aca9795bd@collabora.com/ Signed-off-by: Ariel D'Alessandro --- Changes in v2: - Added kunit tests for alternative BT709 encoding matrix. - Link to v1: https://lore.kernel.org/r/20251223-vkms-composer-fix-matrix-v1-1-10a979e06209@collabora.com --- Ariel D'Alessandro (2): drm/vkms: Fix bad matrix offset component multiplication drm/vkms: Add kunit tests for alternative BT709 encoding matrix drivers/gpu/drm/vkms/tests/vkms_color_test.c | 146 +++++++++++++++++++++++++++ drivers/gpu/drm/vkms/vkms_composer.c | 13 ++- 2 files changed, 156 insertions(+), 3 deletions(-) --- base-commit: b96bcfba104c65db41378a04f5ccac186f79578f change-id: 20251223-vkms-composer-fix-matrix-aa2c593f4515 Best regards, -- Ariel D'Alessandro