From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9862E3815E2 for ; Tue, 10 Feb 2026 15:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735616; cv=none; b=ma3+HS1wN3kTmYrAjLddee2Ibq9jkAszeZuhmhJEXSniKVHxfUbU5fZ0WnLPaaOvneCvXl7c5n/fG/Vx578KkcOgAi68w9+8vlVU2iD0FBWymf3Jt2EPXCLF42mTQru5oytkWl+pEVcDgZROitbg6uC9AOYJq1opm3Qo9gnCmds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770735616; c=relaxed/simple; bh=P5N4ABjZx124VekI186qd2AD4yXfKDQt9Vo1Fag6vHg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z18pP9U+H44Ha5yO5hAn+SSbhybtyHntLZxp2ptlyMRiC21Fv1a+Gn9nb7o1lcb8ul5VXvBiVXGbH14t0fpOSf6MsJraBNmur0gaAtH1JD258QyuQZIGJC/pzZvR4peecagmLhgSsAb5b6/IAVrvc6hYD+/e6M8X3tXOeb5DopA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gFoRBQUK; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gFoRBQUK" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a871daa98fso29236155ad.1 for ; Tue, 10 Feb 2026 07:00:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770735614; x=1771340414; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v436SyFigxsHrmhj471D+104SnMzTMwy4MIHa73zImY=; b=gFoRBQUKg+Jbo78iDrELjJ0UCZCUblkzS9MxRPdPYY/sbzRniiq1YIPrnkjYGTzhe/ 22vgvcKY9UueLO/JyQz19mU9CeAdK05ffCOZyY2NXjSSm9wQ6j1P3zvo4pjttVaYo9bJ 8NYcXQQTnYonQTIlzzRdwR3DHf8b1HIS+cvuWnXROFtqohoGlfkmfQHL52rr0It3rXsp ILYBHiGc9WK0eIJMjup0tl3t90UmZ0msyQAAtcrZN26Wh4cBlyvoff/bZhCQ+eoIKTI7 sdqK3T9oqX4LaxhgNT9KrmcFAFudrlMSOEmRylnCa6AzZvWcMHmd82YrdsAHkIrfjNm/ I97Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770735614; x=1771340414; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v436SyFigxsHrmhj471D+104SnMzTMwy4MIHa73zImY=; b=Xc1TZt58EjruZHqZzcHI2AuOenv7EUz61vU7wsS2XAhDe50IN93ziDCcJAxlBtubbY lZqW3hH/XnAmEZk/y3pbMp2ueOgtznl1Hgen8vdRLE2S9TtPIoxjp3AvEGCC1ONW4v7S Neb2g5cTJWLsDJR8Es/tKia0tImz7BdEhTlTHvqhaQLcYbrpuhc9KD+B3OPpVr3NnQWe RmGRDcOOa4oH3J0nihN86AKcKabYv3tw1D2iYd2H88ZwWb4gazceAszRIqn0HwvLeb0P QNhx61Vqg4XfX7cOPabwY9NP4bZKmJb+gzkppk45gOUmzufHj22ntRvy5nOU+QM0FmmM e3Aw== X-Forwarded-Encrypted: i=1; AJvYcCUatkyuslaC9t66Kor9zjFjyPggDq1nMkJ/4y3gadtt7KoV+MER7zwtazgQX+aeNoFafG5ibcibLTIOMVw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9xLr3GGdxiFmlOnuMaGEubfOrTGe9k5jbAGZ6mZ5H0Yqtucbg NJjr4ADatAgU6VTX2RApqvSQdWl2rZAVE0wLPaJEh91P4umRByrG3oYw X-Gm-Gg: AZuq6aKEIlyDx1w4jqi0mFiH35Y3PUgDQOvr0WHF4upczDDQD6A971Ca0ZDAbgntClq 3TgiLeDQpRDAaoabMBegQKRgnK5VUqhtKE0ndefxgmvekyT2ZXY4syE5qP4U9aRHb8JN5u1Hwz5 ahrlq9xroXSYWQXuoDJwu4NrMeH+03kxvLkuMf2hZkEzAQDNTP7cJ75/Cs5T69eIkWz1kZ7gGpt exxAMEWKv5H9ueMQENk6Iw7HS2Tl0kCbxybucEEJ/YSk3LYlFGBNyXGzG1MulB/Gil6KWuQJOo3 sDNnJPqnTQrt9P2olL/WuQe9gII0M4aSl2R1XSA9Qdm4OT86//lrWzZqUy7E6Rrvb1Wr/X7x2/U 15CiPTVD22FdIufL3sUInLs/eU9SjjtByoa858WlNAn9Y6TKYd6GGrGg2kihapZl09ophLwIm86 Eu8/T+7pxxi/689Cdq3hSO83u6r9QQ6U2Dqw== X-Received: by 2002:a17:902:e742:b0:2a0:d629:9035 with SMTP id d9443c01a7336-2a951643629mr163927435ad.3.1770735613704; Tue, 10 Feb 2026 07:00:13 -0800 (PST) Received: from inspiron ([111.125.237.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aa3ec42e2asm149045835ad.53.2026.02.10.07.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 07:00:13 -0800 (PST) Date: Tue, 10 Feb 2026 20:30:03 +0530 From: Prithvi To: Al Viro Cc: martin.petersen@oracle.com, d.bogdanov@yadro.com, bvanassche@acm.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, syzbot+f6e8174215573a84b797@syzkaller.appspotmail.com, stable@vger.kernel.org Subject: Re: [PATCH v3] scsi: target: fix recursive locking in __configfs_open_file() Message-ID: <20260210150003.s55mbwdpgbamjtso@inspiron> References: <20260205162624.117957-1-activprithvi@gmail.com> <20260205192644.GT3183987@ZenIV> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260205192644.GT3183987@ZenIV> On Thu, Feb 05, 2026 at 07:26:44PM +0000, Al Viro wrote: > On Thu, Feb 05, 2026 at 09:56:24PM +0530, Prithvi Tambewagh wrote: > > > + r = kern_path(db_root_stage, LOOKUP_FOLLOW, &path); > > + if (r) { > > pr_err("db_root: cannot open: %s\n", db_root_stage); > > goto unlock; > > } > > - if (!S_ISDIR(file_inode(fp)->i_mode)) { > > - filp_close(fp, NULL); > > + if (!d_is_dir(path.dentry)) { > > + path_put(&path); > > pr_err("db_root: not a directory: %s\n", db_root_stage); > > + r = -ENOTDIR; > > goto unlock; > > } > > - filp_close(fp, NULL); > > + path_put(&path); > > Just pass it LOOKUP_FOLLOW | LOOKUP_DIRECTORY and be done with the manual > "is it a directory" tests in any form... Hello Al, I sincerely apologise for the delayed response. I was testing the change you suggested, however, whenever I tried testing my patch against the latest commit where syzbot reported this bug (commit 3a8660878839faadb4f1a6dd72c3179c1df56787 of upstream repository) it gave me a build failure immediately without any debug log, just the message: syzbot tried to test the proposed patch but the build/boot failed: failed to run ["make" "KERNELVERSION=syzkaller" "KERNELRELEASE=syzkaller" "LOCALVERSION=-syzkaller" "-j" "48" "ARCH=x86_64" "bzImage"]: exit status 2 The issue seems to occur multiple times when a patch is tested against the latest commit where syzbot reported the issue while it doesn't occur on that latest commit of the upstream repository. However, testing the change on the latest commit of upstream reprository (commit 72c395024dac5e215136cbff793455f065603b06) gives a positive result that the reproducer doesn't trigger any issue. Reference: https://lore.kernel.org/all/6767d8ea.050a0220.226966.0021.GAE@google.com/T/#mbf32aeb54c4cae609d3b6176ad8dcd99bfc51ad2 IIUC, since the reported failure appears to be unrelated to the change and is working successfully on latest commit of upstream, I wanted to confirm if v4 based on these findings is acceptable. What do you think? Thank you, Prithvi