From: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, ming.lei@redhat.com,
muchun.song@linux.dev, mkhalfella@purestorage.com,
sunlightlinux@gmail.com, chris.friesen@windriver.com,
stable@vger.kernel.org, ionut_n2001@yahoo.com,
bigeasy@linutronix.de, ionut.nechita@windriver.com
Subject: [PATCH v2 0/1] block/blk-mq: fix RT kernel regression with dedicated quiesce_sync_lock
Date: Tue, 10 Feb 2026 22:49:44 +0200 [thread overview]
Message-ID: <20260210204943.21709-3-ionut.nechita@windriver.com> (raw)
Hi Jens,
This is v2 of the fix for the RT kernel performance regression caused by
commit 679b1874eba7 ("block: fix ordering between checking
QUEUE_FLAG_QUIESCED request adding").
Changes since v1 (RESEND, Jan 9):
- Rebased on top of axboe/for-7.0/block
- No code changes
The problem: on PREEMPT_RT kernels, the spinlock_t queue_lock added in
blk_mq_run_hw_queue() converts to a sleeping rt_mutex, causing all IRQ
threads (one per MSI-X vector) to serialize. On megaraid_sas with 8
MSI-X vectors, throughput drops from 640 MB/s to 153 MB/s.
The fix introduces a dedicated raw_spinlock_t quiesce_sync_lock that
does not convert to rt_mutex on RT kernels. The critical section is
provably short (only flag and counter checks), making raw_spinlock safe.
In past used memory barriers but was rejected due to barrier pairing
complexity across multiple call sites (as noted by Muchun Song).
Ionut Nechita (1):
block/blk-mq: fix RT kernel regression with dedicated
quiesce_sync_lock
block/blk-core.c | 1 +
block/blk-mq.c | 27 ++++++++++++++++-----------
include/linux/blkdev.h | 6 ++++++
3 files changed, 23 insertions(+), 11 deletions(-)
--
2.52.0
next reply other threads:[~2026-02-10 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 20:49 Ionut Nechita (Wind River) [this message]
2026-02-10 20:49 ` [PATCH v2 1/1] " Ionut Nechita (Wind River)
2026-02-10 21:39 ` Keith Busch
2026-02-11 7:28 ` Ionut Nechita (Wind River)
2026-02-11 11:31 ` Sebastian Andrzej Siewior
2026-02-11 0:18 ` [PATCH v2 0/1] " Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210204943.21709-3-ionut.nechita@windriver.com \
--to=ionut.nechita@windriver.com \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=chris.friesen@windriver.com \
--cc=ionut_n2001@yahoo.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkhalfella@purestorage.com \
--cc=muchun.song@linux.dev \
--cc=stable@vger.kernel.org \
--cc=sunlightlinux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®