From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f49.google.com (mail-dl1-f49.google.com [74.125.82.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 834DB1946BC for ; Tue, 10 Feb 2026 22:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770762455; cv=none; b=UEM20AmMKRMNSBmyBTmtArF9PNqpO8zADUlT5BZWexzPDzojsq5y2t7airV+NLgAeuVbxWq8gxJ9fjwbCB0C02mgJZkTDmhvTBG2fKYGInVuvcsAD1rFiuLjIsKFNFR8vx0RiLdA3x6jdH4N6brfpOtBQiTBDlb4I3lAGLPJ/HE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770762455; c=relaxed/simple; bh=er54z/O8x8xByIeZj1av48NG3wfQshzgiI4M+1kunI0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uetj4pwlaXLLcPO43ug8u0mNHXF4Lg+pEmHTOG8KlXKP2njwXRhuVvfzI32xXti3fuIbb6GoWpmPZ5RkpjkHyL/Od2b9U/wGWOiX+ljURvTHfpBhcHM6sI5uS1h0CX37i4YfBUwzpg8MyUhxWw7Db/F2qjSRRCQI1Gqme4iti8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=TMOYONna; arc=none smtp.client-ip=74.125.82.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="TMOYONna" Received: by mail-dl1-f49.google.com with SMTP id a92af1059eb24-1271257ae53so1659729c88.1 for ; Tue, 10 Feb 2026 14:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1770762453; x=1771367253; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M/zMFrnCoe6Q9Z9tEuHYY0LJcYdBtncX2gTW0r5E/X8=; b=TMOYONnajdQrwSyf5grfJPm03cOY4poyH18CjwNiS7q8PsAi9qvctzflVESNWtZbMp pTpLc0gDYoFQVlRuw+gl4zlrrMd5zDPSwkjt9wUoG11vYiICui1fAi876fJXLZqC8r64 tLtoyNItiIqKFitCBA86KilRph73BawiYt2oiIv+aZcgH1XuvZev4Pm9eZyancD5uJJ3 DZGnsh0wxNTTIhl8hk7JW2bDknPNsrg+cbo6v24sVopVo+m/NYZjuw8016fkuERdydCz x2gB9JVYMQrGDbYCsR0qPCCYFmk+kd5LOrzUh+1PPE8BOSMsiw15Mzpew6//O3813w3m F2ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770762453; x=1771367253; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M/zMFrnCoe6Q9Z9tEuHYY0LJcYdBtncX2gTW0r5E/X8=; b=paAUKavaGjslhGDF/VxDlpvXxsB2tbXnLHK1QsF1E0ojBsl+XtxBB5Dac8QWm+Ymz3 iBpERKxiaq2sdED49c+sZHkpD6L4zkdbuZUnkVnJDR84GBnn3C02xnwU71tO3O1rZLnl jGia7v/1BkyTG8jRXXNRT8neiq+47l2U7smVCAjKHfCeP/fBygKUgXZwkS9nxq/pQokF Cqe4+9PPNUk8Mfri31p7nlDflcgT2OL7eKrli9Ghyqr4pzaE7iCpZJCu7Zn88IvFODqS vMeUYAH5tqA+n9xnGPQXMLl3QE++vvoN57ij3EiVy6CYkN9LGB6jAefS+RRyx3B5lXLJ 7FCQ== X-Forwarded-Encrypted: i=1; AJvYcCXbEhsYoTmx6Rbm8pAOJXi9mWQ7eE/p8O+tfmK8Trnp87opOUgb2MfEo1VN6rC8Pa3WEF/NqqyggSFcp1I=@vger.kernel.org X-Gm-Message-State: AOJu0YwLqJNkVVE0owzZfrWfRAg0mr0k8C9zRpZkonEbzLE5sSwPilFR IKtLjKpiNoR8tSzicFlF0fceo4fSPJMStw+4WlSi0YzfpQqOqhuOI2yIkr6tm+3/goQ= X-Gm-Gg: AZuq6aI9ypxWSNgN91WHdLNT1/Lkznq+cNYRTfxRY4AmdJV4qH3l/uafu6ccuzPxIwp a3LQUClRrPnR4RD0ZGmamZEujvCjb0R+mnv0dVE/vwDGeWmAMtju/qKJtKZFfZEUGZ2RK4f18I2 8Nio3o7nh0c+487ia+q4+MCl84cWRVGRyf91gVPClCPI+mlRiPRaWSvo2Fg9/CcVqzybgVxwZ+Q MDs1RnHmYhtFwXEDAzOLmlN3JdLlJi3Vgx7/y3DZChaHLT37NGHXMo1Tp3tbI588CfJeo3XkDeL Dnkf3WIUY5g3b8IKnTewbAWGgyFM9MC85wRA+i8UcFShakClqWgSf/rlcaxHBeFXNNC6kEvIHNE tIE/GL4++gnMfY1vpXuVR89RcFowlaD8jAHqwTWYojVepumm1YBVescN6nlsCUB5GYdYSlmGwu/ kHHqY8q6kuP1E6Y5Rg/LFp93ZqU0UikRqwDAvxlYEGIfg7kMAfrulcAA== X-Received: by 2002:a05:7022:248f:b0:119:e55a:9bf5 with SMTP id a92af1059eb24-1270401d549mr7403051c88.17.1770762453401; Tue, 10 Feb 2026 14:27:33 -0800 (PST) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id a92af1059eb24-12706faa047sm10658404c88.14.2026.02.10.14.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 14:27:33 -0800 (PST) Date: Tue, 10 Feb 2026 14:27:32 -0800 From: Mohamed Khalfella To: James Smart Cc: Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Sagi Grimberg , Aaron Dailey , Randy Jennings , Dhaval Giani , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 08/14] nvme: Implement cross-controller reset recovery Message-ID: <20260210222732.GQ3729-mkhalfella@purestorage.com> References: <20260130223531.2478849-1-mkhalfella@purestorage.com> <20260130223531.2478849-9-mkhalfella@purestorage.com> <05875e07-b908-425a-ba6f-5e060e03241e@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05875e07-b908-425a-ba6f-5e060e03241e@gmail.com> On Tue 2026-02-10 14:09:27 -0800, James Smart wrote: > On 1/30/2026 2:34 PM, Mohamed Khalfella wrote: > ... > > +unsigned long nvme_fence_ctrl(struct nvme_ctrl *ictrl) > > +{ > > + unsigned long deadline, now, timeout; > > + struct nvme_ctrl *sctrl; > > + u32 min_cntlid = 0; > > + int ret; > > + > > + timeout = nvme_fence_timeout_ms(ictrl); > > + dev_info(ictrl->device, "attempting CCR, timeout %lums\n", timeout); > > + > > + now = jiffies; > > + deadline = now + msecs_to_jiffies(timeout); > > + while (time_before(now, deadline)) { > > Q: don't we have something to identify the controller's subsystem > supports CCR before we starting selecting controllers and sending CCR ? > > I would think on older devices that don't support it we should be > skipping this loop. The loop could delay the Time-Based delay without > any CCR. I do not think we have something that identifies CCR support at subsystem level. The spec defines CCRL at the controller level. The loop should not that bad. nvme_find_ctrl_ccr() should return NULL if CCR is not supported and nvme_fence_ctrl() will return immediately. > > -- james >