From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAED086277 for ; Tue, 10 Feb 2026 11:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770723288; cv=none; b=oivbFKSDNgWcsdz3hDTy8S3pwfXcgcxkgSNsbRHI0RFmmUQmlp7bLTjTjkfnnant8GP8vOxSr2y+IGo+JsoVddAulBFLBj8xCa3Ammn1F4r/ie0vHTIbaPFeh3bIt6RdZVPOB3JPy3NNdhjjC6p5NRasYneFOdYWDFeBb9jK0uE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770723288; c=relaxed/simple; bh=LIZGLVzAtKY4eG08TLkoHF3u8fpfEzdGlD00SWSZZRs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m6QLJEoj4R4TvLaUa249Xr+HW+YQYtO5Tbhh/WjENprmFojbztoumXiX0aMyzrDTjLnI7KPPs752fk2WeoHhD7MpYl07lPIXjZyN9Yu0Ks5DHMhKkNMFcRY+LdY4l4CNXj7JxpzsSup8NIN3aLCaUruov4ij5O24zpghBc1pRY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=gixFV//b; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=PVwc0Ufl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=gixFV//b; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=PVwc0Ufl; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gixFV//b"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PVwc0Ufl"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="gixFV//b"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="PVwc0Ufl" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 393805BD45; Tue, 10 Feb 2026 11:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770723284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfn2qjL1D8vXXgggI0IUON3J0sqZ4k9eIkuYo3kYIws=; b=gixFV//bAGobWLq1KIPX6Xlq46VQ5gCQ7bw7u3V5XGU3xVgt0jX4VbrUu2vSbpgxh+df7f oDA1ipDmThOsVe0QIhgnGO+5KVzNoARsTiAakdxc/qjI0rPWyUGrHIyhTjHmae3mmidvpr 6PUsjEMUgXEtMk8fWJmQhMeFsxoBH7c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770723284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfn2qjL1D8vXXgggI0IUON3J0sqZ4k9eIkuYo3kYIws=; b=PVwc0UflLaNH3Axqd8dUReYaoMdwolFcEk96sDVhSkZ9GY6RDmdy1kr8zRR7JZv+MQdNcQ vyq7PsBHv9cbGmBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1770723284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfn2qjL1D8vXXgggI0IUON3J0sqZ4k9eIkuYo3kYIws=; b=gixFV//bAGobWLq1KIPX6Xlq46VQ5gCQ7bw7u3V5XGU3xVgt0jX4VbrUu2vSbpgxh+df7f oDA1ipDmThOsVe0QIhgnGO+5KVzNoARsTiAakdxc/qjI0rPWyUGrHIyhTjHmae3mmidvpr 6PUsjEMUgXEtMk8fWJmQhMeFsxoBH7c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1770723284; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfn2qjL1D8vXXgggI0IUON3J0sqZ4k9eIkuYo3kYIws=; b=PVwc0UflLaNH3Axqd8dUReYaoMdwolFcEk96sDVhSkZ9GY6RDmdy1kr8zRR7JZv+MQdNcQ vyq7PsBHv9cbGmBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 81A3D3EA62; Tue, 10 Feb 2026 11:34:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id XRmBDtEXi2lXFAAAD6G6ig (envelope-from ); Tue, 10 Feb 2026 11:34:41 +0000 Date: Tue, 10 Feb 2026 22:34:31 +1100 From: David Disseldorp To: Christian Marangi Cc: Nathan Chancellor , Nicolas Schier , Dmitry Safonov <0x7f454c46@gmail.com>, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-fsdevel@vger.kernel.org" Subject: Re: [RFC PATCH] initramfs: correctly handle space in path on cpio list generation Message-ID: <20260210223431.6bf63673.ddiss@suse.de> In-Reply-To: <20260209153800.28228-1-ansuelsmth@gmail.com> References: <20260209153800.28228-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -3.30 X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_SEVEN(0.00)[7]; MISSING_XM_UA(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,gmail.com,vger.kernel.org]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Flag: NO [cc'ing fsdevel] On Mon, 9 Feb 2026 16:37:58 +0100, Christian Marangi wrote: > The current gen_initramfs.sh and gen_init_cpio.c tools doesn't correctly > handle path or filename with space in it. Although highly discouraged, "highly discouraged" isn't really appropriate here; the kernel generally doesn't care whether or not a filename carries whitespace. The limitation here is specifically the gen_init_cpio manifest format, which is strictly space-separated. > Linux also supports filename or path with whiespace and currently this > will produce error on generating and parsing the cpio_list file as the > pattern won't match the expected variables order. (with gid or mode > parsed as string) > > This was notice when creating an initramfs with including the ALSA test > files and configuration that have whitespace in both some .conf and even > some symbolic links. > > Example error: The error messages don't really add any value here. > To correctly handle this problem, rework the gen_initramfs.sh and > gen_init_cpio.c to guard all the path with "" to handle all kind of > whitespace for filename/path. > > The default_cpio_list is also updated to follow this new pattern. > > Signed-off-by: Christian Marangi > --- > usr/default_cpio_list | 6 +++--- > usr/gen_init_cpio.c | 10 +++++----- > usr/gen_initramfs.sh | 27 +++++++++++++++++++-------- > 3 files changed, 27 insertions(+), 16 deletions(-) > > diff --git a/usr/default_cpio_list b/usr/default_cpio_list > index 37b3864066e8..d4a66b4aa7f7 100644 > --- a/usr/default_cpio_list > +++ b/usr/default_cpio_list > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > # This is a very simple, default initramfs > > -dir /dev 0755 0 0 > -nod /dev/console 0600 0 0 c 5 1 > -dir /root 0700 0 0 > +dir "/dev" 0755 0 0 > +nod "/dev/console" 0600 0 0 c 5 1 > +dir "/root" 0700 0 0 > diff --git a/usr/gen_init_cpio.c b/usr/gen_init_cpio.c > index b7296edc6626..ca5950998841 100644 > --- a/usr/gen_init_cpio.c > +++ b/usr/gen_init_cpio.c > @@ -166,7 +166,7 @@ static int cpio_mkslink_line(const char *line) > int gid; > int rc = -1; > > - if (5 != sscanf(line, "%" str(PATH_MAX) "s %" str(PATH_MAX) "s %o %d %d", name, target, &mode, &uid, &gid)) { > + if (5 != sscanf(line, "\"%" str(PATH_MAX) "[^\"]\" \"%" str(PATH_MAX) "[^\"]\" %o %d %d", name, target, &mode, &uid, &gid)) { This breaks parsing of existing manifest files, so is unacceptable IMO. If we really want to go down the route of having gen_init_cpio support space-separated paths, then perhaps a new --field-separator parameter might make sense. For your specific workload it seems that simply using an external cpio archiver with space support (e.g. GNU cpio --null) would make sense. Did you consider going down that path? Thanks, David