From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8C11B983F for ; Wed, 11 Feb 2026 12:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770813162; cv=none; b=PHDKl+tu0jk2oeHy8WR/QMKDKmdPJDOE/7vW3kNw3O1Mbj0427W2CWBf1ndHfN94ec4nvErWYSV5Yt0U3+8RhS/09xlGJM03+eh0UWcfRj+1S6P4StI7g8SV6xEeWKbsfbQDOXQRwMjZy/dZNYMFfgX69DdH0LMIj+bYzL3rMEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770813162; c=relaxed/simple; bh=KPZEFqB87t2rBUIKQUeiu6xy1f+lMRscLe8C4JBNEpM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rcefstK/vSC7eeNezTNcY5SuVamRRHRkwRt1LLROigDvV39T5tQgq3ZamTFWDT4VPzYE4WBey5h4Jry1flJ8mRj1GEiqf3Ttbden53Vr21pK9slqgxr0a0dD3gHu/hZdJXhrlA21BF9JZpdoUtjM1dhpr60Y/sTHnGTxZshg78c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=a35bSUn8; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="a35bSUn8" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=AJlHlAwBVx/FIfh9aEfWIHI96KrrW5jCmJlWcYeF0cY=; b=a35bSUn89igwmhwOpcr0oWKEQp eqljT4TV3LmiE1c70mOkPj6pvWMTzdK/XI9RSsMlNaqEEavJvPHXBRo8yaphz3R53j0Caf2acUGdT ZWaFE5nJgrp+BRI21Ca2DF+bS4yuA7rI/fmm1BliqiNlcdN3c677nxtFd2cLQWeBZB6Ng6r+c8OCE v5m7tSARFL4L4PbqIyzjYibRozjvWlvQ6r0jq2U+bsH8Cx+BdiwGGOLP7mSB7I0Vv80saZYygU9qR ZvfTtk1+75onStrxevAvfQSM1HtqqcA2JMR+MZd1bOsOQ1yq+yxOJ/gu+dvH2yCumKHTShg95rc6Q jXA8dCbw==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1vq9OW-00B22a-Fh; Wed, 11 Feb 2026 12:32:36 +0000 From: Breno Leitao Date: Wed, 11 Feb 2026 04:29:15 -0800 Subject: [PATCH 1/4] workqueue: Use POOL_BH instead of WQ_BH when checking pool flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260211-wqstall_start-at-v1-1-bd9499a18c19@debian.org> References: <20260211-wqstall_start-at-v1-0-bd9499a18c19@debian.org> In-Reply-To: <20260211-wqstall_start-at-v1-0-bd9499a18c19@debian.org> To: Tejun Heo , Lai Jiangshan , Andrew Morton Cc: linux-kernel@vger.kernel.org, Omar Sandoval , kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-f4305 X-Developer-Signature: v=1; a=openpgp-sha256; l=1075; i=leitao@debian.org; h=from:subject:message-id; bh=KPZEFqB87t2rBUIKQUeiu6xy1f+lMRscLe8C4JBNEpM=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpjHbc73eiFJMNLeu1kwHJoA4nysg8SdOayjXhp RQN/fLPUZCJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaYx23AAKCRA1o5Of/Hh3 bfYED/0Y6gm3JFM3nqdhhM/oA6JSrEuclbO3/8HfYpCJWX+fGpir23HCtd8oQjcpINp+WGe0Zzw 1hGUxYcTDBhDxs6wzejvNwOzPqERvchys81rENTlHpP/ldBe/gWpm7KZo8VT1758oY5b8bxaJdZ MwqlA0qmMlSfovm/eQs1Ju8BOLOcVq1yVVB891OZWfA8fKNAId1vyZcjtP0GRdjp2aLzO1m5h28 b1birxtJJ0P2klNzGboORnE9SPfgaTmZb6qGo1UmDKtyb5PZGLtjYuRjd3b1GPs1kn8c2YFEuYK 1ZoTzIi1zuN3cuQtHfSNJGZqs7XOAq1LrhrOEg8pGig7t2pAdE0Gzd61eSYDAwbBnIE/vvFxfNJ kXBp1R6R1Hii210MsEOSmS+SEWdTAoq2qfZNLDjBa5qz13I7S8l91XOVKPIc6GVWjBzT40OYhDE H0albclhkSd3IU866PL91Y2VE96hbe58TQJvuGyNqcXWa807cnm1FeMZWZx1Jbt0oG86JRhm6pj iKX4q1y50eBdqW9t4j4PHdi1E3ngW4D4q30gBT/BA43fPjgIMPHURN7CookxNBpi8JS73INgbWu 3Jzka74tSqZMUl7ziLDa+2oxIrxLiPiOTVQAduc8492h3VN1DtFReVHciwmhs6mhWuD1l3YI3lh qHelm9QmxsYBBMw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao pr_cont_worker_id() checks pool->flags against WQ_BH, which is a workqueue-level flag (defined in workqueue.h). Pool flags use a separate namespace with POOL_* constants (defined in workqueue.c). The correct constant is POOL_BH. Both WQ_BH and POOL_BH are defined as (1 << 0) so this has no behavioral impact, but it is semantically wrong and inconsistent with every other pool-level BH check in the file. Fixes: 4cb1ef64609f ("workqueue: Implement BH workqueues to eventually replace tasklets") Signed-off-by: Breno Leitao --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index e6c249f2fb46b..265d841e1b81c 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -6274,7 +6274,7 @@ static void pr_cont_worker_id(struct worker *worker) { struct worker_pool *pool = worker->pool; - if (pool->flags & WQ_BH) + if (pool->flags & POOL_BH) pr_cont("bh%s", pool->attrs->nice == HIGHPRI_NICE_LEVEL ? "-hi" : ""); else -- 2.47.3