From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013066.outbound.protection.outlook.com [40.93.201.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 642C133120D for ; Wed, 11 Feb 2026 10:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.66 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805779; cv=fail; b=ZN62rQDbNByPVuqd03QfkZDUvYf92RqziXqx3waMLJyTiVHn4j9IEQ00LNcMbX1mi0ceOe+zNq6QQJV38AWO9y2Tmx6kykl4oLUKLhRgXM9M/TB4SPKs1UbtKhImiXM70+PIaMI4Zp70lN7CCEsJvGyzNPF/WDe8X3/6m6RhHfY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805779; c=relaxed/simple; bh=b9/ukUeQ/ZXRNjB3X0txYYVhnmGgx+8UBJQh86ZKfwc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=P3XWm9tjdFvKzS2BUrQTdUXi2T47cORQ9TFEv2VyXzkoiWCt3ptqFAAO+opLGSC6gQXPUxeynZEG6hGngZBeyf3v15ibtW6/xIL84XvSNPURHJK9Z4cjYHNWKiwhdl5pFgKS3KHittA3yxbbByMccfC5yYdGVavPnD4wRBbIIrY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=TAjpeEp/; arc=fail smtp.client-ip=40.93.201.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="TAjpeEp/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RkOWaxv3BRZyihaltoaJfyj70uXvFud9fPVC8vtijr5HP/z+2ykGp1PuwNXTb7yX3SXaOfKAWWVWANoPNFQTppvTl2uvjiabrKR4ZFpiWkFrlOKZ0yaY9JYOGHo8Xh5spoyDP9dVrJ9WLYdXNttW4j+sd/OoRAF6L5mLFtWvNJGZCvsn0O7qo74Pw3h6XHsPSEseSqnb0zOeECNW45AWSrmTXe/Ijjm0wnDyIbba/831h2EpGYrNehrPzyzEtsFJAS2Gg9d75ikpI8MZh4u2Ef0MCkk9b31uUi/rohgv4gJ/3f6iRzRTu8kS2N9b2/IeX9zRsvDeDT2m+0DwtQW0LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uHceu7iAHQuM5HIY6q+KDeexBeEgkCwfj0lr0lphTh8=; b=J9Abt//PuEnDDD0n70M2w7hEDk5seaau41ognGQCzi3v7MZ84PE2af8dBTe928qLEKrmx2hrm6iMA5OaHhDt+xZXcr56hH6mVFp4cNUtGD4zUF35GNKAO46+J36s1+bd30eupbfAY8y+8w2KbzUNuoMNcP6iehXdx8JkweHGrGQNspB15nUkU2JgfYCN47F3zZZAHFy120BB4HeXnKMw1YFoJ5r0f9YeYcYeE1I9X4QaOgvYbUtPVET3uAKvvwkOeBhUDijRhYCEI/9wC2WAZirMhQXCI0Vb6i3pX8HGKgOINKvoLszYxgNtcWTwP4rR6s7LnDfQTTm8L8lgWnv/EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uHceu7iAHQuM5HIY6q+KDeexBeEgkCwfj0lr0lphTh8=; b=TAjpeEp/WgpmSv+UoZaNbdONWxPj97ualZ/GcqtCBbMGopjhqSnFk+i/LGv1B4gNFEkVlbcnncUC2VeaYYUgIpXd0CoYwCg2yei3vxZ7KXvxIkxwPSQvaNArLqn4/VSYArUoUoeDY/6HavksWFKCdigRIHYgQJIqUP/L7j8nxxs= Received: from SA1P222CA0192.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:3c4::13) by LV2PR12MB5941.namprd12.prod.outlook.com (2603:10b6:408:172::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Wed, 11 Feb 2026 10:29:35 +0000 Received: from SN1PEPF0002636D.namprd02.prod.outlook.com (2603:10b6:806:3c4:cafe::89) by SA1P222CA0192.outlook.office365.com (2603:10b6:806:3c4::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.10 via Frontend Transport; Wed, 11 Feb 2026 10:29:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SN1PEPF0002636D.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8 via Frontend Transport; Wed, 11 Feb 2026 10:29:35 +0000 Received: from FRAPPELLOUX01-WSLPUB.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 11 Feb 2026 04:29:33 -0600 From: Pierre-Eric Pelloux-Prayer To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter CC: Pierre-Eric Pelloux-Prayer , , , Subject: [PATCH v1 6/6] drm/amdgpu: dump job ibs in the devcoredump Date: Wed, 11 Feb 2026 11:26:53 +0100 Message-ID: <20260211102657.4180-6-pierre-eric.pelloux-prayer@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260211102657.4180-1-pierre-eric.pelloux-prayer@amd.com> References: <20260211102657.4180-1-pierre-eric.pelloux-prayer@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002636D:EE_|LV2PR12MB5941:EE_ X-MS-Office365-Filtering-Correlation-Id: b138690e-58b9-4b92-c48f-08de69587395 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?k79gnTQ1d3NCXioCly5CBtkib7vVR7tp9mOKNaitDiHQdLKpMcOGsqOHXEfH?= =?us-ascii?Q?67Hni+Gjw/XweK8rQdrL1dRR3CNcZT6S+q2pUl+wXbzfuZiILSbHqPdsIcXI?= =?us-ascii?Q?SLmg6YavJcaSvthcE4Qv6COwnBuoHQCqMftzJYJn1PfOiYDdpNN2J5aWeZCq?= =?us-ascii?Q?l3klhG5f9BAQkZFvvi7vsc+sVkFJO4+uYRIO/KUsxUSUxDpzNi+mpq+l6uhh?= =?us-ascii?Q?IQ+8NlInhR7yDWhRH8dQZJj1cy4u/FV7PFKuU11hqug5wpgWrzcxYS94gv9b?= =?us-ascii?Q?srxuWvwWEuAdGMxaHhfBp9Es22bL0fbxH1KUWyS5mqJvvdaIN0OUZX7Uu6Ox?= =?us-ascii?Q?3r1jC/3J/2St2DwvjQpKZ/I63MBMgn6JwzzbD0vQONK/N/0SzYyYzsrXniDe?= =?us-ascii?Q?MJqqynCyMRuXQhZ5RucLMv3VaAxdFGtoImhTRMtVjByWgevqXj59PC5divND?= =?us-ascii?Q?GfXfIi5NJ/T8omWLWa3M5Fz61ZYVsta2HseUbLSwiuPwPVhuI+diXxlepcFp?= =?us-ascii?Q?aVp2Y8A+Bk/WGrhmo3IQUucgiQHM9AuShBOV6PNPFAIBoxUlVmqFApR7eFg5?= =?us-ascii?Q?zePWogi7cMwViEDOHvT1kfxHdV3iFdhsaTAwjSywbyvyaZlBjk2yAVeC2iV/?= =?us-ascii?Q?X5ZSmLrVbD31fio42BigCimCdn1n+qL/2MWxkc0VoLtEKL2yZiweluWNujyJ?= =?us-ascii?Q?XbAtIaVqvHBU0JOeqgz2LXX+97vtfUs/k3ekZeShT+e0eHudUqxBfTs5tSsK?= =?us-ascii?Q?ZBjSjKRsBzNEVUAmXcOOtDSSVV48zwtb5/y7qxHJ6Qyk1NeQiChdrw7vEUmE?= =?us-ascii?Q?jrCTKAOnH3xdPMiGVvjOCo2Yvns4crxP1E9qZutHeIQKkLpwhrhPR3medTSh?= =?us-ascii?Q?fo0NbYksiRpWqSqGKW+hj5/PjtQgUU0Woz3MhfoXztJfBhmbpWKRoDXKygIR?= =?us-ascii?Q?gGq5WMSmP8Jo5RmN5EoVOwQ9IQFYZRCCeY++QnSzKdMOjPBxI0df67f100Ho?= =?us-ascii?Q?wS+DuZztA362en64UwNctn/E73lpVdfycTN2RMu4Ufvlf4CGvbbb/ftCOFg9?= =?us-ascii?Q?SMlMmRXNGNAfrFQX0g6HtmIyeKHqrObdJMauFyqsn6nI4ZMdXfCyQXPApnUm?= =?us-ascii?Q?Cbt2M3vza3Lq2pMfkXPn1mZMG0OP0fAvzoOQCTuIkNGcuCMbfdazM+KhF4RK?= =?us-ascii?Q?j+VJ2VMHQUqMFxE34H2X3b0pz9ogHjLFaB5ZqXYd6JtYFHEu/aA0+jOTXjMw?= =?us-ascii?Q?2IHXjNAHGayz/h4pdio5fIA6CWy+o/UeJ7w+Yird0UbgCrLPHb41dUsQV7j+?= =?us-ascii?Q?dleUdH1dHHP/I6C5gjgXRVjtjVi1j/XvenYPhegw5vtO/FYhoD7ZCIdAcBR1?= =?us-ascii?Q?mQpVk92WM8kv9JYCqp42GBenp1P924BCnbjc/r3Vk+E+rCX4N7YaF1wXhiKr?= =?us-ascii?Q?7AGX+GXAZqgUcFI/Ql/7MmPKu79+MdP10ch9aTPaOFEQUg7t9BoS8E193lLD?= =?us-ascii?Q?nh2TMYd52pEt3Z+4UPmXotXr8oGTN58fdzEvEGNuFhUlyq2pfa5efV83csaM?= =?us-ascii?Q?8cRPFy1fnIq1jWZKORwiH4UXGVzzglg3d4Ypwwkc7PZkckvulyMvzD4ihq5d?= =?us-ascii?Q?/WWOsP3S2KGqc+d4kqu+qojCcmGvsfNEB9ETF1YGFOGlCN373w7MXYK+jzjf?= =?us-ascii?Q?wlLmJQ=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Bh2tFyFX1zbu4k5GvPUuhKxt93cz4a6b10MHa1x4CSF9FYvGnea5EzE0DRsL1eWPC+4yF5BrHs9r/S+Q5iYSgSC5upLm0UCQvjSJbWYGLSd5hAK5zGWyqequi8rvghwRb70XSTHB24dvIwLm4WAdpzErjRrfr7mg8ihvkPVEP+oWnpXAbqvWDB+kJtEkSwbVTmW7N8LV0Kp5Xbz5iw0J7+MDXpTNddjPs00Dc+xytrwaYGA1HMOufjjWSvAQM2FGdxOGhy/9pd5aLCa3jkohoN3QB1viRl5qy50b0IOnonwsLeLqX4VJuJDzRxzfGq5vZ4rWum+J+1zSFTBOW5PjfipsNBQIJzVoYyJXmQuNfjB501amRvx40lpbsx83Mut4/JFfJWsMW7h0lZ/ryBDiuVhdS44v5+JPdfC2cgDXFjT0buZGIihPdFhR6s3NaPGE X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2026 10:29:35.0063 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b138690e-58b9-4b92-c48f-08de69587395 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002636D.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5941 Now that we have a worker thread, we can try to access the IBs of the job. The process is: * get the VM from the PASID * get the BO from its VA and the VM * map the BO for CPU access * copy everything, then add it to the dump Each step can fail so we have to be cautious. These operations can be slow so when amdgpu_devcoredump_format is called only to determine the size of the buffer we skip all of them and assume they will succeed. Signed-off-by: Pierre-Eric Pelloux-Prayer --- .../gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c | 84 ++++++++++++++++++- 1 file changed, 83 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c index d0af8a294abf..d576518c212d 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_dev_coredump.c @@ -200,12 +200,20 @@ static void amdgpu_devcoredump_fw_info(struct amdgpu_device *adev, static ssize_t amdgpu_devcoredump_format(char *buffer, size_t count, struct amdgpu_coredump_info *coredump) { + struct amdgpu_device *adev = coredump->adev; struct drm_printer p; struct drm_print_iterator iter; struct amdgpu_vm_fault_info *fault_info; + struct amdgpu_bo_va_mapping *mapping; struct amdgpu_ip_block *ip_block; + struct amdgpu_res_cursor cursor; + struct amdgpu_bo *abo, *root; + uint64_t va_start, offset; struct amdgpu_ring *ring; - int ver, i, j; + struct amdgpu_vm *vm; + u32 *ib_content; + uint8_t *kptr; + int ver, i, j, r; u32 ring_idx, off; iter.data = buffer; @@ -323,6 +331,80 @@ amdgpu_devcoredump_format(char *buffer, size_t count, struct amdgpu_coredump_inf else if (coredump->reset_vram_lost) drm_printf(&p, "VRAM is lost due to GPU reset!\n"); + if (coredump->num_ibs) { + if (buffer) + vm = amdgpu_vm_lock_by_pasid(adev, &root, coredump->pasid); + else + vm = NULL; + + for (int i = 0; i < coredump->num_ibs && (!buffer || vm); i++) { + ib_content = kvmalloc_array(coredump->ibs[i].ib_size_dw, 4, + GFP_KERNEL); + if (!ib_content) + continue; + + if (!vm) + goto output_ib_content; + + va_start = coredump->ibs[i].gpu_addr & AMDGPU_GMC_HOLE_MASK; + mapping = amdgpu_vm_bo_lookup_mapping(vm, va_start / AMDGPU_GPU_PAGE_SIZE); + if (!mapping) + goto free_ib_content; + + offset = va_start - (mapping->start * AMDGPU_GPU_PAGE_SIZE); + abo = amdgpu_bo_ref(mapping->bo_va->base.bo); + r = amdgpu_bo_reserve(abo, false); + if (r) + goto free_ib_content; + + if (abo->flags & AMDGPU_GEM_CREATE_NO_CPU_ACCESS) { + off = 0; + + if (abo->tbo.resource->mem_type != TTM_PL_VRAM) + goto unreserve_abo; + + amdgpu_res_first(abo->tbo.resource, offset, + coredump->ibs[i].ib_size_dw * 4, + &cursor); + while (cursor.remaining) { + amdgpu_device_mm_access(adev, cursor.start / 4, + &ib_content[off], cursor.size / 4, + false); + off += cursor.size; + amdgpu_res_next(&cursor, cursor.size); + } + } else { + r = ttm_bo_kmap(&abo->tbo, 0, + PFN_UP(abo->tbo.base.size), + &abo->kmap); + if (r) + goto unreserve_abo; + + kptr = amdgpu_bo_kptr(abo); + kptr += offset; + memcpy(ib_content, kptr, + coredump->ibs[i].ib_size_dw * 4); + + amdgpu_bo_kunmap(abo); + } + +output_ib_content: + drm_printf(&p, "\nIB #%d 0x%llx %d dw\n", + i, coredump->ibs[i].gpu_addr, coredump->ibs[i].ib_size_dw); + for (int j = 0; j < coredump->ibs[i].ib_size_dw; j++) + drm_printf(&p, "0x%08x\n", ib_content[j]); +unreserve_abo: + if (vm) + amdgpu_bo_unreserve(abo); +free_ib_content: + kfree(ib_content); + } + if (vm) { + amdgpu_bo_unreserve(root); + amdgpu_bo_unref(&root); + } + } + return count - iter.remain; } -- 2.43.0