From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF38E30F540; Wed, 11 Feb 2026 15:44:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770824644; cv=none; b=JVX5mrzK2rx9yjCnqmBuRq3gd6qok4psBypF971SVgNWNfrs6H9v9oc7uGfUZUK4QduT3anqmH+0rB7FCFqJquV40g0FFQoyYdOcWTfoymbdTLpRXI672C4H3OWKTrxnayIMpriXsGdMjqZYg3vkmNTCU3A85TMnX7HoS0OWMZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770824644; c=relaxed/simple; bh=I8IxnmVCk+FGLLSievLa0IM2y7OaqIwWWg+UEICANBY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FpwK04P+DbSIwOEg1dBpYYB9wSod/w1v6OM3wxJc0Jh6m7dZnEjSGTVdtTLOI5vjyG1rEP+bjhJ0dIerL8CMyeoW/aMTKSHmoX0iyAI2eehBPDFKQuCe9f+0FDc5vAlRe0DBGPt0sbSEVxnT81Y/eP8YV7U7mbKPBHr2vRk6whw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fPGr1tgN; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fPGr1tgN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770824643; x=1802360643; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I8IxnmVCk+FGLLSievLa0IM2y7OaqIwWWg+UEICANBY=; b=fPGr1tgNUAKAIREflBQkvPMc/LKDJYtl5vAjYE+Pzp5Am3JvS02l3FBP 3mIvkkzkpJDUpvJ4mKcYzi8Y4GEnEmLniTWc2VJjHrekFp449vQDUbLs3 qaSRp6hJt5Kt1lKWsDVfOWLFa7R7uq5c4vYM9DupllIQEeAUUBQznJ+S7 1396i5bQk8wWCxrJb1Eh79p69ol2Do0AIqe6Ku0CMMwnZu29GSwBLSXj+ lrgH6lls11GrA9/QEU9eVjz6jfV+mXcfwjKf7zB29BxHg6vmI1Ti6+POZ 3dImTPipw3UnKrqvw6H/bjHFfA2XIB4XjSdwN2hfRWu/qeR0oQS43m2KN Q==; X-CSE-ConnectionGUID: ZkU3l0LvRP6Yk+iKqGdanw== X-CSE-MsgGUID: 3nfTtFfURwOgD79GcXfE/A== X-IronPort-AV: E=McAfee;i="6800,10657,11698"; a="74572809" X-IronPort-AV: E=Sophos;i="6.21,285,1763452800"; d="scan'208";a="74572809" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2026 07:44:03 -0800 X-CSE-ConnectionGUID: P6meVnAsTt+pZp6h3cHYow== X-CSE-MsgGUID: FPUMnmGAS62NxoMKfz3L1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,285,1763452800"; d="scan'208";a="211649975" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by fmviesa010.fm.intel.com with ESMTP; 11 Feb 2026 07:44:01 -0800 From: Arun T To: arun.t@intel.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] media: i2c: ov13b10: Support tps68470 regulator and gpio Date: Wed, 11 Feb 2026 21:09:01 +0530 Message-ID: <20260211153901.3737233-2-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260211153901.3737233-1-arun.t@intel.com> References: <20260130092431.2335363-2-arun.t@intel.com> <20260211153901.3737233-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Ov13b10 sensor get clock and regulator from TPS68470 PMIC. Added tps68470 regulator/gpio names in power_on Signed-off-by: Arun T --- drivers/media/i2c/ov13b10.c | 47 ++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c index 5421874732bc..228ffe5ada70 100644 --- a/drivers/media/i2c/ov13b10.c +++ b/drivers/media/i2c/ov13b10.c @@ -11,6 +11,7 @@ #include #include #include +#include #define OV13B10_REG_VALUE_08BIT 1 #define OV13B10_REG_VALUE_16BIT 2 @@ -699,6 +700,13 @@ static const struct ov13b10_mode supported_2_lanes_modes[] = { }, }; +static const char * const ov13b10_supply_names[] = { + "dovdd", /* Digital I/O power */ + "avdd", /* Analog power */ + "dvdd", /* Digital core power */ +}; + + struct ov13b10 { struct device *dev; @@ -708,7 +716,7 @@ struct ov13b10 { struct v4l2_ctrl_handler ctrl_handler; struct clk *img_clk; - struct regulator *avdd; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov13b10_supply_names)]; struct gpio_desc *reset; /* V4L2 Controls */ @@ -1194,9 +1202,8 @@ static int ov13b10_power_off(struct device *dev) struct ov13b10 *ov13b10 = to_ov13b10(sd); gpiod_set_value_cansleep(ov13b10->reset, 1); - - if (ov13b10->avdd) - regulator_disable(ov13b10->avdd); + regulator_bulk_disable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); clk_disable_unprepare(ov13b10->img_clk); @@ -1214,14 +1221,12 @@ static int ov13b10_power_on(struct device *dev) dev_err(dev, "failed to enable imaging clock: %d", ret); return ret; } - - if (ov13b10->avdd) { - ret = regulator_enable(ov13b10->avdd); - if (ret < 0) { - dev_err(dev, "failed to enable avdd: %d", ret); - clk_disable_unprepare(ov13b10->img_clk); - return ret; - } + ret = regulator_bulk_enable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); + if (ret < 0) { + dev_err(dev, "failed to enable regulators\n"); + clk_disable_unprepare(ov13b10->img_clk); + return ret; } gpiod_set_value_cansleep(ov13b10->reset, 0); @@ -1473,7 +1478,7 @@ static void ov13b10_free_controls(struct ov13b10 *ov13b) static int ov13b10_get_pm_resources(struct ov13b10 *ov13b) { unsigned long freq; - int ret; + int ret, i; ov13b->reset = devm_gpiod_get_optional(ov13b->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ov13b->reset)) @@ -1481,6 +1486,7 @@ static int ov13b10_get_pm_resources(struct ov13b10 *ov13b) "failed to get reset gpio\n"); ov13b->img_clk = devm_v4l2_sensor_clk_get(ov13b->dev, NULL); + if (IS_ERR(ov13b->img_clk)) return dev_err_probe(ov13b->dev, PTR_ERR(ov13b->img_clk), "failed to get imaging clock\n"); @@ -1491,15 +1497,14 @@ static int ov13b10_get_pm_resources(struct ov13b10 *ov13b) "external clock %lu is not supported\n", freq); - ov13b->avdd = devm_regulator_get_optional(ov13b->dev, "avdd"); - if (IS_ERR(ov13b->avdd)) { - ret = PTR_ERR(ov13b->avdd); - ov13b->avdd = NULL; - if (ret != -ENODEV) - return dev_err_probe(ov13b->dev, ret, - "failed to get avdd regulator\n"); - } + for (i = 0; i < ARRAY_SIZE(ov13b10_supply_names); i++) + ov13b->supplies[i].supply = ov13b10_supply_names[i]; + ret = devm_regulator_bulk_get(ov13b->dev, ARRAY_SIZE(ov13b10_supply_names), + ov13b->supplies); + if (ret) + return dev_err_probe(ov13b->dev, ret, + "failed to get regulators\n"); return 0; } -- 2.43.0