From: Eliot Courtney <ecourtney@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Alexandre Courbot <acourbot@nvidia.com>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Eliot Courtney <ecourtney@nvidia.com>
Subject: [PATCH 7/7] gpu: nova-core: gsp: add tests for WrappingCommand
Date: Thu, 12 Feb 2026 15:28:09 +0900 [thread overview]
Message-ID: <20260212-cmdq-continuation-v1-7-73079ded55e6@nvidia.com> (raw)
In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com>
Add tests for WrappingCommand. They cover boundary conditions at the
split points to make sure the right number of continuation records are
made. They also check that the data concatenated is correct.
Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
---
drivers/gpu/nova-core/gsp/commands.rs | 123 ++++++++++++++++++++++++++++++++++
1 file changed, 123 insertions(+)
diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/gsp/commands.rs
index 99603880d56f..9a41c4a9d90d 100644
--- a/drivers/gpu/nova-core/gsp/commands.rs
+++ b/drivers/gpu/nova-core/gsp/commands.rs
@@ -366,3 +366,126 @@ fn init_variable_payload(
}
}
}
+
+#[kunit_tests(nova_core_gsp_commands)]
+mod tests {
+ use super::*;
+
+ struct TestPayload {
+ data: KVVec<u8>,
+ }
+
+ impl TestPayload {
+ fn generate_pattern(len: usize) -> Result<KVVec<u8>> {
+ let mut data = KVVec::with_capacity(len, GFP_KERNEL)?;
+ for i in 0..len {
+ data.push(i as u8, GFP_KERNEL)?;
+ }
+ Ok(data)
+ }
+
+ fn new(len: usize) -> Result<Self> {
+ Ok(Self {
+ data: Self::generate_pattern(len)?,
+ })
+ }
+ }
+
+ impl CommandToGsp for TestPayload {
+ const FUNCTION: MsgFunction = MsgFunction::Nop;
+ type Command = Empty;
+ type InitError = Infallible;
+
+ fn init(&self) -> impl Init<Self::Command, Self::InitError> {
+ Empty::init_zeroed()
+ }
+
+ fn variable_payload_len(&self) -> usize {
+ self.data.len()
+ }
+
+ fn init_variable_payload(
+ &self,
+ dst: &mut SBufferIter<core::array::IntoIter<&mut [u8], 2>>,
+ ) -> Result {
+ dst.write_all(self.data.as_slice())
+ }
+ }
+
+ fn read_payload(cmd: &impl CommandToGsp) -> Result<KVVec<u8>> {
+ let len = cmd.variable_payload_len();
+ let mut buf = KVVec::from_elem(0u8, len, GFP_KERNEL)?;
+ let mut sbuf = SBufferIter::new_writer([buf.as_mut_slice(), &mut []]);
+ cmd.init_variable_payload(&mut sbuf)?;
+ drop(sbuf);
+ Ok(buf)
+ }
+
+ struct WrappingCommandTest {
+ payload_size: usize,
+ max_size: usize,
+ num_continuations: usize,
+ }
+
+ fn check_wrapping(t: WrappingCommandTest) -> Result {
+ let mut wrapped = WrappingCommand::new(TestPayload::new(t.payload_size)?, t.max_size)?;
+
+ let mut buf = read_payload(&wrapped)?;
+ assert!(buf.len() <= t.max_size);
+
+ let mut num_continuations = 0;
+ while let Some(cont) = wrapped.next_continuation_record() {
+ let payload = read_payload(&cont)?;
+ assert!(payload.len() <= t.max_size);
+ buf.extend_from_slice(&payload, GFP_KERNEL)?;
+ num_continuations += 1;
+ }
+
+ assert_eq!(num_continuations, t.num_continuations);
+ assert_eq!(
+ buf.as_slice(),
+ TestPayload::generate_pattern(t.payload_size)?.as_slice()
+ );
+ Ok(())
+ }
+
+ #[test]
+ fn wrapping_command() -> Result {
+ check_wrapping(WrappingCommandTest {
+ payload_size: 0,
+ max_size: 50,
+ num_continuations: 0,
+ })?;
+ check_wrapping(WrappingCommandTest {
+ payload_size: 50,
+ max_size: 50,
+ num_continuations: 0,
+ })?;
+ check_wrapping(WrappingCommandTest {
+ payload_size: 100,
+ max_size: 50,
+ num_continuations: 1,
+ })?;
+ check_wrapping(WrappingCommandTest {
+ payload_size: 101,
+ max_size: 100,
+ num_continuations: 1,
+ })?;
+ check_wrapping(WrappingCommandTest {
+ payload_size: 150,
+ max_size: 100,
+ num_continuations: 1,
+ })?;
+ check_wrapping(WrappingCommandTest {
+ payload_size: 300,
+ max_size: 100,
+ num_continuations: 2,
+ })?;
+ check_wrapping(WrappingCommandTest {
+ payload_size: 350,
+ max_size: 100,
+ num_continuations: 3,
+ })?;
+ Ok(())
+ }
+}
--
2.53.0
next prev parent reply other threads:[~2026-02-12 6:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 6:28 [PATCH 0/7] gpu: nova-core: gsp: add continuation record support Eliot Courtney
2026-02-12 6:28 ` [PATCH 1/7] gpu: nova-core: gsp: sort MsgFunction variants alphabetically Eliot Courtney
2026-02-12 6:28 ` [PATCH 2/7] gpu: nova-core: gsp: add mechanism to wait for space on command queue Eliot Courtney
2026-02-18 3:13 ` Alexandre Courbot
2026-02-18 4:05 ` Eliot Courtney
2026-02-18 7:20 ` Alexandre Courbot
2026-02-12 6:28 ` [PATCH 3/7] gpu: nova-core: gsp: add checking oversized commands Eliot Courtney
2026-02-18 3:23 ` Alexandre Courbot
2026-02-18 6:50 ` Eliot Courtney
2026-02-18 7:25 ` Alexandre Courbot
2026-02-12 6:28 ` [PATCH 4/7] gpu: nova-core: gsp: clarify invariant on command queue Eliot Courtney
2026-02-12 6:28 ` [PATCH 5/7] gpu: nova-core: gsp: unconditionally call variable payload handling Eliot Courtney
2026-02-12 6:28 ` [PATCH 6/7] gpu: nova-core: gsp: support large RPCs via continuation record Eliot Courtney
2026-02-18 7:16 ` Alexandre Courbot
2026-02-18 9:00 ` Eliot Courtney
2026-02-18 11:49 ` Alexandre Courbot
2026-02-12 6:28 ` Eliot Courtney [this message]
2026-02-17 18:18 ` [PATCH 0/7] gpu: nova-core: gsp: add continuation record support John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260212-cmdq-continuation-v1-7-73079ded55e6@nvidia.com \
--to=ecourtney@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®