From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1B80344DA9 for ; Thu, 12 Feb 2026 11:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770895606; cv=none; b=kbTsnF/LrZr4VsID7x3QHeuV9wH6BzLLHZ4XeKtxjfMyVvx+cABE+CHeZ3If/5DvjSBUBzd8plfduDjyXjAilUXviDsHI4k2ZwAX0mwIrGr8FPbGtmb5aQ8Y8Zw85WffQlrxs1L3l8yQaM3EiSgxa1J7RVMyCxj+Ampr5G9C24s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770895606; c=relaxed/simple; bh=ELesR79nEgzbYvbVtbkai+gF5L9OXkkQBqsB+SAv8Ms=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rWadgTZ2mgq1ZZGON5iGIGUfUNkniMd8XYqavn4HBB2y3kqqYVQaiXChDGm4YH12RFVuXUIe2I9VYKO6Plbc93aQrxBxQfpxiFMTwFp8OG+k48aGMIaxFzD5v+F6/UQkMoMH46y+2uf2ujBLPTuHGFNURtemW4yst1fAYOQApc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k/0+u38a; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k/0+u38a" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-59e6ab06167so35498e87.0 for ; Thu, 12 Feb 2026 03:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770895603; x=1771500403; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Te28COGsJvbZjhoIswrSDU/sOtkJ6DypnGTOIiAuYoo=; b=k/0+u38a/N2PFOKLiX43HX/HS7fWNwrPNyL7dqY9u2213n5sN45ScbtS0jZuFmB35k ysLU3FX8rPFcCLFttjiGzdk2GLXx032rhR+tgmEU3EMvT/jRaTslTg0+Wu7pQcNJTazB VDjyov6FM8JTp0bMWwaX7Bb/j2ebajupPKoRFHm05ShJm+B49etOVK9m31C5dW6c8+Nm JhPSxkRTTcSX/0GqWNFxgTIu9eRMFHUdu48XMFKPjLE+0OJaKHTLXfOvS4ieuFFz8d9z oFFKgclbXj7ByuzPbvkOuoAsOnoUkfiJ0UkF8iTImLpp22Exfh+pC0iVyLJKoaICDrgz OCew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770895603; x=1771500403; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Te28COGsJvbZjhoIswrSDU/sOtkJ6DypnGTOIiAuYoo=; b=KDrhKlQPK3HLuzwbAtBJlPFeyYFbzrPfQ2brrEEOPF2bYQMAHavm23Kuyi1/GvtYZ8 +Aj7F/LrIBekkEU1f7FmqAzmiMNrwA3JcU2yrj+KrfM5QstUdcLo2IMCXN3UWdS/NPbk Es6JFCHzCyLGehrbGF0wWWkFsBkHEIQvhU4UTGN+bmntlef/cDLozacyy9VUmVzJ/+v6 CL9Df8dpqvHqcIGoilEYwQvMAzs2AiFmTJ+1Et2nCmv1/GsUtxESDkkQBk6ctYZAcYBo 7eEAMc5Y4Nncip9JaGHqwFYc6RiljlbgSRcVCWRJMCZsVTulvVzLbfh8J0K2sAxJ0n8I eDUw== X-Forwarded-Encrypted: i=1; AJvYcCUf6NF0a3vr3tpNBk9o2sxkWv8c+TO6GC4j9RZaSGQeJiB2DmL40upBcEHg8OMP2piP8Ibsp4gg3Y9ke0U=@vger.kernel.org X-Gm-Message-State: AOJu0YyKnSUXTPbyiFMiYMKjiL8IYLu2aNOQqGsffMf+Gd3a4M1JSZd2 e87kgvLbNzPbfJGIWmqBp2MXuccqshi5iicyyCDhRzpfbAXBx04EQr02 X-Gm-Gg: AZuq6aKNu5cZypjoI1QJ+HRIbNud24FM15dNxBhaXpNI7y7ltN+ZDVNE2ijwVAx+GST TOh5OjY6npwB5Ybf9fi52njjQYxBFZuKfshgQCa6PVP4WGe4ftW6aFDspGdrj5DAlCzhFX9ohoN Y7Gg6qAJlzq60iWFIGpfiaruu1YI3srTlYEy74JnhdOsjm8NzHov20e6NQqM3FMYdGVoYZ7Xk27 my0qFam8UHnl8CLqhhLNkM8a0Xx1/l+WVrqdaWnD1hzX63Bx71/7QjihE9eW+lTUFDI1DIQ58qn Mlsbn4ruO/Zarxyquvebpy65+RbZK6xsLkrKkssHJJnPTqmLupCzpHhziUyDI6N4X05t/kYNVln 9i72r90uOuMUHwr/r68rHPoA9UbqK7eV5kFOyDJCIDHy1KI8xo6v7X8XQRsHt0e9mUZzlmBvg7D 9zNaMwkoDGt8WQHGU= X-Received: by 2002:a05:600c:524a:b0:477:7a78:3000 with SMTP id 5b1f17b1804b1-48365718323mr18483945e9.6.1770888685036; Thu, 12 Feb 2026 01:31:25 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:2f75:bf70:f0b9:4586]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d482480sm215126875e9.0.2026.02.12.01.31.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 01:31:24 -0800 (PST) Date: Thu, 12 Feb 2026 11:31:21 +0200 From: Vladimir Oltean To: Vinod Koul , Geert Uytterhoeven Cc: Ulf Hansson , Yoshihiro Shimoda , Neil Armstrong , Josua Mayer , Wolfram Sang , Tommaso Merciai , linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] phy: renesas: rcar-gen3-usb2: Drop local devm_mux_state_get_optional() Message-ID: <20260212093121.2c6o6pkk4riphbel@skbuf> References: <67c8c4f9bf9f09fd0c13daedef27b82ff389ddfb.1770720452.git.geert+renesas@glider.be> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 12, 2026 at 10:29:12AM +0530, Vinod Koul wrote: > Hi Geert, > > On 11-02-26, 17:30, Geert Uytterhoeven wrote: > > Hi Vinod, > > > > On Wed, 11 Feb 2026 at 17:17, Vinod Koul wrote: > > > On 10-02-26, 14:34, Ulf Hansson wrote: > > > > On Tue, 10 Feb 2026 at 11:53, Geert Uytterhoeven > > > > wrote: > > > > > Now the mux core provides devm_mux_state_get_optional(): > > > > > > > > > > drivers/phy/renesas/phy-rcar-gen3-usb2.c:944:1: error: static declaration of ‘devm_mux_state_get_optional’ follows non-static > > > > > declaration > > > > > 944 | devm_mux_state_get_optional(struct device *dev, const char *mux_name) > > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > In file included from drivers/phy/renesas/phy-rcar-gen3-usb2.c:20: > > > > > include/linux/mux/consumer.h:64:19: note: previous declaration of ‘devm_mux_state_get_optional’ with type ‘struct mux_state *(struct device *, const char *)’ > > > > > 64 | struct mux_state *devm_mux_state_get_optional(struct device *dev, const char *mux_name); > > > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > > > > > Fix this by dropping the temporary local wrapper. > > > > > > > > > > Fixes: ad314348ceb4fe1f ("mux: Add helper functions for getting optional and selected mux-state") > > > > > Fixes: 8bb92fd7a0407792 ("phy: renesas: rcar-gen3-usb2: Use mux-state for phyrst management") > > > > > Signed-off-by: Geert Uytterhoeven > > > > > > > > Thanks Geert for helping out! > > > > > > > > > --- > > > > > - ad314348ceb4fe1f is in mmc/next, and a PR has already been sent > > > > > https://lore.kernel.org/20260209133441.556464-1-ulf.hansson@linaro.org > > > > > - 8bb92fd7a0407792 is in phy/next > > > > > > > > Vinod, do you want to pick up the $subject patch as a fix for 7.0-rc1 > > > > or do you prefer me to handle it? > > > > > > Should I drop the 8bb92fd7a0407792 and it makes things easier for > > > everyone and then we can pick fixed commit for 7.1 cycle.. > > > > > > Does that work for everyone. I was about to send PR, will hold off for a > > > bit. > > > > Alternatively, you can mention the semantic conflict in your PR to Linus, > > and ask him to fold my patch into the merge commit. > > Hmmm, that is also a good option but might leave Linus a bit grumpy so > bit reluctant. Dropping and getting right implementation would be > better. I think it was a mistake to pick or this all could have gone > thru mux tree. > > Thanks > -- > ~Vinod I think with Linus' refusal of the mmc/next PR, there is no longer any need either for this patch or for the revert of 8bb92fd7a040 ("phy: renesas: rcar-gen3-usb2: Use mux-state for phyrst management"). http://lore.kernel.org/lkml/CAHk-=wgnRQiKqWVrO_uF1btYM2K8r8xL95RGdKU3QLe8B58nrw@mail.gmail.com