From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DFAF219A81 for ; Thu, 12 Feb 2026 19:31:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770924711; cv=none; b=W8VdF0r1QjzVLvvNSRgtLZbRdwGbtnjCVc1jzoM5UGGFJ8grHVd+s4b2NOoP0KWCYMgvGuxO/6r3gHfIlXyAcCeO97PMTdubEUlLpeIMNVq+/vWl1w0JB1JCAbIh191DWAataxJW7YIJqGkdBFOx0mjOMyOg8dR+kOVjrkFeIwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770924711; c=relaxed/simple; bh=Ztp3LLYcga7lhFJC2/Iw/1htqJzQMWRJXl5wKEtokzc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iqLizbL2fEqo82xmlOfAGq40iS2VoreYPh4mvwN4AcSNF/xF7MbjGGHk8fYOYEAGfsS+PNceHSWMjwaxX+/bIj0vL22kGXHVnryP4VkZBLNiutX57uG2ouxxRktWYlCI1kk3L+o4pB+SbjXNO3dLHRr3qbkGl6Q5ZdZszIpa/Zw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=cghM0nm+; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cghM0nm+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NuPKWMZkTG+6hL1iSTT2Ng6DURko3dfgcXGpNQFh19k=; b=cghM0nm+gO4CUiQTxo2Tf3IDd6 BLomYKOEwS9RbO34/Pmt3vQ0SPy3btFORgpc/RfVrrho4Ok80+D3Ib6BoIuarmewCn2BZBRnF50sC oMN+4lT1MYdtmiwXPAJPWLDLrAGWlN3kJlNzhyyWmfZ8JyTGFyPSy8KpdWTMnZxxkz+smuW/bDTUW yCBla+06mCZfYZcBhX8B3aMKdfasfLAxbAVnr8AeTHL1/ejT8bSwkKA2JMnmA7r65hGmGboMLz+ND dl8N3oOtixdpPUH2xLCUmL+gP/lOJgJL0ggiP3cGNceDiu9Mogpcm4ns4gLt3IbtCKIv/UuJVIQAB MZ7T3sCA==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vqcPc-0000000Ed2i-2jO8; Thu, 12 Feb 2026 19:31:40 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 12397300754; Thu, 12 Feb 2026 20:31:40 +0100 (CET) Date: Thu, 12 Feb 2026 20:31:40 +0100 From: Peter Zijlstra To: Vincent Guittot Cc: K Prateek Nayak , Doug Smythies , mingo@kernel.org, juri.lelli@redhat.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, wangtao554@huawei.com, quzicheng@huawei.com, wuyun.abel@bytedance.com Subject: Re: [PATCH 0/4] sched: Various reweight_entity() fixes Message-ID: <20260212193140.GR1395266@noisy.programming.kicks-ass.net> References: <002501dc9b16$442a7050$cc7f50f0$@telus.net> <20260211090144.GY1282955@noisy.programming.kicks-ass.net> <20260211104833.GH1395416@noisy.programming.kicks-ass.net> <20260211162825.GZ1282955@noisy.programming.kicks-ass.net> <58c6c115-f544-4c51-990c-a3ad2fbf701a@amd.com> <20260212115943.GB1282955@noisy.programming.kicks-ass.net> <20260212171611.GL1395416@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 12, 2026 at 06:24:27PM +0100, Vincent Guittot wrote: > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > index 5b1a2abb727e..de155be02411 100644 > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -797,7 +797,11 @@ u64 avg_vruntime(struct cfs_rq *cfs_rq) > > if (runtime < 0) > > runtime -= (weight - 1); > > > > +#ifndef CONFIG_64BIT > > delta = div_s64(runtime, weight); > > +#else > > + delta = runtime / weight; > > +#endif > > Good catch > > Don't we have the same problem with the div_s64 in place_entity ? Indeed so. Let me go fix both and push out a new set. I'll post all the patches tomorrow once the robot has blessed them.