From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FCDD364EB2 for ; Fri, 13 Feb 2026 17:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771003418; cv=none; b=jajUbSekgy9B4LXzh/PWXVvwm+RbWLsH9FmlYK1tPz9AcVt/lXQpq/Woiajlwzlm8p6xaCSTt1RIT6rdPZQI/ELJ5vVJIY6s7n+JHLy1bhsOg6bzNLoxfwEsMc69OJSL9m24tJwCZjUDkvzd2RWOTZduuEWKynkLyaqskgm+lkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771003418; c=relaxed/simple; bh=GOkUPZVXOwDq9FSpdZJkLdBr0dSwWUaE8V8I4dJqcUE=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=WgC6saW+IyHtTia9m8w1J4gASxd1+R7yXR/csgaM/XQxvCDfXocmY16Yir20BOGyaQ8JWmuKtHOE26s2b1P0jsUd/GGYWAYmusi8fnCZJH8OXq3GwoWzX8L+bOs+C8rI8wLcBxcRSwwYNwXVTwIX5eA84th502B1FpG5vKBZCug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ES8WK39v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ES8WK39v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D530C2BC9E; Fri, 13 Feb 2026 17:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1771003417; bh=GOkUPZVXOwDq9FSpdZJkLdBr0dSwWUaE8V8I4dJqcUE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ES8WK39vvoGESzTed4NVICd3ff7Wwz7GjtVdhcPiai0qa4UMnAytDMt5C+ZU9g0b2 Ggvq8RvYnrZLXFsTGMQZtMAQhMnQ1gSAVsCfjAMJbOM1fLA+aZ5WyZ2Kl8UrMZK4cI /Zkair0tOk3/fRPChmrAn/LZZojJCAS0QG1v3rjs= Date: Fri, 13 Feb 2026 09:23:36 -0800 From: Andrew Morton To: "Arnd Bergmann" Cc: "Arnd Bergmann" , "Johannes Weiner" , "Axel Rasmussen" , "Yuanchu Xie" , "Wei Xu" , "David Hildenbrand (Red Hat)" , "Michal Hocko" , "Qi Zheng" , "Shakeel Butt" , "Lorenzo Stoakes" , "Baolin Wang" , "Kairui Song" , "Davidlohr Bueso" , "Koichiro Den" , "Jiayuan Chen" , "Bertrand Wlodarczyk" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: avoid false-positive -Wuninitialized warning Message-Id: <20260213092336.c2b0f2d1be17f1e2e9856f11@linux-foundation.org> In-Reply-To: References: <20260213123902.3466040-1-arnd@kernel.org> <20260213085842.0654f70a73ec05d88908ec25@linux-foundation.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 13 Feb 2026 18:07:04 +0100 "Arnd Bergmann" wrote: > On Fri, Feb 13, 2026, at 17:58, Andrew Morton wrote: > > On Fri, 13 Feb 2026 13:38:56 +0100 Arnd Bergmann wrote: > > > >> From: Arnd Bergmann > >> > >> When the -fsanitize=bounds sanitizer is enabled, > > > > Is this an option in current kernels? > > Yes, this is CONFIG_UBSAN_ARRAY_BOUNDS. The actual warning > only shows up in some configurations with that, so either there > is some other dependency, or an element of chance based on gcc > optimizations. OK, I'll put a cc:stable on this, as people will want to compile older kernels with gcc-16. Aiming for upstreaming into 7.1-rc1 unless it's more urgent than I think. > > Seems a large change just to squish a compiler warning. People might > > prefer a simple > > > > - struct ctrl_pos sp, pv; > > + struct ctrl_pos sp, pv = {}; > > Right, that would clearly also shut up the warning. > > To me this seems less intuitive without an extra comment, > since read_ctrl_pos() is meant to initialize the entire > struct, but please pick whichever you find most readable > here. Let's see what the MGLRU maintainers have to say.