From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 779E334F244 for ; Fri, 13 Feb 2026 09:53:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770976421; cv=none; b=bb7OKxPvdk2sb9FREsBRmehB5sB/044AiOPPW8vxIiT6apLGhryjrEfEKnyMDS0wCVrHBMmAnSXyrs/88menlGUIn0heglS72Rp/USSIHs6Xw4eKbRtEz/7EZpPQ9RCICi2zAQrY7Y9b/7LVDTY6oxK2bUnifY8zujFy3oSC1vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770976421; c=relaxed/simple; bh=8zLE1JUY9lptU6FZL8RTQheiRxSDaR9HqA7Uezz4sGk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JEdJ6bc9ZgPTicxAgm42s4sj1Y8kkAiJO9gc9H0vyKT6By4Yh1zNkR0zN+t3NgGaruyvNOJbmCct9vkV2BuYsa9n7KF19aAjuCP7gpSZHt5/pggSnmZfREkdWxWME0qt5QSDuXVvuTmkP4Vf+xa+r+WFFMMWwEMEP2WfEpvojYQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nCGIM1Ka; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nCGIM1Ka" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770976418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=zDVsVDuC8rklFvkCvFEiDn5ZrvFzaaQPmiG4+7zn3VE=; b=nCGIM1KaaOHLCRVyW02WQo4HC//PTS3xQd69Y7Ha/zVZx1ZzT1Db2mib8k2Jmmaa4EmkTn H7HIhLK98yDQ+c5W5LgtbwWZtHpFp4KUyVMoDChCJy2oDjuP9BcBf6W34G50817XTQTnkT DDkAQXOdMrEyIlgRr0UfPRuEE+S7n50= From: Kunwu Chan To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: Alexandre Ghiti , Anup Patel , Atish Patra , Zong Li , Deepak Gupta , zhouzhouyi , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH 1/2] riscv: xip_fixup.h: fix comment typo and whitespace issue Date: Fri, 13 Feb 2026 17:52:40 +0800 Message-Id: <20260213095241.399068-1-kunwu.chan@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Fix two minor issues in XIP_FIXUP_OFFSET macro: - The comment describes the fixup formula as "reg += CONFIG_PHYS_RAM_BASE - _start", but the actual assembly code subtracts _sdata, not _start. Fix the comment to match. - Replace spaces with a tab for the "add" instruction to keep consistent indentation with surrounding lines. Reviewed-by: zhouzhouyi Signed-off-by: Kunwu Chan --- arch/riscv/include/asm/xip_fixup.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/riscv/include/asm/xip_fixup.h b/arch/riscv/include/asm/xip_fixup.h index f3d56299bc22..56db595b0e14 100644 --- a/arch/riscv/include/asm/xip_fixup.h +++ b/arch/riscv/include/asm/xip_fixup.h @@ -16,10 +16,10 @@ * * The start of data in Flash is _sdata and the start of data in RAM is * CONFIG_PHYS_RAM_BASE. So this fix-up essentially does this: - * reg += CONFIG_PHYS_RAM_BASE - _start + * reg += CONFIG_PHYS_RAM_BASE - _sdata */ li t0, CONFIG_PHYS_RAM_BASE - add \reg, \reg, t0 + add \reg, \reg, t0 la t0, _sdata sub \reg, \reg, t0 .endm -- 2.25.1