From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AD317E0FF for ; Fri, 13 Feb 2026 10:34:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770978900; cv=none; b=FtenmdXFTjgIwfYOfh7KIvo26dAoFPFNLTQzTdnj8uuBtPGD6zbVeF0bcibXaz5azrsMu5n/LySncBYKFIgNkg6Pzd1azc61uL4TpEb17VHkiuw6yP1ctliDzfs9/TEhXbMe0FPWClzp8L/oJPMtmcKbaz9Uc2kXclUIDHWCcsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770978900; c=relaxed/simple; bh=vhsH9mtau4Uz2YG/+Z0LgY0/5RXOh+YijD4TJlExTtA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cqfTvaAuKQw+BgrG6s5ftk5rv+GprUj02c0zYQouLQ02OSPvRTKKnN62BClk01anlDvuNH8oa0ZBvCF7od//VEWIuwW7ckSv/2dfP3Y2xeuJhDDkN2bhbLK6OKDFyDfQSdbtBxegl9WMBhtvj36fXahdwnYwDMDjpdh4dFuLVS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UvQDHmuG; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UvQDHmuG" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-48375f1defeso2157825e9.0 for ; Fri, 13 Feb 2026 02:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770978898; x=1771583698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=huhmJuBCDaJLhpU5/7i3Q5nwShl4MBS9pZW3ziMh3Gw=; b=UvQDHmuGy5nNxSBzHDKswfQMJg4EGSUO7Vxp3uVKj3VR03HPgbaHSi1OlKjiLMxIuB 1c2o2y+PvrPepFOm9TFcM2WvNaXpmnTL+Q+nrVc9wjrY9JG1MFIn4XzFsaYEpUyeVFbq nohwHC1f2OfHxDkSRHAGX9Vwi+CUeMhE+XX13REfrdI3CbKOIQmC9xfmGlWWeOZEfWcF 04PRudoz8NnNH1pvYkiPMp02RSuIgs9L7iOPSb3HmvjUI+xoxzd07xi8ZRHcLBqmlHa6 OGuqi5IuVrPGCKLSXaBt4L2OC5ZmWIfoQB0EL3xs8QG/+3up2a7RmO7yJ2a3GORZ26fn +jpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770978898; x=1771583698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=huhmJuBCDaJLhpU5/7i3Q5nwShl4MBS9pZW3ziMh3Gw=; b=FYfr00ErxN1TKk66c2inYZeQzS0/GNvVmj4xyBLk3AH+iLcfedrKUE0v9wyfuZTGuN uBJ+8Mm9iYM7j36TLNDxzX75JQSzav1DEiKsyyU0Cr9tAxRZ/06rq7FwNEK4RQRvHRJD k3E5yiOak36M+1rB3Hrpn+wcUXvDkU/qSbEbSqr9ZXAjDlBj1dGbsEbwzUKFL2eURg1s ylc59sjM2jPRUvAEJTk4w3LLKVFJqBauwbEi8Dm592WU2t5x+yIRRNWyK++w3ZbSQcnz kwnmRTwVAjXUc9rRLtbaRq0pwmrS2ZViLuy00FLknWgcH0XEbU/eKDdUjPVuzSn/88wm X/ww== X-Forwarded-Encrypted: i=1; AJvYcCUlwurlz0NGqm9zd3Caso/KyKQSFPdd15ylVsPiJQd05C5RmgCJHkwXiBwTrBwXor8vFL9fVCCu4ix728A=@vger.kernel.org X-Gm-Message-State: AOJu0YzatlNTnZTmvjK0s8LuuvGv1t2Yl88Tmi0x/Bt3TzGb4YHh455A wWyZoIbCvY4SVZi2/2opl0xyRryLVvrJr4JvsDUp4GoTL7XQJQ89rsPt X-Gm-Gg: AZuq6aLy9+o7XgE5aNuwQBMjRm7Tjqq1w1OceTmfXiV4werKrj10YNsFk52TQmjdD68 gmoIEhlRLtznOJaku3dP84Xz3y2YqJ5W1X7ILM9Csnq2lJmyOwt9KNGGqisioYdpyMovsBP0nZU K0jmFzoDOgy1F8OGFEoxhwa8P1wSylynydk2eh9WZ8C/f0yCOBmLjmgquLh0u1jq23trIKb07EU lvAVdZf331SV79oDNyAK2GI1JPRi32lCugUCgCtemPu0eZcY0K8DiWHZmn3SUx/IvZxBP0XfubG K+DtQTjmgUt/b4Hij43JiOCxBiq83ZkobF+uh8Qj0MCETqYOE6pVe7FoIxIj4Ea3fyHVZviToVX BgF1qtQCRUnhuafURlM3PwN4dYc6gIDfuziaopexeq1HXYpwLSygOJOD81UvOvDfnYSoVJY5jgz ROXZRJdg+vyJ8q7vl9Eh8QcaUx9VYhY1bJtW5CN9rLZLtsXItt7iyIwXxan0pF X-Received: by 2002:a05:600c:5246:b0:483:71f7:2782 with SMTP id 5b1f17b1804b1-48373a14406mr21442465e9.12.1770978897621; Fri, 13 Feb 2026 02:34:57 -0800 (PST) Received: from lima-ubuntu.hz.ali.com ([47.246.98.214]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8d46sm5118594f8f.32.2026.02.13.02.34.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 02:34:57 -0800 (PST) From: Qing Wang To: b.sachdev1904@gmail.com Cc: avagin@gmail.com, brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ptikhomirov@virtuozzo.com, syzbot+9e03a9535ea65f687a44@syzkaller.appspotmail.com, viro@zeniv.linux.org.uk, wangqing7171@gmail.com Subject: Re: Re: [PATCH] statmount: Fix the null-ptr-deref in do_statmount() Date: Fri, 13 Feb 2026 18:34:48 +0800 Message-Id: <20260213103448.2474564-1-wangqing7171@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 13 Feb 2026 at 17:38, "Bhavik Sachdev" wrote: > Hey! > I think the fix should be the following instead, AFAIU we don't want a > call to an internal mount to succeed. > > diff --git a/fs/namespace.c b/fs/namespace.c > index a67cbe42746d..55152bf64785 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -5678,6 +5678,8 @@ static int do_statmount(struct kstatmount *s, u64 mnt= > _id, u64 mnt_ns_id, > > s->mnt =3D mnt_file->f_path.mnt; > ns =3D real_mount(s->mnt)->mnt_ns; > + if (IS_ERR(ns)) > + return -EINVAL; > if (!ns) > /* > * We can't set mount point and mnt_ns_id since we = > don't have a > > Thanks, > Bhavik I had considered returning an error code before but finally decided to not. Thank you for your suggestion, I agree with it and resend the patch v3 [0]. [0] https://lore.kernel.org/all/20260213103006.2472569-1-wangqing7171@gmail.com/T/ Look forward to your review. --- Thanks, Qing