From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3048816CD33 for ; Fri, 13 Feb 2026 12:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770986236; cv=none; b=o42NDXEZGRCVboaKAF4lJXXJHFemTi+C/t2o3Oh3EZawk5K1ky3w9scj/oAKuU2PTAxbaXXpzLnfOTDpdZjIqjbX8uebLWzI5vA6f1GGZqrRrK70tAECQV0tpqeIIR6yUJlyFye+psCabzq+VXaD/OrqTEmokyqOkgwFrIfWyw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770986236; c=relaxed/simple; bh=/Zt6khdhGfH3Hkoe052E7yZXR/qlFYcR5e3cmtxk5rY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oLqxY+e+NtzHaA0rXyo0n267ffl+Rp3FbLXgxsm9NOUwyVjgn4Pm67Ls6SQuWSK8lgNB5Qf3BSIkU/ysAn/58I4lN8ainRiug2cEVxNg373T4bC1hBPuT4/Rml+DQbPJYvyUhsO7MlM9pESzXFVjXmKJGv9TlfuWISwYynaww40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fmZjjKtY; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fmZjjKtY" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-59e62bbafa0so58930e87.2 for ; Fri, 13 Feb 2026 04:37:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770986233; x=1771591033; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=r7nT78nIm0YLmarabSYPD2yv/puF0ssCbcpZBWsZgYU=; b=fmZjjKtYRjyv81TNlBYS4MDkQvR0HEu1pE5IDIymxm2Q/LTwvY0lvOAd1Ligte7tvm l09Lt0QIrErs+UsNsTjJ9USmRfHIn2RXSFwi8vnEC5IiIjxjH9BizOjxQRNw7rQfPLtu fhBlY5cq8Uv94ZXQuuzbtg83wqTbo874lta3T6J2eivCpPdOh3uCTKGGJwkAAIUchxvX e72VIAhjHQ4t1Mnuo9UEzAo2PKKdhwVdgQtAymRuA32mFY1k6U848GTJ2t4VVEuyzn64 2BS2YIGhkV7yng2C5DEzfTqD9iaOahdJjDKn469hRgJuKTDibf306hDckcdF749175Dx p+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770986233; x=1771591033; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r7nT78nIm0YLmarabSYPD2yv/puF0ssCbcpZBWsZgYU=; b=LbkJBaRl/AlE8I18lj7+krmeFNQ25/eI+ZGJVE5Qey7AKNN5kKGteqjAIZDofyo4nN MYeFtaJjCYak3Bp18sUQdtAZiOpSySb56U8N8i2gJPu0A55CTYG0MNV5JJTBOb/5cJLv TIEECms45jvmlCVHLxojMweK6aZJXGmb8AFXo3VgWXFZxoNc8oMq76kKhO1aubh0A7TP KLlSdIGO59Mja5TSywujxi2/5/j1TXXd8D/gcs2Z5FdYNFp1gunPT5LjvuG8AIMGF54R +r/ZNTBYPgCs8nqktd+w7gWXYowrxvUXiVo6lK+/iuB/Z2RCIlCEh9qN+MwIpOmcLYXf a3LQ== X-Forwarded-Encrypted: i=1; AJvYcCXUV3goaRvpAZzm8wcLNO19KYB6pe5Xmxk8OqNIN70B1khA9n5xPMUP2H11EV4UdQPgRdhB3IAygAh+fXY=@vger.kernel.org X-Gm-Message-State: AOJu0YwU9qb2yuyQqjw8iVQjYKp1yxTwUEH/1lnAgynvUsAKir1oyiBJ GwojS3au2XHW91Jb9Oq83CsrpnqiPHDI5vX2yL/kEmSkJCBotvPuVayW X-Gm-Gg: AZuq6aKiYlDL55KuQ6duxKvCDPmD5udOuNcqrXgYBhgUg7/T/311U64yLoO2dcFVMRh E2YnlTa2JRi6lAOpXWFACGOpZdUoFK7M0gzYhmTFTdK3MOuthqVX7JOxipkAVU5+5WeHjzJFqfT yi1xd2X0w73kdJYSBaT/Cs8PvKcX8zQsql/3lSI9YAPr/X2+sFqTBG4v4mwgWp5+aVzscMlAEF5 3uE65ZQmuou4OWfDlIFpzh+V51Tho/Z2sfLfvM3ZArDLo+GUa6ikx3xvjDqIxbpCO9+gQIuWtgG xF/diZWhfqGWa4bFuAmZiN8uLzNDFVaK4ancwZ+qX0XPZ05hcY/yyuFOkahxsC9wsx/Ya1ZwnZr pbhfAdcGKk3dwqqgDeOvORh2LEvy5p4XyLldSMRSUyZc2RU18qw2lPiKvVwrnKansvLYNBM43uW FpMZTO/WyzI01D3oI= X-Received: by 2002:a05:600c:4448:b0:47b:d992:601e with SMTP id 5b1f17b1804b1-48370e2b6bemr23412015e9.2.1770979593031; Fri, 13 Feb 2026 02:46:33 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:419a:75c9:94a4:7ac3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d82a4c4sm444065575e9.10.2026.02.13.02.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 02:46:32 -0800 (PST) Date: Fri, 13 Feb 2026 12:46:29 +0200 From: Vladimir Oltean To: Markus Elfring Cc: Felix Gu , linux-phy@lists.infradead.org, Jyri Sarha , Kishon Vijay Abraham I , Neil Armstrong , Vinod Koul , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2] phy: ti: j721e-wiz: Fix device node reference leak in wiz_get_lane_phy_types() Message-ID: <20260213104629.q5pwqpsuficmx6qv@skbuf> References: <20260212-wiz-v2-1-6e8bd4cc7a4a@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Feb 13, 2026 at 09:09:55AM +0100, Markus Elfring wrote: > … > > --- > > Changes in v2: > > - Use of_node_put() suggested by Vladimir Oltean. > > - Link to v1: https://lore.kernel.org/r/20260211-wiz-v1-1-fdd018d02f33@gmail.com > > --- > > drivers/phy/ti/phy-j721e-wiz.c | 2 ++ > … > > * Would you like to complete the exception handling by using another goto chain? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.19#n526 While gotos have their place, here it seems simpler not to use them. Felix would have needed to move the "int ret" variable from the for_each_child_of_node_scoped() scope to the function scope, and initialize it with 0. All that is unnecessary complexity here. > * How do you think about to increase the application of scope-based resource management > by additional update steps? > https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/cleanup.h#L157-L161 The cleanup.h API does not exist in all kernels where this bug fix can be backported.