From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0431786334 for ; Fri, 13 Feb 2026 12:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770986086; cv=none; b=if9MM/kAPJ47KAw+VCAugTUFAiXpAIhzjylb7sIuZaOHX0EWx9V1+1lTcYdvI0Aq5GdikiXowHX0S2UyahGTEShsyN2ejqqkommh9Li+rhNsgKQ8q/7zrnxdai1UGT5utNlO7eFMOCwPsVnEDstOAs7MV0bX9cd1n8krb9U9uMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770986086; c=relaxed/simple; bh=ujIKrVzEY6Do2ivTe9kceiq7u+sA2AsBZ2VUpd/vNH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X2eoRm+Ax144o+yYPvEMFk0RhRvpXl6VeOPbTjpzD/epZJHBnI5Sla3bnGeLbtIK/WH1Nwv68AiYotbZS7PDgTY3CJ5I5QXR7wEcu+uP2ksG5g76U2FRz9iSoNaXXonC+uBZ4nx80HjfX8unPCHZeSmJV+cdDypMDvqI1amXNtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WWcFQmEo; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WWcFQmEo" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-385bc7a35ccso592321fa.1 for ; Fri, 13 Feb 2026 04:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770986083; x=1771590883; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ioLb8XY4lm+HDRaTUyW1eqWIZWMXPzLIWciFwGfc+MA=; b=WWcFQmEosjobM2f98D35XPDARoTGV/CtJWgM8O131mdTU5itpbkOTKMhNEY+hbTGA8 uKAKmxchWAwNT05SEP4rVcnIsjxxSFwXeEyfNA+JWmth4T7mzeZ/B+YLyZoEUMQhFBsa eTWaQHPk2RvNgi7y2gQlWDAzQSbrBEWSGNK8AUkVErlPZphz+jQg22AAQKaXbGq9mhfU Pjdkzt7gsV/zbvD7iKhtOezxJ4pJdwf4ilpohaCTB7AMVkkuB3vvWfuDtyVrPLhl2nPV 2tPG4DhSC7uBbBeamZpkf2gKHCvZNfY2HSD4pdOgt1eth0jtdBfIjV4dc/BxmWfIRLSq dZ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770986083; x=1771590883; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ioLb8XY4lm+HDRaTUyW1eqWIZWMXPzLIWciFwGfc+MA=; b=K65Ye0Fq0J3waTU9GFNNF5LRVvOR92T//6LQoIqamfzcdyqeNgiQ5M0UGRKkS6apSE ZByNZfU1dUoqu9rSyJLbeH1BzFuFJz7/hsiZDxWDjq0ID6dD/XYiPKN1I9A9NIuIRAUo Jdg4vgdpw5kfa3cqLRDl6EfZtJO0JZioyMAh2OWDt0RTe+QUPZpaXse3zqTPbBvgCcPu 1ssdQ5zAMSlzH2XFPqhfV4WA4zzKcrAn7PfoL/wa1oHSCGtTGBxqmPidaWlc+1ERQGpk Hiaqw3FFvCCb3YZM3bjwCmW6Ivf3wQ93e1hy3Tg+/7ifpETUGF7amyrcSwb5rgVEsmfz DQxA== X-Forwarded-Encrypted: i=1; AJvYcCVlA1tsqKflaw3UgTl9UlIkm3ceb6ZLf1VEtj8PRAeea0nSr7S8zc5GAb5D9ATZKE7wWAETYZj+GdDpzOI=@vger.kernel.org X-Gm-Message-State: AOJu0YxZhE+WkZ4I0KtT/dmBep46UZyPogXehw357eMQapDBq5KA0rXy KuqMLKA4SCY4hN1cr496QI72rhQPogU8WQ3qFLzqY1UaSVL3ItIvJSj6s+OQnQ== X-Gm-Gg: AZuq6aLdSaGfqh+kcCUj00TqMNbZzoVqSoPTXFRrprrGWZZPGbo3ZsUVDUHoejAFRnc RpPHq3TfNtmqkZkQ55XfDt+fU4EfHtrDve5TWdkHXhbQLgjrDi2a5XUtyBVBM6cxDDJgOlWXiPk itPIiqIKfaj8ypfb8dibPYd/+MDWLD3jEQgOABq6q7yf/b2U6ROpIHOh7SGu/sO1ZG0ZAFXb12u c5uM6+HSWGbUXFzjqXxgRWwyppJ2VmrcOpi1sSONBg8a1nZ+SyacN3xfnN05a8G9I4fmJJWzTqz fB0t8gdQBTDer7Yjc5JHEJ/Zd7hz904t/c+BmJlKMG1CIevSa2jULXzr9ww67f9KHCntMLMS5yG +pAWfxfQECptQtPpbIV9UHShPo8xg6R3xZCFSA1/pAGoDKKY8zeYgK8CnWHweMU4Yvr3oNp8oj4 HgE0j8AJ+39f2leu4= X-Received: by 2002:a05:6000:184a:b0:435:f96f:3517 with SMTP id ffacd0b85a97d-43796ad9062mr2306714f8f.3.1770979632393; Fri, 13 Feb 2026 02:47:12 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:419a:75c9:94a4:7ac3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a5b4cdsm5075131f8f.8.2026.02.13.02.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 02:47:11 -0800 (PST) Date: Fri, 13 Feb 2026 12:47:09 +0200 From: Vladimir Oltean To: Felix Gu Cc: Vinod Koul , Neil Armstrong , Kishon Vijay Abraham I , Jyri Sarha , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Markus Elfring Subject: Re: [PATCH v2] phy: ti: j721e-wiz: Fix device node reference leak in wiz_get_lane_phy_types() Message-ID: <20260213104709.yim7a67uuzioj7n2@skbuf> References: <20260212-wiz-v2-1-6e8bd4cc7a4a@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260212-wiz-v2-1-6e8bd4cc7a4a@gmail.com> On Thu, Feb 12, 2026 at 06:39:19PM +0800, Felix Gu wrote: > The serdes device_node is obtained using of_get_child_by_name(), > which increments the reference count. However, it is never put, > leading to a reference leak. > > Add the missing of_node_put() calls to ensure the reference count is > properly balanced. > > Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver") > Suggested-by: Vladimir Oltean > Signed-off-by: Felix Gu > --- > Changes in v2: > - Use of_node_put() suggested by Vladimir Oltean. > - Link to v1: https://lore.kernel.org/r/20260211-wiz-v1-1-fdd018d02f33@gmail.com Reviewed-by: Vladimir Oltean