From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9333F2F9985 for ; Fri, 13 Feb 2026 22:32:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771021946; cv=none; b=hxrPQknIHMpKhp6Jdwc2qsYe3uCe4hcVY9yIoDOsgXMwGhMGlIc4qPb3DaNwGnA6G7lMtDm0W/AI+ugNuG7rf5eYmo8hddv5u+mByq9m++NyBQepYg3BfGAo8YoSEfkE0jWSBH9Uw0jvIKyloD7m2x1IgMXX3e0RY5feugMnZGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771021946; c=relaxed/simple; bh=QigO5K717byThetaj38bgtz6YLQk9cOFBuv9dpMoPGY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rq4Q4H0LBbEItRojQ7YHyQGyQ47sPIKMIxkTuOcdCF7GMqZmDm2//cH23E60d6KygE8GhBBQJfjNTmhb48JC9PwTxdL+Py34l3DT6+jBAHnLJHLMjknQkvVt9cCPxHvn0dznybEPa94sTV4QCKHHlh1BbjROdOKf/hPZ//T+nB8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AiuyVlEu; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AiuyVlEu" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-45f194e9a98so531223b6e.3 for ; Fri, 13 Feb 2026 14:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771021943; x=1771626743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gwOZ+fMN1u7ZAD04Sc+WiPH2zobZhFlc/QjDODp9/tM=; b=AiuyVlEuNZb3GiAPIk9VqQG+7eReq3GRfpgpb0R71hs+3W/keIgxp6ulrtM8ccvoHq FRMf/kG6b2UhV4ER4tCrTfLdwNT3RH6rQGtyFRoGepztXwKksybNcPvOui6lx0eCACaQ 2+SUm7wG27a/1Q+E63RX/5YPENPYZ4fETM09nd/dc3KbpfDGLgJoQ2qTx57UpvuMVOGW u3vmb5ud/gr/G9/vm5KSIC0f6qZI39cFz8bLpZEIH6wrYU5N95xsJ8TLcgVKgxLXaSop L0dNJJBnA1Ivbc2Cub3a1CQWO1q9Eg3DXT1CcmAGnbItzWQvmKsOHDyKWWoXEhuTO6Hb Aj8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771021943; x=1771626743; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gwOZ+fMN1u7ZAD04Sc+WiPH2zobZhFlc/QjDODp9/tM=; b=WacB46deZnKBr+o4WQz2X4AMMrKmAfFO/8LO3rlFqpxyKH24CUsTXohiibR/ebcvH9 0rOT3hOJ+okC6QA5hxm7VD6/nVurQPIytd+3bRBHdXG5VvlgdSFSZmGbQMMyHzf7qC9z kRKgOLyefKM4IZ+U4nlmJTymJxjR74e+Wgv5mgCwg36BPFmjQO0wSgxovLY3xqFx8B1N KZI/vo3D9I7u1vFziGZC4v0km/Bj/06ndo1pJebhlPs6FWWb5zB4IRTAN6t2bLTD9U53 M3087RkFP/RzbnslEYRs4ZbYHG7pBPS3ocXHgjO/RmNyPob2IsF76vyhsGR4cRcU79Hp qTjQ== X-Forwarded-Encrypted: i=1; AJvYcCW/lr9ExnC45I7fNB/Fh0Fy+b09T9EYZfqBb4yc7AQPXp64PYTLjBbGxUnWaMMdt9Fpp2wCFEIp7RMHWbo=@vger.kernel.org X-Gm-Message-State: AOJu0YxqSxNPATXSwWLLIRfJT8o82f8X6iT0dtcMCC3V+XPZ3OE8zUlB iCQ4b5ynmO2hB9kLMMIb0JLVuNzuk13FFqkg6CsauKSvcnzpzZakQpL8 X-Gm-Gg: AZuq6aIkipKB5B0rmupNDYPA8PfPH59WI2EL6gTIMAL5hQplQWVsnrncrWzVcCw4KBV Jk8Vb0G8WbP7+iyEJPkrou0Q41HtZeeflXOtyjjO6GHrDyDD4AlYbvzpTdB/gZ/7E1qS2V1GbOr Gm8T4vf+QFy07/ZXbAQ6iwhN9OiPVraeC8HsYvpTNDbuOByraiEJncr7l3L3TbagpllFPz+fC3l hmogXwEPi0P4m/pCYEgxsRQN5/wpx04y/TGXpMgAKKEofzfp2uo/aDwtq871T/yKFc4xtn3VDD+ SHyRXF1XTL39KLlLJpNYkZh9DcxDofvY0sx2HIPMz2Hk8HoeoSpt9M9FgZHDF3YJDJRdm6YcC4w fvH8cMZCEWocMMvkh2UBU69M1lvh4mXbB7YVMFiowx8WRa5u9ZiiDlf5UFS1DKCUMVreATP769M IBQhsMqmoEtmwI5BHw/i+afHClaUfFKC6hxTaLHmQ9/9TToJqwkd6gHsDamxsbCZh8EHOY0Ohwp 7FsmX4s9WPO87F47qEIZhlfIfNsh3K14FtyN4pEZFyDJoLsTgbWlTMrah58m3w= X-Received: by 2002:a05:6808:4fcd:b0:463:8a49:ca7a with SMTP id 5614622812f47-4639f245eedmr1381171b6e.52.1771021943296; Fri, 13 Feb 2026 14:32:23 -0800 (PST) Received: from james-x399.localdomain (71-218-105-26.hlrn.qwest.net. [71.218.105.26]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4636b0c8606sm5446923b6e.18.2026.02.13.14.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 14:32:22 -0800 (PST) From: James Hilliard To: linux-gpio@vger.kernel.org Cc: James Hilliard , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Saravana Kannan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] gpiolib: of: add gpio-line node support Date: Fri, 13 Feb 2026 15:32:01 -0700 Message-ID: <20260213223204.2415507-1-james.hilliard1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Allow GPIO controller child nodes marked with "gpio-line" to configure direction/flags at probe time without hogging the line. Teach OF gpiochip scanning and OF dynamic reconfiguration handlers to process gpio-line nodes in addition to gpio-hog nodes. Also parse "gpio-line-name" and apply it to desc->name. For gpio-hog nodes, keep "line-name" semantics as the hog consumer label. Signed-off-by: James Hilliard --- drivers/gpio/gpiolib-of.c | 89 ++++++++++++++++++++++++++++------- drivers/gpio/gpiolib-shared.c | 7 +-- drivers/of/property.c | 7 +-- scripts/dtc/checks.c | 4 +- 4 files changed, 82 insertions(+), 25 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index ef1ac68b94b7..b10a21a63d46 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -744,6 +744,7 @@ struct gpio_desc *of_find_gpio(struct device_node *np, const char *con_id, * @lflags: bitmask of gpio_lookup_flags GPIO_* values - returned from * of_find_gpio() or of_parse_own_gpio() * @dflags: gpiod_flags - optional GPIO initialization flags + * @hog: indicates if this is a gpio-hog node * * Returns: * GPIO descriptor to use with Linux GPIO API, or one of the errno @@ -753,11 +754,13 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np, struct gpio_chip *chip, unsigned int idx, const char **name, unsigned long *lflags, - enum gpiod_flags *dflags) + enum gpiod_flags *dflags, + bool hog) { struct device_node *chip_np; enum of_gpio_flags xlate_flags; struct of_phandle_args gpiospec; + const char *desc_name; struct gpio_desc *desc; unsigned int i; u32 tmp; @@ -797,15 +800,19 @@ static struct gpio_desc *of_parse_own_gpio(struct device_node *np, *dflags |= GPIOD_OUT_LOW; else if (of_property_read_bool(np, "output-high")) *dflags |= GPIOD_OUT_HIGH; - else { + else if (hog) { pr_warn("GPIO line %d (%pOFn): no hogging state specified, bailing out\n", desc_to_gpio(desc), np); return ERR_PTR(-EINVAL); } - if (name && of_property_read_string(np, "line-name", name)) + if (hog && name && of_property_read_string(np, "line-name", name)) *name = np->name; + if (!of_property_read_string(np, "gpio-line-name", &desc_name) && + desc_name[0]) + desc->name = desc_name; + return desc; } @@ -827,7 +834,8 @@ static int of_gpiochip_add_hog(struct gpio_chip *chip, struct device_node *hog) int ret; for (i = 0;; i++) { - desc = of_parse_own_gpio(hog, chip, i, &name, &lflags, &dflags); + desc = of_parse_own_gpio(hog, chip, i, &name, &lflags, &dflags, + true); if (IS_ERR(desc)) break; @@ -843,6 +851,36 @@ static int of_gpiochip_add_hog(struct gpio_chip *chip, struct device_node *hog) return 0; } +/** + * of_gpiochip_add_line - Configure all lines in a gpio-line device node + * @chip: gpio chip to act on + * @line: device node describing GPIO lines to configure + * + * Returns: + * 0 on success, or negative errno on failure. + */ +static int of_gpiochip_add_line(struct gpio_chip *chip, struct device_node *line) +{ + enum gpiod_flags dflags; + struct gpio_desc *desc; + unsigned long lflags; + unsigned int i; + int ret; + + for (i = 0;; i++) { + desc = of_parse_own_gpio(line, chip, i, NULL, &lflags, &dflags, + false); + if (IS_ERR(desc)) + break; + + ret = gpiod_configure_flags(desc, NULL, lflags, dflags); + if (ret < 0) + return ret; + } + + return 0; +} + /** * of_gpiochip_scan_gpios - Scan gpio-controller for gpio definitions * @chip: gpio chip to act on @@ -858,14 +896,22 @@ static int of_gpiochip_scan_gpios(struct gpio_chip *chip) int ret; for_each_available_child_of_node_scoped(dev_of_node(&chip->gpiodev->dev), np) { - if (!of_property_read_bool(np, "gpio-hog")) + if (of_property_read_bool(np, "gpio-hog")) { + ret = of_gpiochip_add_hog(chip, np); + if (ret < 0) + return ret; + + of_node_set_flag(np, OF_POPULATED); continue; + } - ret = of_gpiochip_add_hog(chip, np); - if (ret < 0) - return ret; + if (of_property_read_bool(np, "gpio-line")) { + ret = of_gpiochip_add_line(chip, np); + if (ret < 0) + return ret; - of_node_set_flag(np, OF_POPULATED); + of_node_set_flag(np, OF_POPULATED); + } } return 0; @@ -905,14 +951,15 @@ static int of_gpio_notify(struct notifier_block *nb, unsigned long action, int ret; /* - * This only supports adding and removing complete gpio-hog nodes. - * Modifying an existing gpio-hog node is not supported (except for - * changing its "status" property, which is treated the same as - * addition/removal). + * This only supports adding and removing complete gpio-hog and + * gpio-line nodes. Modifying an existing node is not supported + * (except for changing its "status" property, which is treated + * the same as addition/removal). */ switch (of_reconfig_get_state_change(action, arg)) { case OF_RECONFIG_CHANGE_ADD: - if (!of_property_read_bool(rd->dn, "gpio-hog")) + if (!of_property_read_bool(rd->dn, "gpio-hog") && + !of_property_read_bool(rd->dn, "gpio-line")) return NOTIFY_DONE; /* not for us */ if (of_node_test_and_set_flag(rd->dn, OF_POPULATED)) @@ -922,9 +969,12 @@ static int of_gpio_notify(struct notifier_block *nb, unsigned long action, if (!gdev) return NOTIFY_DONE; /* not for us */ - ret = of_gpiochip_add_hog(gpio_device_get_chip(gdev), rd->dn); + if (of_property_read_bool(rd->dn, "gpio-hog")) + ret = of_gpiochip_add_hog(gpio_device_get_chip(gdev), rd->dn); + else + ret = of_gpiochip_add_line(gpio_device_get_chip(gdev), rd->dn); if (ret < 0) { - pr_err("%s: failed to add hogs for %pOF\n", __func__, + pr_err("%s: failed to configure lines for %pOF\n", __func__, rd->dn); of_node_clear_flag(rd->dn, OF_POPULATED); return notifier_from_errno(ret); @@ -932,6 +982,10 @@ static int of_gpio_notify(struct notifier_block *nb, unsigned long action, return NOTIFY_OK; case OF_RECONFIG_CHANGE_REMOVE: + if (!of_property_read_bool(rd->dn, "gpio-hog") && + !of_property_read_bool(rd->dn, "gpio-line")) + return NOTIFY_DONE; /* not for us */ + if (!of_node_check_flag(rd->dn, OF_POPULATED)) return NOTIFY_DONE; /* already depopulated */ @@ -939,7 +993,8 @@ static int of_gpio_notify(struct notifier_block *nb, unsigned long action, if (!gdev) return NOTIFY_DONE; /* not for us */ - of_gpiochip_remove_hog(gpio_device_get_chip(gdev), rd->dn); + if (of_property_read_bool(rd->dn, "gpio-hog")) + of_gpiochip_remove_hog(gpio_device_get_chip(gdev), rd->dn); of_node_clear_flag(rd->dn, OF_POPULATED); return NOTIFY_OK; } diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c index b3525d1f06a4..b934e58a07f0 100644 --- a/drivers/gpio/gpiolib-shared.c +++ b/drivers/gpio/gpiolib-shared.c @@ -147,10 +147,11 @@ static bool gpio_shared_of_node_ignore(struct device_node *node) return true; /* - * GPIO hogs have a "gpios" property which is not a phandle and can't - * possibly refer to a shared GPIO. + * GPIO hog and gpio-line nodes have a "gpios" property which is not a + * phandle and can't possibly refer to a shared GPIO. */ - if (of_property_present(node, "gpio-hog")) + if (of_property_present(node, "gpio-hog") || + of_property_present(node, "gpio-line")) return true; return false; diff --git a/drivers/of/property.c b/drivers/of/property.c index 50d95d512bf5..7689c4315115 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1435,10 +1435,11 @@ static struct device_node *parse_gpio_compat(struct device_node *np, return NULL; /* - * Ignore node with gpio-hog property since its gpios are all provided - * by its parent. + * Ignore nodes with gpio-hog and gpio-line properties since their gpios + * are all provided by their parent. */ - if (of_property_read_bool(np, "gpio-hog")) + if (of_property_read_bool(np, "gpio-hog") || + of_property_read_bool(np, "gpio-line")) return NULL; if (of_parse_phandle_with_args(np, prop_name, "#gpio-cells", index, diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c index 45d0213f3bf3..ee64cb4ada4f 100644 --- a/scripts/dtc/checks.c +++ b/scripts/dtc/checks.c @@ -1533,8 +1533,8 @@ static void check_gpios_property(struct check *c, { struct property *prop; - /* Skip GPIO hog nodes which have 'gpios' property */ - if (get_property(node, "gpio-hog")) + /* Skip gpio-hog and gpio-line nodes which have 'gpios' property */ + if (get_property(node, "gpio-hog") || get_property(node, "gpio-line")) return; for_each_property(node, prop) { -- 2.43.0