mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mohamed Khalfella <mkhalfella@purestorage.com>
To: Justin Tee <justin.tee@broadcom.com>,
	Naresh Gottumukkala <nareshgottumukkala83@gmail.com>,
	Paul Ely <paul.ely@broadcom.com>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
	James Smart <jsmart833426@gmail.com>,
	Hannes Reinecke <hare@suse.de>
Cc: Aaron Dailey <adailey@purestorage.com>,
	Randy Jennings <randyj@purestorage.com>,
	Dhaval Giani <dgiani@purestorage.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Mohamed Khalfella <mkhalfella@purestorage.com>
Subject: [PATCH v3 18/21] nvme: Update CCR completion wait timeout to consider CQT
Date: Fri, 13 Feb 2026 20:25:19 -0800	[thread overview]
Message-ID: <20260214042753.4073668-19-mkhalfella@purestorage.com> (raw)
In-Reply-To: <20260214042753.4073668-1-mkhalfella@purestorage.com>

TP8028 Rapid Path Failure Recovery does not define how much time the
host should wait for CCR operation to complete. It is reasonable to
assume that CCR operation can take up to ctrl->cqt. Update wait time for
CCR operation to be max(ctrl->cqt, ctrl->kato).

Signed-off-by: Mohamed Khalfella <mkhalfella@purestorage.com>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 0680d05900c1..ff479c0263ab 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -631,7 +631,7 @@ static int nvme_issue_wait_ccr(struct nvme_ctrl *sctrl, struct nvme_ctrl *ictrl)
 	if (result & 0x01) /* Immediate Reset Successful */
 		goto out;
 
-	tmo = secs_to_jiffies(ictrl->kato);
+	tmo = msecs_to_jiffies(max(ictrl->cqt, ictrl->kato * 1000));
 	if (!wait_for_completion_timeout(&ccr.complete, tmo)) {
 		ret = -ETIMEDOUT;
 		goto out;
-- 
2.52.0


  parent reply	other threads:[~2026-02-14  4:28 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14  4:25 [PATCH v3 00/21] TP8028 Rapid Path Failure Recovery Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 01/21] nvmet: Rapid Path Failure Recovery set controller identify fields Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 02/21] nvmet/debugfs: Export controller CIU and CIRN via debugfs Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 03/21] nvmet: Implement CCR nvme command Mohamed Khalfella
2026-02-27 16:30   ` Maurizio Lombardi
2026-03-25 18:52     ` Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 04/21] nvmet: Implement CCR logpage Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 05/21] nvmet: Send an AEN on CCR completion Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 06/21] nvme: Rapid Path Failure Recovery read controller identify fields Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 07/21] nvme: Introduce FENCING and FENCED controller states Mohamed Khalfella
2026-02-16 12:33   ` Hannes Reinecke
2026-02-14  4:25 ` [PATCH v3 08/21] nvme: Implement cross-controller reset recovery Mohamed Khalfella
2026-02-16 12:41   ` Hannes Reinecke
2026-02-17 18:35     ` Mohamed Khalfella
2026-02-26  2:37   ` Randy Jennings
2026-03-27 18:33     ` Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 09/21] nvme: Implement cross-controller reset completion Mohamed Khalfella
2026-02-16 12:43   ` Hannes Reinecke
2026-02-17 18:25     ` Mohamed Khalfella
2026-02-18  7:51       ` Hannes Reinecke
2026-02-18 12:47         ` Mohamed Khalfella
2026-02-20  3:34           ` Randy Jennings
2026-02-14  4:25 ` [PATCH v3 10/21] nvme-tcp: Use CCR to recover controller that hits an error Mohamed Khalfella
2026-02-16 12:47   ` Hannes Reinecke
2026-02-14  4:25 ` [PATCH v3 11/21] nvme-rdma: " Mohamed Khalfella
2026-02-16 12:47   ` Hannes Reinecke
2026-02-14  4:25 ` [PATCH v3 12/21] nvme-fc: Decouple error recovery from controller reset Mohamed Khalfella
2026-02-28  0:12   ` James Smart
2026-03-26  2:37     ` Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 13/21] nvme-fc: Use CCR to recover controller that hits an error Mohamed Khalfella
2026-02-28  1:03   ` James Smart
2026-03-26 17:40     ` Mohamed Khalfella
2026-05-16  0:45       ` Randy Jennings
2026-02-14  4:25 ` [PATCH v3 14/21] nvme-fc: Hold inflight requests while in FENCING state Mohamed Khalfella
2026-02-27  2:49   ` Randy Jennings
2026-02-28  1:10   ` James Smart
2026-02-14  4:25 ` [PATCH v3 15/21] nvme-fc: Do not cancel requests in io taget before it is initialized Mohamed Khalfella
2026-02-28  1:12   ` James Smart
2026-02-14  4:25 ` [PATCH v3 16/21] nvmet: Add support for CQT to nvme target Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 17/21] nvme: Add support for CQT to nvme host Mohamed Khalfella
2026-02-14  4:25 ` Mohamed Khalfella [this message]
2026-02-16 12:54   ` [PATCH v3 18/21] nvme: Update CCR completion wait timeout to consider CQT Hannes Reinecke
2026-02-16 18:45     ` Mohamed Khalfella
2026-02-17  7:09       ` Hannes Reinecke
2026-02-17 15:35         ` Mohamed Khalfella
2026-02-20  1:22           ` James Smart
2026-02-20  2:11             ` Randy Jennings
2026-02-20  7:23             ` Hannes Reinecke
2026-02-20  2:01           ` Randy Jennings
2026-02-20  7:25             ` Hannes Reinecke
2026-02-27  3:05               ` Randy Jennings
2026-03-02  7:32                 ` Hannes Reinecke
2026-02-14  4:25 ` [PATCH v3 19/21] nvme-tcp: Extend FENCING state per TP4129 on CCR failure Mohamed Khalfella
2026-02-16 12:56   ` Hannes Reinecke
2026-02-17 17:58     ` Mohamed Khalfella
2026-02-18  8:26       ` Hannes Reinecke
2026-02-14  4:25 ` [PATCH v3 20/21] nvme-rdma: " Mohamed Khalfella
2026-02-14  4:25 ` [PATCH v3 21/21] nvme-fc: " Mohamed Khalfella
2026-02-28  1:20   ` James Smart
2026-03-25 19:07     ` Mohamed Khalfella
2026-04-01 13:33 ` [PATCH v3 00/21] TP8028 Rapid Path Failure Recovery Achkinazi, Igor
2026-04-01 16:37   ` Mohamed Khalfella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260214042753.4073668-19-mkhalfella@purestorage.com \
    --to=mkhalfella@purestorage.com \
    --cc=adailey@purestorage.com \
    --cc=axboe@kernel.dk \
    --cc=dgiani@purestorage.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jsmart833426@gmail.com \
    --cc=justin.tee@broadcom.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nareshgottumukkala83@gmail.com \
    --cc=paul.ely@broadcom.com \
    --cc=randyj@purestorage.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®