From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D869B26D4CA for ; Sat, 14 Feb 2026 12:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771072853; cv=none; b=oUlBGeRaPaP48jaq4L4tmFlABP+bJrxEjTPThE3+A3Sl+2MjLFHGA43PM88Af+xxgjKSz3VcoziJ4bcF1cw2JiQAdcJyiCccozM+h7lCSLpg1yp9VMVpPZg+/1EvJ+ghcJ7gwmH3Ae3dHSKGeXBIxlAHs8pVYXmaoTVW3SmB9zA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771072853; c=relaxed/simple; bh=kUZ3TAp/44GbGN69+FneMpT4zG8HXhDlDcPA1PDxXd8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VtkARb6+Ckx56PmnZGE5RVPpYXApMot4G+IBFOArTJOthMcP7YcD64U6VNdl603rREzFFc2Nx3INYF/+IULJSGSClVjedG/uwknPRiaKLOQ+2fQZF84dbFdrs50jthPhsEqaqFPEzcQpv0efUj91S+OrHiq7fCItszS5CYBqoYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RwwadwWy; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RwwadwWy" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-34c93e0269cso2603430a91.1 for ; Sat, 14 Feb 2026 04:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771072852; x=1771677652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=K4gRHmoXRE/fcFPdbacL9d9KCJ6JNq7p//h36U0/+hs=; b=RwwadwWyNxlHX+EkQqbJB9JpybnDui2N7keDPf7ILW444Pc3mGuEz1i3+reDQGz3P0 lEJndqlGbQYM9jMxqEXrmzUmgYu28z0gqpbnzawAF9XAgL5qiS4FUWu7Ua/yARh09Zvr rYLiZ9D4nleLlDlrRbYNQHOZuXbrEzvWpF/Rze+O1eLwnpA/SrazPSxLN45D2MUEs1kt 87o7fc1jywidnYPGoXzMGOzG3s4WTJMzzS2plx+TTNZFCxRYjjGx+vnWvGG7tqsvmr/b I8ck0CxyO5ZJX3WdzpT3FdSGekpldUETyf+/fQMJO1zjOc6Q7oft24owdVw+vqoO9lch PNWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771072852; x=1771677652; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K4gRHmoXRE/fcFPdbacL9d9KCJ6JNq7p//h36U0/+hs=; b=Yx7YoYVB22xV/PcsIR5KjtQXw4Yvkj93Zfpbx+Xy/3e4N7kKuIl9WIESmojNUKIOPu LJwjhLmcWByXblj4/j1VmaWgvYsnF8LU4S+CLXWqKWr8lA1tO5QOrHlg+IVPi6i1yO7Z 5DtXToEX7OiChqscvcod6W4CSZxr/Piq8RgEuwJBcPjqVQF6pglRCycr+Uqsr4ERlY7m tuo8wgHNCzmz6M5/cX+Yw52b827F6bW1s+kC5NI6Vn42RWKRi+eGrLqtX47wrFRnbgXw 6c0h6XICnFREdkvXC4F4stY0k3hDocg3Ryh6HnikmLHzuWohJ1wktXFFBXPeXPDE2MZW +pCw== X-Gm-Message-State: AOJu0Yx4aW1B6rLXrjnBeSrOfmaUpmM8XQ5FuP69zhAUJZXnfZDhIEUs BkZWReDm+9kP/eo3a/ndKAjjxa1xzn0TK0DWa05C8RPtxQPIckF+GIdO X-Gm-Gg: AZuq6aIB0ojWInQajm+4XjjRWvQgPoY1sVptjRI/YGin7K2Lm80dairABfjx/x2eg6f sl3XztA3UJfGSIRhu+N2qMq72H4b2KdkaIEKO8DXd21lA8BVtlYmohq7rEbsYLpGqNd+B42jiV1 VoU65WTu1qP5nWV8k2NrByX5sY1+CBPkoGMZegY9yRjh4e59wJUdCAjEq42HW2y8LCok8T8ly13 PC8B13fTHOQfnJphS9aTHkYAOA5Tj1foTeB6kWsf5aO0W3eJr21iAGHV7CYFmGdNUZ5OXpdugz1 krozsGIl78/1ToAl72rzdQsbhRSuFgMpJ2enJH5M6gV7x0J2NAYRmt7+Vz+0Ji70x9caDE/j4T/ BVqWxtct5REHwaX1RgC7gs3Ln/aXI7bBYD5R9trYteo9ET98obh/M9j85hByJPfpL8rUtb42+FX 7upckxMXnqi4fDIyzfsw4x9IM2FgzyTIUlAjFxUIWaEc9ZsHrnLRkE X-Received: by 2002:a17:90b:2544:b0:356:256c:4bf0 with SMTP id 98e67ed59e1d1-357b51d0e56mr2341557a91.17.1771072852134; Sat, 14 Feb 2026 04:40:52 -0800 (PST) Received: from localhost.localdomain ([113.218.252.61]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a2e40bsm7064497b3a.11.2026.02.14.04.40.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 14 Feb 2026 04:40:51 -0800 (PST) From: Chengkaitao To: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, yangfeng@kylinos.cn, alexei.starovoitov@gmail.com Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Kaitao Cheng Subject: [PATCH RESEND v7 0/5] bpf: Expand the usage scenarios of bpf_kptr_xchg Date: Sat, 14 Feb 2026 20:40:37 +0800 Message-ID: <20260214124042.62229-1-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kaitao Cheng When using bpf_kptr_xchg, we triggered the following error: 31: (85) call bpf_kptr_xchg#194 function calls are not allowed while holding a lock bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/5]. When writing test cases using bpf_kptr_xchg and bpf_rbtree_*, the following approach must be followed: bpf_spin_lock(&lock); rb_n = bpf_rbtree_root(&root); while (rb_n && can_loop) { rb_n = bpf_rbtree_remove(&root, rb_n); if (!rb_n) goto fail; tnode = container_of(rb_n, struct tree_node, node); node_data = bpf_kptr_xchg(&tnode->node_data, NULL); if (!node_data) goto fail; data = node_data->data; /* use data to do something */ node_data = bpf_kptr_xchg(&tnode->node_data, node_data); if (node_data) goto fail; bpf_rbtree_add(&root, rb_n, less); if (lookup_key < tnode->key) rb_n = bpf_rbtree_left(&root, rb_n); else rb_n = bpf_rbtree_right(&root, rb_n); } bpf_spin_unlock(&lock); The above illustrates a lock-remove-read-add-unlock workflow, which exhibits lower performance. To address this, we introduced support for a streamlined lock-read-unlock operation in [patch 2/5] and [patch 4/5]. Changes in v7: - Add a comma to the variable declaration in enum bpf_reg_type - Modify the prefixes Changes in v6: - allow using bpf_kptr_xchg even if the MEM_RCU flag is set - Add test case Changes in v5: - add lastname Changes in v4: - Fix the dead logic issue in the test case Changes in v3: - Fix compilation errors Changes in v2: - Allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set - Add test case Link to v6: https://lore.kernel.org/all/20260208024846.18653-1-pilgrimtao@gmail.com/ Link to v5: https://lore.kernel.org/all/20260203022712.99347-1-pilgrimtao@gmail.com/ Link to v4: https://lore.kernel.org/all/20260202090051.87802-1-pilgrimtao@gmail.com/ Link to V3: https://lore.kernel.org/all/20260202055818.78231-1-pilgrimtao@gmail.com/ Link to V2: https://lore.kernel.org/all/20260201031607.32940-1-pilgrimtao@gmail.com/ Link to V1: https://lore.kernel.org/all/20260122081426.78472-1-pilgrimtao@gmail.com/ Kaitao Cheng (5): bpf: allow calling bpf_kptr_xchg while holding a lock bpf: allow using bpf_kptr_xchg even if the NON_OWN_REF flag is set selftests/bpf: Add supplementary tests for bpf_kptr_xchg bpf: allow using bpf_kptr_xchg even if the MEM_RCU flag is set selftests/bpf: Add test case for rbtree nodes that contain both bpf_refcount and kptr fields. kernel/bpf/verifier.c | 9 +- .../testing/selftests/bpf/prog_tests/rbtree.c | 6 + tools/testing/selftests/bpf/progs/bpf_misc.h | 4 + .../selftests/bpf/progs/rbtree_search_kptr.c | 290 ++++++++++++++++++ 4 files changed, 307 insertions(+), 2 deletions(-) create mode 100644 tools/testing/selftests/bpf/progs/rbtree_search_kptr.c -- 2.50.1 (Apple Git-155)