From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E49527F01B; Sat, 14 Feb 2026 16:25:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771086337; cv=none; b=U9BweXKBQkfkP0m8WnJ4cjMNUkoBwYrW51rtBMkYS0MyaEhWSSwzsXOPaTBlh5Bg/aBzsm2vzM0TqkkiJ1+xnhMbtGAxNYTygbTe2PZERH9I73VYVZYjNlJWyMctEQlT5aHBMSuw4XWewMvKA3FjYwL0cyRimThic5x/p7VAcQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771086337; c=relaxed/simple; bh=++K7Jh2/PdXRpr5vpBiYZxaBs2vCGEUXKFF6g8fxMKk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OuGnIhYVGN8zOjWE4pQNCMBUpmHBceSqReVN8CofJxDvsQlsqUWP7lSd4UcovTGI/nHg99Hrr8wNgGU0/4DSUcLQ+GLGf4QXAOunX1cPZYE2mVTnpbsYR+hNlM543djXpJ0FbRJh0dksfzXoGuIB1upTo0HmwCNR/j9MJavpdR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RuZDC4L6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RuZDC4L6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B68A6C16AAE; Sat, 14 Feb 2026 16:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771086337; bh=++K7Jh2/PdXRpr5vpBiYZxaBs2vCGEUXKFF6g8fxMKk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RuZDC4L6qWNYU/RQJ/8V1IDzFWNAkpRJ1GKLqTuP8wxkGoSal9GfJtg1ZVfjybv7z 8cQNpwZUgMgJ/0xwiVQC84+VahGCZdU74AvEoK7mls5FVR+JboTozi1fB+YDNsEA0W 1DtWDFvzCsjnA65/FR++bnJA8iJbDD9kZjLIrFfkA3UJYgQnoeRb1JJfqrCrLK2MOc GIgLhDdusw+NExykSKjbzBOW0lWOFDm48lLng92VnNdWA/msOX9dLwA+yl2hWDyuj0 4nJjB4SIJOfC3HPlH6vmL2pO6Mp+KIjASJMvfAUbSGYQmu/DVpMPaMYhd2zXXXuY36 ZlOkxcQvdw0og== Date: Sat, 14 Feb 2026 16:25:26 +0000 From: Jonathan Cameron To: Andy Shevchenko Cc: 434779359@qq.com, David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Liam Girdwood , Mark Brown , Linus Walleij , Bartosz Golaszewski , liufulin , Waqar Hameed , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] tof: Add VL53L4CX TOF drivers Message-ID: <20260214162526.01e1e336@jic23-huawei> In-Reply-To: References: <20260207134950.0f064905@jic23-huawei> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 8 Feb 2026 15:13:23 +0200 Andy Shevchenko wrote: > On Sat, Feb 07, 2026 at 01:49:50PM +0000, Jonathan Cameron wrote: > > On Sat, 7 Feb 2026 17:42:35 +0800 > > 434779359@qq.com wrote: > > > > This patch adds support for the vl53l4cx tof ic > > > ICs used in Qualcomm reference designs > > > > > > Signed-off-by: liufulin > > Hi Frank and welcome to IIO. > > > > This is a massive commit. Normally roughly speaking each commit should > > be an absolute maximum of 500-1000 lines of code because this what > > people can realistically review in one go. > > > > I'll take a superficial look at what you have here but to make any > > progress towards upstream it will need stripping back to a much more > > minimalist base. From that we we can then look at adding more features > > in future patch sets. > > > > Note the largest drivers for what I'd expect to be a lot more complex > > than a time of flight sensor are not as large as this in terms of > > lines of code. > > Yeah, this is even barely satisfies requirement to put into staging/iio. Just to cut off any chance of wrong interpretation: We don't put new devices through staging/iio any more. There is little reason to do so now that the core is out of there and mass refactors and ABI changes are a thing of the distant past. Now it's much swifter to clean a driver up on list. Maybe there is a reason we might consider drivers/staging again for IIO device drivers, but I've not thought of it yet! Jonathan > It has so-o-o many style issues and other small things (I just pressed PgDn > several times within 5 seconds). You need to take your time and invest into: > - creating an upstream plan (roadmap) > - as Jonathan said, start with a minimalistic setup (not more than a couple of > thousands of LoCs > - be sure the style follows the Coding Style and IIO subsystem specifics > - be sure the code uses modern APIs from kernel and not some outdated stuff > > ... > > > For the full series, stay under 2000 lines or in practice it won't get > > reviewed. > > Fun fact, I answered above without looking at the rest of the message. > >