mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Marius Cristea" <marius.cristea@microchip.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: frequency: adf4350: Return -ENOMEM on memory allocation failure
Date: Sat, 14 Feb 2026 19:36:55 +0000	[thread overview]
Message-ID: <20260214193655.01f75842@jic23-huawei> (raw)
In-Reply-To: <CAHp75Vdy=0+RF=4OSa-p_kkAkqqBZHOUv=nZ7sF3PjajfTr6mA@mail.gmail.com>

On Wed, 11 Feb 2026 19:39:43 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Feb 11, 2026 at 7:10 PM Antoniu Miclaus
> <antoniu.miclaus@analog.com> wrote:
> >
> > adf4350_parse_dt() returns NULL only when devm_kzalloc() fails. The
> > caller should return -ENOMEM in this case, not -EINVAL.  
> 
> Right, and the memory allocator dumps enough info if it happens.
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
I dropped the fixes tag as seems inappropriate for something that doesn't
happen except in the death throws of a platform and where it only gave
a wrong error code.  With that gone, applied.

Thanks,

Jonathan

> 
> ...
> 
> >                 pdata = dev_get_platdata(&spi->dev);  
> 
> Side note: Have you considered killing legacy platform data?
> 


      reply	other threads:[~2026-02-14 19:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 17:10 Antoniu Miclaus
2026-02-11 17:39 ` Andy Shevchenko
2026-02-14 19:36   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260214193655.01f75842@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=dlechner@baylibre.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marius.cristea@microchip.com \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®