From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from forward203a.mail.yandex.net (forward203a.mail.yandex.net [178.154.239.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F962C21FF for ; Sun, 15 Feb 2026 10:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.90 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771149868; cv=none; b=mGgNPzq16LHvhBQigJog5oNnd5HiftTYIRIK1CaW8sOIS0xhedDRXSr1zGfeVVmhGUupVYfaIQ5L7xrHtSpXD49OqZBuhTBTMwY8Uhe4Sjrw65l0UB8p90Q7ikdi0B5O8rsI0wjlC9bWbVmTzPx+D7FE/EzDzTjjH0vuDnRLM0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771149868; c=relaxed/simple; bh=LncKWgSHAlVUnxEINBVcm2q1LhKQysK2IjGnin5C4JQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=g7hgDkXgKjZ+1pomqW1Co6nRhTuQ7tr8GRXLwPOJp9di4vjPU3wd0ndx79aQpODz/24gmiBzll/wvja80emfaVujM+HjoPt7roBCCdsiQRFP5MSYwBNCsVYvx5vj47Lv+/EHMRsdd/gN6Wi+aOYQ9HK7C0BLba6/2TCYW4xYVfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=onurozkan.dev; spf=pass smtp.mailfrom=onurozkan.dev; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b=SP34syZG; arc=none smtp.client-ip=178.154.239.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onurozkan.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=onurozkan.dev header.i=@onurozkan.dev header.b="SP34syZG" Received: from forward100a.mail.yandex.net (forward100a.mail.yandex.net [IPv6:2a02:6b8:c0e:500:1:45:d181:d100]) by forward203a.mail.yandex.net (Yandex) with ESMTPS id 8910683B5C for ; Sun, 15 Feb 2026 13:04:19 +0300 (MSK) Received: from mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:582e:0:640:200:0]) by forward100a.mail.yandex.net (Yandex) with ESMTPS id AAC16C01C8; Sun, 15 Feb 2026 13:04:10 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id j3UBeWUGPiE0-iAOvSvzo; Sun, 15 Feb 2026 13:04:09 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onurozkan.dev; s=mail; t=1771149849; bh=U6+sQXT3njLPQ8KohNJXrXJPRvqzIkn4onxixnNBYnA=; h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From; b=SP34syZG9uV727kbJf1JQvSVgQLRscDxQmMfQtPTHeLozEOJQB3pti7TZVN7eO9zF RbQm8ahOD2m4Is1UJw8plbFw493oqiuzGjQSWPRaRNf+QjdAmJv53yGJNqFz7nW5hq aNThQjzcQhrlLaJhUP5AGzWQJxF6tRHJTdF3G6U0= Authentication-Results: mail-nwsmtp-smtp-production-main-55.vla.yp-c.yandex.net; dkim=pass header.i=@onurozkan.dev From: =?UTF-8?q?Onur=20=C3=96zkan?= To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: =?UTF-8?q?Onur=20=C3=96zkan?= Subject: [PATCH v1 2/2] drm/panthor: treat sram as mandatory except mt8196 Date: Sun, 15 Feb 2026 13:02:51 +0300 Message-ID: <20260215100302.136719-2-work@onurozkan.dev> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260215100302.136719-1-work@onurozkan.dev> References: <20260215100302.136719-1-work@onurozkan.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If sram-supply is missing, Panthor falls back to a dummy regulator with a warning. This implicit behavior hides missing DT wiring behind regulator core fallback. Make SRAM handling explicit: require sram-supply for all Panthor compatibles except mt8196-mali where GPU supplies are intentionally managed outside Panthor and DT does not model sram-supply for that compatible. This keeps DT power modeling explicit and avoids relying on dummy-regulator fallback. Link: https://lore.kernel.org/all/20260213155937.6af75786@nimda/ Signed-off-by: Onur Özkan --- drivers/gpu/drm/panthor/panthor_devfreq.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c index 2249b41ca4af..5f6075f18fe3 100644 --- a/drivers/gpu/drm/panthor/panthor_devfreq.c +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c @@ -206,12 +206,17 @@ int panthor_devfreq_init(struct panthor_device *ptdev) * But without knowing if it's beneficial or not (in term of power * consumption), or how much it slows down the suspend/resume steps, * let's just keep regulators enabled for the device lifetime. + * + * Treat sram-supply as mandatory except for mt8196-mali. It manages + * SRAM outside Panthor so this driver must not require direct control + * over it. */ - ret = devm_regulator_get_enable_optional(dev, "sram"); - if (ret && ret != -ENODEV) { - if (ret != -EPROBE_DEFER) + if (!of_device_is_compatible(dev->of_node, "mediatek,mt8196-mali")) { + ret = devm_regulator_get_enable_optional(dev, "sram"); + if (ret) { DRM_DEV_ERROR(dev, "Couldn't retrieve/enable sram supply\n"); - return ret; + return ret; + } } opp = devfreq_recommended_opp(dev, &cur_freq, 0); -- 2.51.2