From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Peter Wang <peter.wang@mediatek.com>,
Stanley Jhu <chu.stanley@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Chaotian Jing <Chaotian.Jing@mediatek.com>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>,
kernel@collabora.com, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: [PATCH v7 04/23] scsi: ufs: mediatek: Move MTK_SIP_UFS_CONTROL to mtk_sip_svc.h
Date: Mon, 16 Feb 2026 14:37:37 +0100 [thread overview]
Message-ID: <20260216-mt8196-ufs-v7-4-b5f2907c6da7@collabora.com> (raw)
In-Reply-To: <20260216-mt8196-ufs-v7-0-b5f2907c6da7@collabora.com>
SMC commands used by multiple drivers need to live in a shared header
file somewhere to avoid code duplication. In order to rework the MPHY
reset control to be in the phy-mtk-ufs.c driver, both ufs-mediatek and
the phy driver need access to this command.
Move it to mtk_sip_svc.h, where other such command definitions already
live.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
drivers/ufs/host/ufs-mediatek-sip.h | 1 -
include/linux/soc/mediatek/mtk_sip_svc.h | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ufs/host/ufs-mediatek-sip.h b/drivers/ufs/host/ufs-mediatek-sip.h
index 7d17aedf6fb8..d627dfb4a766 100644
--- a/drivers/ufs/host/ufs-mediatek-sip.h
+++ b/drivers/ufs/host/ufs-mediatek-sip.h
@@ -11,7 +11,6 @@
/*
* SiP (Slicon Partner) commands
*/
-#define MTK_SIP_UFS_CONTROL MTK_SIP_SMC_CMD(0x276)
#define UFS_MTK_SIP_VA09_PWR_CTRL BIT(0)
#define UFS_MTK_SIP_DEVICE_RESET BIT(1)
#define UFS_MTK_SIP_CRYPTO_CTRL BIT(2)
diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h
index abe24a73ee19..7265ff2a6e2a 100644
--- a/include/linux/soc/mediatek/mtk_sip_svc.h
+++ b/include/linux/soc/mediatek/mtk_sip_svc.h
@@ -22,6 +22,9 @@
ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, MTK_SIP_SMC_CONVENTION, \
ARM_SMCCC_OWNER_SIP, fn_id)
+/* UFS related SMC call */
+#define MTK_SIP_UFS_CONTROL MTK_SIP_SMC_CMD(0x276)
+
/* DVFSRC SMC calls */
#define MTK_SIP_DVFSRC_VCOREFS_CONTROL MTK_SIP_SMC_CMD(0x506)
--
2.53.0
next prev parent reply other threads:[~2026-02-16 13:38 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 13:37 [PATCH v7 00/23] MediaTek UFS Cleanup and MT8196 Enablement Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 01/23] dt-bindings: phy: Add mediatek,mt8196-ufsphy variant Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 02/23] dt-bindings: ufs: mediatek,ufs: Complete the binding Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 03/23] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant Nicolas Frattaroli
2026-02-16 13:37 ` Nicolas Frattaroli [this message]
2026-02-16 13:37 ` [PATCH v7 05/23] phy: mediatek: ufs: Add support for resets Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 06/23] scsi: ufs: mediatek: Rework resets Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 07/23] scsi: ufs: mediatek: Rework 0.9V regulator Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 08/23] scsi: ufs: mediatek: Rework init function Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 09/23] scsi: ufs: mediatek: Rework the crypt-boost stuff Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 10/23] scsi: ufs: mediatek: Handle misc host voltage regulators Nicolas Frattaroli
2026-02-24 12:38 ` Peter Wang (王信友)
2026-02-24 12:41 ` AngeloGioacchino Del Regno
2026-02-25 7:19 ` Peter Wang (王信友)
2026-02-24 12:48 ` Mark Brown
2026-02-25 7:18 ` Peter Wang (王信友)
2026-02-25 7:20 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 11/23] scsi: ufs: mediatek: Rework probe function Nicolas Frattaroli
2026-02-24 12:40 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 12/23] scsi: ufs: mediatek: Remove vendor kernel quirks cruft Nicolas Frattaroli
2026-02-24 12:40 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 13/23] scsi: ufs: mediatek: Use the common PHY framework Nicolas Frattaroli
2026-02-24 12:41 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 14/23] scsi: ufs: mediatek: Remove mediatek,ufs-broken-rtc property Nicolas Frattaroli
2026-02-24 12:43 ` Peter Wang (王信友)
2026-02-25 12:51 ` Nicolas Frattaroli
2026-02-26 6:58 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 15/23] scsi: ufs: mediatek: Rework _ufs_mtk_clk_scale error paths Nicolas Frattaroli
2026-02-24 12:43 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 16/23] scsi: ufs: mediatek: Clean up logging prints Nicolas Frattaroli
2026-02-24 12:47 ` Peter Wang (王信友)
2026-02-25 13:05 ` Nicolas Frattaroli
2026-02-25 13:18 ` AngeloGioacchino Del Regno
2026-02-26 7:00 ` Peter Wang (王信友)
2026-02-26 10:45 ` AngeloGioacchino Del Regno
2026-03-03 8:06 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 17/23] scsi: ufs: mediatek: Rework ufs_mtk_wait_idle_state Nicolas Frattaroli
2026-02-25 10:32 ` Peter Wang (王信友)
2026-02-25 12:33 ` AngeloGioacchino Del Regno
2026-02-26 3:42 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 18/23] scsi: ufs: mediatek: Don't acquire dvfsrc-vcore twice Nicolas Frattaroli
2026-02-25 10:34 ` Peter Wang (王信友)
2026-02-25 12:37 ` AngeloGioacchino Del Regno
2026-02-26 3:45 ` Peter Wang (王信友)
2026-02-26 10:33 ` AngeloGioacchino Del Regno
2026-02-16 13:37 ` [PATCH v7 19/23] scsi: ufs: mediatek: Rework hardware version reading Nicolas Frattaroli
2026-02-25 10:34 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 20/23] scsi: ufs: mediatek: Back up idle timer in per-instance struct Nicolas Frattaroli
2026-02-25 10:35 ` Peter Wang (王信友)
2026-02-25 12:40 ` AngeloGioacchino Del Regno
2026-02-26 3:46 ` Peter Wang (王信友)
2026-02-26 10:36 ` AngeloGioacchino Del Regno
2026-03-03 8:01 ` Peter Wang (王信友)
2026-03-03 10:15 ` Nicolas Frattaroli
2026-02-16 13:37 ` [PATCH v7 21/23] scsi: ufs: mediatek: Remove ret local from link_startup_notify Nicolas Frattaroli
2026-02-25 10:36 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 22/23] scsi: ufs: mediatek: Remove undocumented "clk-scale-up-vcore-min" Nicolas Frattaroli
2026-02-25 10:37 ` Peter Wang (王信友)
2026-02-25 12:44 ` AngeloGioacchino Del Regno
2026-02-25 12:56 ` Nicolas Frattaroli
2026-02-26 6:59 ` Peter Wang (王信友)
2026-02-16 13:37 ` [PATCH v7 23/23] scsi: ufs: mediatek: Add MT8196 compatible, update copyright Nicolas Frattaroli
2026-02-25 10:38 ` Peter Wang (王信友)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260216-mt8196-ufs-v7-4-b5f2907c6da7@collabora.com \
--to=nicolas.frattaroli@collabora.com \
--cc=Chaotian.Jing@mediatek.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avri.altman@wdc.com \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louisalexis.eyraud@collabora.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=peter.wang@mediatek.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®