From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C35BE28468E for ; Mon, 16 Feb 2026 09:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771232702; cv=none; b=Z89IDnpW4IBAewJHmdFyvfasT0nM2M1il3DJgYn2NZZAjnmnnlmnjitJCCIhGHXT8xkhvCknX/GucIVII36fiiE9USs4WAvDszoA4dZB2eviQeu8z0OP8B4ZnazvwSjyoMVr1WkPp+fzIq0YNuT7RUn3Segb3RVmuozia+lfhRA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771232702; c=relaxed/simple; bh=38J3gPJENWo9tLMeXIYSN25dnAKHmMqv4zScsC3rwYI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EyZ7eknFD2ItymAgKh3kKdQfJ+spApF8q43ExfuJrFjGsR8XX/+MQCDnc0e6qfTcDkNB87du94VdXjq5huj1eajAM4j9VwzSpX9zijhY4bw99w1d5WnMBzdUB/10n+4gV2kO8MzjjvTvRSqba4fxokt+CWd0lF5oue45uQm18Vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B4EtwWDd; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B4EtwWDd" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43768aa6ab2so246808f8f.1 for ; Mon, 16 Feb 2026 01:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771232699; x=1771837499; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=em6VPs2GZRn54p6b2nYQwPaDQws0EFVjZBMU1Ysa5Vc=; b=B4EtwWDd3t185jp7iZq/NamlE+EI9X4cLcE4xzgmL9RBoOa4RwapdrMbIyygvoOweS G062pDCltCjKjk/blIuPvu4cJO/wUekNrmUAP3nfklJ/uZxGsQzpPzLsJT+UgNqMjkPL YVYjfaRB63Ee6Juf/hwFEmY3Aa17/OktpcqBo5QQPL1jxFWKSaW1eX2b+EUSNkmo3DwD vhtqu9mMAJc54pXJo87U0rbE+VzhLlGunZHvTqWuVwRh1D6fGe57P/Vd2g2QvDOadhMm 32Xu9IdnahTz3aRgXvIqpQQnw2vYM8cFtdHOJO50/n557yI+OItuq/WlRMM0GuAE4yHD zO3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771232699; x=1771837499; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=em6VPs2GZRn54p6b2nYQwPaDQws0EFVjZBMU1Ysa5Vc=; b=YKO1vZR6fJG2XC4CAjzkNwojHqluTRpS95iSW8VA2oOd1JZi76EliPSILbBCWApPxy lZ/+cQkWjbosGFnWfKYtr4rkws/uIJlMM4TB27oj6Lex2/D56d4RjFjG8l12MhNSQgmN IzgoubgbF0HIaYgh07YtzVAjXRJleF8JxlyKdLT1GX1GR8uFZFhgQqkcFkbJOohVEilZ KLReV8M9bcwNMMaPMvybQaDYLSOgifz2qWbJhsW+5XbFa/yCY1ehDoQMDiSnpvFGy+Fm lffrTog9VfcLBVo/mfWJYBJehyfKzMP+h2VDE8vYLMaPPdHieM553Tpw9r7HhqEL6vdP q7Ww== X-Forwarded-Encrypted: i=1; AJvYcCVr44zBOeUXRpYAFxdgKV7RD0qrI/bfmI/1+GjajU7xl7vpW1exuM5aAQpJRMy3eKy/XTPyapajTyxoefc=@vger.kernel.org X-Gm-Message-State: AOJu0YxmjlF0jTvVZHSqIKaNRaP+mlabldy4SqT9xRqwEhq6SifSY0Oj MnBH7fajs/8IqUJ9WqzsueJ2DrBd/wlwzbIDlI0n8SW9UxTh3Jw7D/uW X-Gm-Gg: AZuq6aJtb8oSOP5fGFbJr3N9uzvhH3UNPlEc/GaxFILd65KLSL/nnkRWDshf/T/rw4F D/mFDcAD99j9w64pOPbFMQARJnoRaRBIasXQq1BMQp2VwsP4LVoCkFJL04V+XLWMgjeSy8ER5R7 pxwxU1fI9gRjp9QVtipeoKD9owgvaTFkI6vSoheUug9arecOhDRRE65Xj9UuVmmfMwe9JnuvvzW X2qii9SaVhKneUPDTHHs/30qjg6wPhJm4AW6rr12YJa0LWbrDrL3bINtpGJHPQzIgst/un0m8td hMadQyHHd7l90yXuELQCUWu6JHEtUHdQLUQ7+f9Gvf9Ns23+l06bQmGXNkIJl5MUjNABmQPXoDq 9ynd2ajvvatV2iJdYwCJ2B1CmaYsa1PIgLjG96eHtzKhWC5ouI/LsLe/kqmp5ztHm9h40Ofv1tz 8Pc8KWqnxD/5yi6Q== X-Received: by 2002:a05:6000:2508:b0:437:72ce:8954 with SMTP id ffacd0b85a97d-43796af4d32mr10923244f8f.6.1771232698983; Mon, 16 Feb 2026 01:04:58 -0800 (PST) Received: from skbuf ([2a02:2f04:d501:d900:68e2:cc27:74c:c083]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8075sm24922456f8f.29.2026.02.16.01.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 01:04:58 -0800 (PST) Date: Mon, 16 Feb 2026 11:04:56 +0200 From: Vladimir Oltean To: Janne Grunau Cc: Sven Peter , Neal Gompa , Vinod Koul , Neil Armstrong , Philipp Zabel , asahi@lists.linux.dev, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dan Carpenter Subject: Re: [PATCH phy-next v2] phy: apple: apple: Use local variable for ioremap return value Message-ID: <20260216090456.23oko4jx5bcahq3p@skbuf> References: <20260215-phy-apple-resource-err-ptr-v2-1-e43c22453682@jannau.net> <20260215-phy-apple-resource-err-ptr-v2-1-e43c22453682@jannau.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260215-phy-apple-resource-err-ptr-v2-1-e43c22453682@jannau.net> <20260215-phy-apple-resource-err-ptr-v2-1-e43c22453682@jannau.net> On Sun, Feb 15, 2026 at 09:02:51AM +0100, Janne Grunau wrote: > The indirection through the resources array is unnecessarily complicated > and resuling in using IS_ERR() and PTR_ERR() on a valid address. A local > variable for the devm_ioremap_resource() return value is both easier to > read and matches expectations when reading code. > > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/asahi/aYXvX1bYOXtYCgfC@stanley.mountain/ > Suggested-by: Vladimir Oltean > Fixes: 8e98ca1e74db ("phy: apple: Add Apple Type-C PHY") > Signed-off-by: Janne Grunau > --- > Changes in v2: > - Use a local variable instead of the complex indirection with the > resources array > - Link to v1: https://lore.kernel.org/r/20260207-phy-apple-resource-err-ptr-v1-1-78735b07ed2d@jannau.net > --- Reviewed-by: Vladimir Oltean I hope this can be picked up for the linux-phy PR.