From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9CC046BF for ; Mon, 16 Feb 2026 22:50:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771282230; cv=none; b=A2dMFpwxRYZc/7mNdp1qe1UeSsQ5ghoxc5V0My+6zSMQgImDSUub7YDiOXM+GrnKl7QkFQc8c7nU3k6UhRLPBUDOUVEGI44miLvJFMVEeEjjAFb4ndRFO94Aq34DaEQ79Zv3wmCJootw6lyMnF6qBBCBCgW1PoSCH4iBNOA2sN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771282230; c=relaxed/simple; bh=emDALIDOZkWp3+vyl5Mu0AkLotRsFBd5mHXfKxA2OGw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BUWQHOEFSdcyOwrSJzjsugkSIROsXGclEgG2CN/QqanygGIp+O7uZ/u0l84YZii8NaAe+baIpDPeRT1p69foMJDRiUB8PIPE0kqUGlU6I0MpoiVAUBciSPSpEOzMdZIZMISVZSBJQkKhIgrvHSEQhHF8oioDkdHUAXt7ZQWfLPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Em5QWllz; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Em5QWllz" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4837584120eso23466085e9.1 for ; Mon, 16 Feb 2026 14:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771282227; x=1771887027; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GBNK5O29oFEZQwyUE/+YCmGgUzXBh+3R+deh6imRIQE=; b=Em5QWllz9cDrln8utm+cNtKN39YsIRp+r3sv7127PIKASOnsYQoHMfX1FyPYaRQjTq VlZizwKFpcpJccaL/vtxZAaJzwZ3JfZNjKupjjFkvdcOa7zYEI7WVvcW2E1Ps0e3xYrR 4AM/FKvPkhXu2BKacZbKWzBBFN/l3Fx7BCJGzg9thPrALBuXQg9R7/20mHeeuax18LSc ZpTYQCXfBPnVBiB6SLWT1UP9gjVT95+T/36azKRC4Yn6fSd1IXKtVc7u1YlSI3FXRyuA IP6Q5oqhVT8moK6eUnNrjA17AE/cX0fBB+JmZ+ahkW7UR+kdTfjHCMJAKmgRw38IjKhn Shdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771282227; x=1771887027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GBNK5O29oFEZQwyUE/+YCmGgUzXBh+3R+deh6imRIQE=; b=CpatsxjZ2BagNqFGM4eFVE54iYl3sQikDJcqaDbUfRJ4XPyRLxqzTt47TCbcgaIVUH JYqWo19cYxzInwSQ1jTSPjFkn4h7TO1aj/qjDR+2SE62BCvyC63zB8jtvYoAw087JIgG jXfM5mbeYvPGeu1VIfLv8Xv3OPaAcfxBi0VXQwj2yZ7Zk+BBWFAdItiHZhYV/P1n5jDQ gRXIVr4JU1QGhVSU1qvCDmV7aQcaSXzuV09wTDdLFoz5o8toD76hjoqBL+tmzq/3UCC4 e/PPNzhE6wcEBuWKMGf29c32UJUlcheR2q9mAaGMxCt//UAScJsV0ZDjExOnJ1JDfRp4 9yNQ== X-Forwarded-Encrypted: i=1; AJvYcCXnRTijSpRkNrP3wdzAbpM7X6EO5lzgJKS4BpzLMrr0hcHEtY2qZA+NYlE5B/TTq2Ha84wMsESTuLeIfu4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv/2nc9S8wFvSNE/eJYZMnnn7mH0lCfC1ymLNjBeEvrwWkSt6j nIod+x86r0CFGKMo0Qu0UYTbHS/WaM2o+bhLUOWuPrvAzEOMH5dFlHE8 X-Gm-Gg: AZuq6aKOh7C0CxBREcg8AKQZBGceIBv+N0Ao6/dBBDEMgsY9hACIV4zSkwStvBhDNVU +MpUaHRdTJR5AsPuxh2CjYE5B3AAR4qayGETyfX+jkzcPbdm3Txcr5oYyH2YgowpUtvmQszFyOd zi49Y1YEoXD631lApYqc2SPLmbVPyCfIIpNR81Cxpn+SrbBFAj83t0DU6VdHrQzGNTa640F5p3t 23TM0/ACAM1S52XlFea21TmeyP4pftCfx2hDjQdk32jxKww6ZJ+6rrUIVuTu2woPKcsmRSap8Yk j0ZtKav9/I7hjOixOSFPDo7VKup6EFS4Luff+oGQq2u+0uO9KARM6A69UVTcyvOlETszr03YdBT 9OtHm3E/N9U8uAUOIpI6xUflDA4oHx8oFkHsMX3ipvO0IRLIw8o9xToMnKKVSUFSDYOip3A7Hld kjeq1HPFHd2qcbX2wopXOamjf5dCuV9dCeUvCO/bZUYCqlJRzSLDQgR7t/IoAIyoh9 X-Received: by 2002:a05:600c:1c25:b0:483:54cc:cd97 with SMTP id 5b1f17b1804b1-48379bfc340mr144335235e9.36.1771282227235; Mon, 16 Feb 2026 14:50:27 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835d92267bsm697329395e9.0.2026.02.16.14.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Feb 2026 14:50:26 -0800 (PST) Date: Mon, 16 Feb 2026 22:50:25 +0000 From: David Laight To: Thomas =?UTF-8?B?V2Vpw59zY2h1aA==?= Cc: Willy Tarreau , linux-kernel@vger.kernel.org, Cheng Li Subject: Re: [PATCH v2 next 07/11] tools/nolibc/printf: Add support for conversion flags "#- +" and format "%X" Message-ID: <20260216225025.20d2589d@pumpkin> In-Reply-To: <817d73b2-9304-4ae4-8b0f-000891a61048@t-8ch.de> References: <20260206191121.3602-1-david.laight.linux@gmail.com> <20260206191121.3602-8-david.laight.linux@gmail.com> <817d73b2-9304-4ae4-8b0f-000891a61048@t-8ch.de> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 16 Feb 2026 20:57:37 +0100 Thomas Wei=C3=9Fschuh wrote: > On 2026-02-06 19:11:17+0000, david.laight.linux@gmail.com wrote: > > From: David Laight > >=20 > > Add support for all the normal flag chacacters except '0' (zero pad). > > '-' left alignment. > > '+' and ' ' Sign characters for non-negative numbers. > > '#' adds 0x to hex numbers. > > Partially support "%X", outputs lower case a..f the same as "%x". > >=20 > > Move the "%s" code in with the numeric formats to save a va_arg() call. > >=20 > > Prepend the sign (or "0x") after conversion to ascii and use the length > > returned by u64toh_r() and u64toa_r(). > > Both needed for precision and zero-padding in the next patch. > >=20 > > Signed-off-by: David Laight > > --- > >=20 > > Changes for v2: > > - Add support for left justifying fields (removed from patch 6). > > - Merge in the changes from the old patch 8. > > - Add support for "%#x" (formally part of patch 9). > >=20 > > tools/include/nolibc/stdio.h | 97 ++++++++++++++++++++++++++---------- > > 1 file changed, 71 insertions(+), 26 deletions(-) =20 >=20 > (...) >=20 > > +non_numeric_conversion: > > + if (ch =3D=3D 'm') { > > #ifdef NOLIBC_IGNORE_ERRNO > > outstr =3D "unknown error"; > > + len =3D __builtin_strlen(outstr); =20 >=20 > Why the builtin and not the regular one? In that case the builtin one will generate a compile-time constant. But that code gets changed in later patches. The #if belongs in strerror(). David >=20 > > #else > > outstr =3D strerror(errno); > > + goto do_strnlen_output; > > #endif /* NOLIBC_IGNORE_ERRNO */ > > } else { > > if (ch !=3D '%') { =20 >=20 > (...)