From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B72A2DF137 for ; Tue, 17 Feb 2026 08:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771315937; cv=none; b=Tkq7b51Q6oxnRn/b7YSaQz02VYYKeebBdaIws5sPCnn1k8Ol+a2RMK06O2X/tAHk5uSeueMCZW1JOhD7/H4zhVAaQHloRSMExDPz10acBkam68ZnLUPS47QkkdRu3v3ECIMUWpCSXtarhPMSIp8Ic+mhWNv4JoZJSHa+sXKIrWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771315937; c=relaxed/simple; bh=S8Cd2E8SKugiVyOxMAARAlFbe35TOZ5k+jrtw5MSFHQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PNqoZsAbgRNsqIN671fegzvm7GJ73Osi8tCzoUvMiHKVx1b8kOIr0dOfYI6LJHeSgX84v+TEwiiGCpUFooPG05ZLCKD079V6u0gtff2XRkkFR89hhYRtroz3Z3G0f2TPqWtIKEjFZC0hOJ2ws/mCuGx+YNPcCdBbAFkGUlBdDp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=cgUBJ5MB; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="cgUBJ5MB" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-436356740e6so4643596f8f.2 for ; Tue, 17 Feb 2026 00:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771315933; x=1771920733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f64XWOiLeopfzc8m0vbWs3v53yiP6RzpjdTcY0IqlPk=; b=cgUBJ5MBzOnccyxBEGrchpD5ZArfBjNucd/kJXMUWTIcFLFBASq/YNtUT6EvzQd0hP 5xGN6HeQz2xJBmL2au7pE0fVqjjCsT7YR7JdRqngQMa86+27+jhPyxDEejwTNhBuXiaG 1Bn7TDolS7l/X4E3xSDL4+JJ2PQ5riULtSPK4PSTumbuJmMaodWyoT/iETDz28qS3QOM cybm4MbOy1dxXYrTLlmfGMNPcQlTZMmPF5Bo8ybP95Mu92gPWWnZjpZpDy9w7eKWkh45 O9MBcy2NtfOAbtC7YLVXdji8pRIDAff9FIyguA83GMXfTlLJ3zgXtlb0/Q96Ney7t+m3 s/Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771315933; x=1771920733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f64XWOiLeopfzc8m0vbWs3v53yiP6RzpjdTcY0IqlPk=; b=Ufgc9CuNNtJtF286vH6I+9fMVvU8ELFxLg+wJd2eMlLJBH4j+8siSz2JidUKUJUYPr B4+sv0Pzsgt1jg4eUOTJeyBRZ4KWnWE8mTS+61L+nbyAWhBZbAbnVfdEB30yLBotKn7U WHYGL+W2D6sOvFUJtvINMPP6ISDrDCtt4GE9bb31HQw5XiDcIPoJPgEVREfBg4vlxLo6 TYU8SM7Yp3rKv64wqE56tU0c7nrCYeTv0KiNv32uVZ2I11JbhEhBhV8drk34vGJIkhIP Jk65N+lHNDZ2/csTR6zV+1bb4oHbkog2m4CT+TMhBf07S5apzuXlEc3fKmdLWWrXyjlL 1ivw== X-Forwarded-Encrypted: i=1; AJvYcCXvxNuxYQxabiCivkpkKZX1VVj9x3Dfv0OJIfm1WqUwGvPhSLgeHp/0IXZUJOvA60kBhFE6BiyfFpZ1BFI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywxr76zij8ZJzdK/tWqKb0JRpevuHspe32TvjkyT+6/gqqi5Vr8 xFrfEvpHW0XjXav+y/msx4zJ1naF38gFTLbsodlk0jzfxLVEwEbBBHzbRNSPWcxttxY= X-Gm-Gg: AZuq6aKI9qiXLOcLojmhFxPBo/sDy7GxY6AVr6uOzE3FiKCzmuzoO+bIfn5efrtwnDF Q4N0Fzyx6dRB78ObUDJEYSI1KBThu/EGw7SsZlnr4RpqKLVf2KogskXhDdL/spnu7QdtFn9wefE 5+1ZF5slXv4qQUZckmFWUndid7ZSFPQEkSmCGB2cRoIIpvtJJEQC8ZXUvWHaBOedNkT8adaG161 lx3vuaYB5ZI62x1MNW3rGd71K+Kuedcx//L6M4Kktoxwtaup35gTU5b+JZV4f1wfmv6nNYIr6Wr CDxSZAXDIUf/BYKjlg2oH3HfR9xydsl1CCTl+bIVhFZ1AAGHkGKGg9s/75MzGm/JINEjh3p6HM6 j7IstHNAbtpB3JPuhdpgvC3qTAFZHkxEEWYrc0MJjhCyoFhGKCMRr7v8yE1GoxLZtIoNaBFBiBU yiafO1k7pEe/wCRXic1JDKNO4KGbcNZnLQge8IGBX0TuNCVD5YA7dQb5A9QkpTTHwXQkyZZgdBM N4wQYz24w== X-Received: by 2002:a05:6000:2001:b0:435:96ec:679e with SMTP id ffacd0b85a97d-4379db61cccmr19577529f8f.23.1771315932698; Tue, 17 Feb 2026 00:12:12 -0800 (PST) Received: from silence.. ([46.10.240.40]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796a5d156sm35757690f8f.5.2026.02.17.00.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 00:12:12 -0800 (PST) From: Stoyan Bogdanov To: jbrunet@baylibre.com, linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net, skhan@linuxfoundation.org Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Stoyan Bogdanov Subject: [PATCH v3 3/3] hwmon: (pmbus/tps1689): Add TPS1689 support Date: Tue, 17 Feb 2026 10:12:03 +0200 Message-Id: <20260217081203.1792025-4-sbogdanov@baylibre.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260217081203.1792025-1-sbogdanov@baylibre.com> References: <20260217081203.1792025-1-sbogdanov@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Extend tps25990 existing driver to support tps1689 eFuse, since they are sharing command interface and functionality Update documentation for tps1689 Signed-off-by: Stoyan Bogdanov --- Documentation/hwmon/tps25990.rst | 15 ++++-- drivers/hwmon/pmbus/tps25990.c | 91 ++++++++++++++++++++++++++++---- 2 files changed, 92 insertions(+), 14 deletions(-) diff --git a/Documentation/hwmon/tps25990.rst b/Documentation/hwmon/tps25990.rst index 04faec780d26..e8bc9a550bda 100644 --- a/Documentation/hwmon/tps25990.rst +++ b/Documentation/hwmon/tps25990.rst @@ -9,26 +9,31 @@ Supported chips: Prefix: 'tps25990' - * Datasheet + Datasheet: Publicly available at Texas Instruments website: https://www.ti.com/lit/gpn/tps25990 - Publicly available at Texas Instruments website: https://www.ti.com/lit/gpn/tps25990 + * TI TPS1689 + + Prefix: 'tps1689' + + Datasheet: Publicly available at Texas Instruments website: https://www.ti.com/lit/gpn/tps1689 Author: Jerome Brunet + Stoyan Bogdanov Description ----------- -This driver implements support for TI TPS25990 eFuse. +This driver implements support for TI TPS25990 and TI TPS1689 eFuse chips. This is an integrated, high-current circuit protection and power management device with PMBUS interface -Device compliant with: +Devices are compliant with: - PMBus rev 1.3 interface. -Device supports direct format for reading input voltages, +Devices supports direct format for reading input voltages, output voltage, input current, input power and temperature. Due to the specificities of the chip, all history reset attributes diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c index 33f6367f797c..f9ff4edadf53 100644 --- a/drivers/hwmon/pmbus/tps25990.c +++ b/drivers/hwmon/pmbus/tps25990.c @@ -58,34 +58,38 @@ struct tps25990_data { struct local_direct_value *info_local; }; -static int tps25990_raw_to_value(struct i2c_client *client, int param, int raw) +static int tps25990_raw_to_value(struct i2c_client *client, int param, u32 raw) { struct tps25990_data *data = (struct tps25990_data *)of_device_get_match_data(&client->dev); struct local_direct_value *info_local = data->info_local; + int val; /* Formula : X = (Y / 10^R - b) / m */ if (info_local->R[param] >= 0) - raw /= int_pow(10, info_local->R[param]); + val = DIV_ROUND_CLOSEST_ULL(raw, int_pow(10, info_local->R[param])); else - raw *= int_pow(10, -info_local->R[param]); + val = raw * int_pow(10, -info_local->R[param]); - return DIV_ROUND_CLOSEST(raw - info_local->b[param], info_local->m[param]); + val = DIV_ROUND_CLOSEST(val - info_local->b[param], info_local->m[param]); + + return val; } static unsigned int tps25990_value_to_raw(struct i2c_client *client, int param, int val) { struct tps25990_data *data = (struct tps25990_data *)of_device_get_match_data(&client->dev); struct local_direct_value *info_local = data->info_local; + u32 raw; // return raw up to u16 -> u32 /* Formula : Y = ( m * X + b) * 10^R */ - val = (long)val * info_local->m[param] + info_local->b[param]; + raw = ((long)val * info_local->m[param]) + info_local->b[param]; if (info_local->R[param] >= 0) - val *= int_pow(10, info_local->R[param]); + raw *= int_pow(10, info_local->R[param]); else - val = DIV_ROUND_CLOSEST(val, int_pow(10, -info_local->R[param])); + raw = DIV_ROUND_CLOSEST_ULL(raw, int_pow(10, -info_local->R[param])); - return val; + return raw; } /* @@ -281,7 +285,6 @@ static int tps25990_write_word_data(struct i2c_client *client, value = clamp_val(value, 0, 0xff); ret = pmbus_write_word_data(client, page, reg, value); break; - case PMBUS_VIN_OV_FAULT_LIMIT: value = tps25990_value_to_raw(client, TPS25990_VIN_OVF, value); value = clamp_val(value, 0, 0xf); @@ -370,6 +373,15 @@ static const struct regulator_desc tps25990_reg_desc[] = { }; #endif +struct local_direct_value tps1689_local_info = { + .m[TPS25990_VIN_OVF] = 3984, + .b[TPS25990_VIN_OVF] = -63750, + .R[TPS25990_VIN_OVF] = -3, + .m[TPS25990_IIN_OCF] = 7111, + .b[TPS25990_IIN_OCF] = -2133, + .R[TPS25990_IIN_OCF] = -2, +}; + struct local_direct_value tps25590_local_info = { .m[TPS25990_VIN_OVF] = 10163, .b[TPS25990_VIN_OVF] = -30081, @@ -379,6 +391,60 @@ struct local_direct_value tps25590_local_info = { .R[TPS25990_IIN_OCF] = -6, }; +static struct pmbus_driver_info tps1689_base_info = { + .pages = 1, + .format[PSC_VOLTAGE_IN] = direct, + .m[PSC_VOLTAGE_IN] = 1166, + .b[PSC_VOLTAGE_IN] = 0, + .R[PSC_VOLTAGE_IN] = -2, + .format[PSC_VOLTAGE_OUT] = direct, + .m[PSC_VOLTAGE_OUT] = 1166, + .b[PSC_VOLTAGE_OUT] = 0, + .R[PSC_VOLTAGE_OUT] = -2, + .format[PSC_TEMPERATURE] = direct, + .m[PSC_TEMPERATURE] = 140, + .b[PSC_TEMPERATURE] = 32103, + .R[PSC_TEMPERATURE] = -2, + /* + * Current and Power measurement depends on the ohm value + * of Rimon. m is multiplied by 1000 below to have an integer + * and -3 is added to R to compensate. + */ + .format[PSC_CURRENT_IN] = direct, + .m[PSC_CURRENT_IN] = 9548, + .b[PSC_CURRENT_IN] = 0, + .R[PSC_CURRENT_IN] = -6, + .format[PSC_CURRENT_OUT] = direct, + .m[PSC_CURRENT_OUT] = 24347, + .b[PSC_CURRENT_OUT] = 0, + .R[PSC_CURRENT_OUT] = -3, + .format[PSC_POWER] = direct, + .m[PSC_POWER] = 2775, + .b[PSC_POWER] = 0, + .R[PSC_POWER] = -4, + .func[0] = (PMBUS_HAVE_VIN | + PMBUS_HAVE_VOUT | + PMBUS_HAVE_VMON | + PMBUS_HAVE_IIN | + PMBUS_HAVE_PIN | + PMBUS_HAVE_TEMP | + PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_STATUS_IOUT | + PMBUS_HAVE_STATUS_INPUT | + PMBUS_HAVE_STATUS_TEMP | + PMBUS_HAVE_SAMPLES), + + .read_word_data = tps25990_read_word_data, + .write_word_data = tps25990_write_word_data, + .read_byte_data = tps25990_read_byte_data, + .write_byte_data = tps25990_write_byte_data, + +#if IS_ENABLED(CONFIG_SENSORS_TPS25990_REGULATOR) + .reg_desc = tps25990_reg_desc, + .num_regulators = ARRAY_SIZE(tps25990_reg_desc), +#endif +}; + static struct pmbus_driver_info tps25990_base_info = { .pages = 1, .format[PSC_VOLTAGE_IN] = direct, @@ -428,18 +494,25 @@ static struct pmbus_driver_info tps25990_base_info = { #endif }; +struct tps25990_data data_tps1689 = { + .info = &tps1689_base_info, + .info_local = &tps1689_local_info, +}; + struct tps25990_data data_tps25990 = { .info = &tps25990_base_info, .info_local = &tps25590_local_info, }; static const struct i2c_device_id tps25990_i2c_id[] = { + { .name = "tps1689", .driver_data = (kernel_ulong_t)&data_tps1689 }, { .name = "tps25990", .driver_data = (kernel_ulong_t)&data_tps25990 }, {} }; MODULE_DEVICE_TABLE(i2c, tps25990_i2c_id); static const struct of_device_id tps25990_of_match[] = { + { .compatible = "ti,tps1689", .data = &data_tps1689 }, { .compatible = "ti,tps25990", .data = &data_tps25990 }, {} }; -- 2.34.1